From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oEKZLnT3Q2SdBAEASxT56A (envelope-from ) for ; Sat, 22 Apr 2023 17:04:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wFqiLnT3Q2RxdQEA9RJhRA (envelope-from ) for ; Sat, 22 Apr 2023 17:04:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A152E0D9 for ; Sat, 22 Apr 2023 17:04:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqEmI-0000eR-3M; Sat, 22 Apr 2023 11:03:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqEmG-0000e5-AI for emacs-orgmode@gnu.org; Sat, 22 Apr 2023 11:03:52 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqEmE-0004Lj-Px for emacs-orgmode@gnu.org; Sat, 22 Apr 2023 11:03:52 -0400 Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id c03295f0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 22 Apr 2023 15:03:49 +0000 (UTC) References: <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de> User-agent: mu4e 1.9.22; emacs 30.0.50 To: Axel Kielhorn Cc: emacs-orgmode@gnu.org Subject: Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG) Date: Sat, 22 Apr 2023 23:03:15 +0800 In-reply-to: <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ruijie Yu From: Ruijie Yu via "General discussions about Org-mode." Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682175860; a=rsa-sha256; cv=none; b=O89KPCl71fQYtPj1/v0lCmym/cqnL2Dw8+9cJ4QSdpxuCxm/Z2Rku0jV1LLXwsPvOYEX2J aiSbPlahfsbQfelzKBPYiqDqS3Qdo04kL8Ljus3y5OQ+9jDPeANuim1QtJTLyLfYNrJmAC LUr9hAo7adpbli0SNIsjsCsAoiD6PgB4wsJiYznhtPZC/f10lehRWN/lKdCQoj0iiFwV/8 AKBEFCdHNbdpXDEaINFDx2poVsW+4OPS7Ui9CNbngaqRAmuiKXdhV3kJSWurLRFuUVzJ4X m74R3mHq5Hn7q4uyBw9ru02UEQfJ98zlaaKXq4zKgFqKHOivdBQOy6oB2TEaWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682175860; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kPoEoNGhovsl49JoOsZbMvJ8tqqBJdZyvhDGJnFFnEw=; b=sduPX89uNf7aIuG/TyN6bZxBDox9FqtFq/GaqKSYLCVp3VAKRVc+g7bvQQU+arQOGMqtEg XP21gtqiIxjDzGLTaULUXI9kGZC0FOwSpf9P1u/hV2MGDN6ZJmJrz3FPnGr8yVQSpHf0AF Kqv4z7zERsG4xSZAG3ZGU+qS0ZSGcAQnG0ZDoccN/hV8/2lQ7+RQcsPxw7gJqLyPStkbgL jaW3v8SEjuTOPJ91hLQtsnOUqu+QZcmjxUTeu8qzov3UKf2YUy6slkUiwecTWcFS6ZUJ6J IvMT5j9nN48twI8154eCM6yPSSL8TEv9fvdwCfgujq5vSrfbhEGzEuNIGPcN3w== X-Migadu-Spam-Score: -1.91 X-Spam-Score: -1.91 X-Migadu-Queue-Id: 7A152E0D9 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: MgzFGW6VAlky Axel Kielhorn writes: >> Am 22.04.2023 um 15:01 schrieb Ruijie Yu via General discussions about O= rg-mode. : >>=20 >>=20 >> Ruijie Yu via "General discussions about Org-mode." writes: >>=20 >>> Ruijie Yu via "General discussions about Org-mode." writes: >>>=20 >>>> Ruijie Yu via "General discussions about Org-mode." writes: >>>>=20 >>>>> Axel Kielhorn writes: >>>>>=20 >>>>>> Hello! >>>>>>=20 >>>>>> I=E2=80=99m building org with LANG=3Dde. >>>>>> As a result I get two failed tests: >>>>>=20 >>>>> Reproducible using "LANG=3Dzh_CN.UTF-8". In fact, I got more failed = tests >>>>> in my testing. I think the OP's two test failures are due to hardcod= ed >>>>> English expected result, whereas the additional test failures on my >>>>> testing are probably due to the fact that each Chinese character is as >>>>> wide as two latin letters, which catches some testing code offguard. >>>>>=20 >>>>> Here are the test names that failed unexpectedly for me. All the >>>>> "should"'s and "should-not"'s are in the attachment below. >>>>>=20 >>>>> --8<---------------cut here---------------start------------->8--- >>>>> 8 unexpected results: >>>>> FAILED test-org-clock/clock-drawer-dwim >>>>> FAILED test-org-clock/clocktable/lang >>>>> FAILED test-org-clok/org-clock-timestamps-change >>>>> FAILED test-org-colview/columns-width >>>>> FAILED test-org/add-planning-info >>>>> FAILED test-org/clone-with-time-shift >>>>> FAILED test-org/deadline >>>>> FAILED test-org/schedule >>>>> --8<---------------cut here---------------end--------------->8--- >>>>>=20 >>>>> [3. text/plain; lang.txt]... >>>>=20 >>>> Update: interestingly, there is one test error when setting >>>> "LANG=3Den_US.UTF-8" or "LANG=3DC". >>>>=20 >>>> [2. text/plain; lang-en-us-utf8.txt]... >>>>=20 >>>>=20 >>>> And, two somewhat different test errors when setting "LANG=3Dfr_FR.UTF= -8". >>>>=20 >>>> [4. text/plain; lang-fr-fr-utf8.txt]... >>>=20 >>> Axel, does this patch fix test-org-clock/clock-drawer-dwim on your >>> system? >>>=20 >>> [2. text/x-patch; 0001-testing-lisp-test-org-clock.el.patch]... >>=20 >> Here is an updated patch (replacing the first iteration). This should >> hopefully fix both test failures that Axel found. Once this is >> confirmed good, I will look at the test failures of the other languages >> to see what I can do. >>=20 >> <0001-DRAFT-Fix-dependence-on-locale-in-org-testing-facili.patch> > > > With this patch I get: > FAILED test-org-clock/clock-drawer-dwim arrayp > FAILED test-org-clok/org-clock-timestamps-change arrayp > > Axel Thanks for testing. Will take a look tomorrow. --=20 Best, RY [Please note that this mail might go to spam due to some misconfiguration in my mail server -- still investigating.]