From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gE5zHfzVQ2SPTgAASxT56A (envelope-from ) for ; Sat, 22 Apr 2023 14:41:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4C83HfzVQ2TWlAAAauVa8A (envelope-from ) for ; Sat, 22 Apr 2023 14:41:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A49DA23D for ; Sat, 22 Apr 2023 14:41:32 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqCY0-0002lb-F3; Sat, 22 Apr 2023 08:41:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqCXx-0002l9-3o for emacs-orgmode@gnu.org; Sat, 22 Apr 2023 08:40:57 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqCXV-0007vc-Cs for emacs-orgmode@gnu.org; Sat, 22 Apr 2023 08:40:33 -0400 Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id ba11d54a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 22 Apr 2023 12:40:19 +0000 (UTC) References: User-agent: mu4e 1.9.22; emacs 30.0.50 To: Ruijie Yu Cc: Axel Kielhorn , emacs-orgmode@gnu.org Subject: Re: Test failure due to LANG Date: Sat, 22 Apr 2023 20:37:43 +0800 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ruijie Yu From: Ruijie Yu via "General discussions about Org-mode." Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682167292; a=rsa-sha256; cv=none; b=KuBKXAzFg9u5VrbRKl1t9WWb27xp8imKJN/huF25KwC9NLeIsdkbqx+IW8LFYkTRib3RGh ahlDA+wzreagKtFcqJoRqCPL1Fbdli4sQOsbjw5O23NYixmxoYs+8ut8S4OA2J5bjI+fJq 2LD6CfquclFukgJbmmqhHwf0CWXBM/Yku6iaaCX2tNon9tRS1eOAuTSBTVq2NNlAusGwsf /99sl8615IEiSkCE0rTNrOHK2LVE5mqO3vCLLd7zhskOSqWDRiXJRC6doYD3KOcFiPP8GE uLhuFDf9Ph+oQgZsnaf64ZYSIw42d89urbf1Sx4TxNb1egPOr57Z+ov5tAlMVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682167292; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=guQ4Fr7pIF3HkTnevYY5THXkpzq9r0nUih/xeYJ9+tM=; b=LLdOPvqiscSWhWY50+Es30I+1NEopBHM4opxL4OwtyWM06g5+bvwVbRQwl5aZwZ8Z76BKg gG3QfvcmE3lbxhwnVD+/xSjJw/cnH7EihWStMKIjhRHqsL7TCpq9iu1eE/n2tPMDpoUGjC fsQ/fQWRsPqZChwmtC6oNeIewBRpju3QIYwLTTz/J7uI6PGZSI5/HZ8MlhJKdnam1VjEEv ckUsbgzfUQSOVI7W+M5Q3MH5QmK2ZeHo9ibisX1/5DwogShQMWFCXYmGz92eIV+6xfR85l tD0mctyvJdhnKtwMrABdTSVgzcBwCUVSreOP2pk7KyQESIBsjcVe/jutQTUSQw== X-Migadu-Spam-Score: -3.81 X-Spam-Score: -3.81 X-Migadu-Queue-Id: 0A49DA23D X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: fEIRQGpnPy1C --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ruijie Yu via "General discussions about Org-mode." = writes: > Ruijie Yu via "General discussions about Org-mode." writes: > >> Axel Kielhorn writes: >> >>> Hello! >>> >>> I=E2=80=99m building org with LANG=3Dde. >>> As a result I get two failed tests: >> >> Reproducible using "LANG=3Dzh_CN.UTF-8". In fact, I got more failed tes= ts >> in my testing. I think the OP's two test failures are due to hardcoded >> English expected result, whereas the additional test failures on my >> testing are probably due to the fact that each Chinese character is as >> wide as two latin letters, which catches some testing code offguard. >> >> Here are the test names that failed unexpectedly for me. All the >> "should"'s and "should-not"'s are in the attachment below. >> >> --8<---------------cut here---------------start------------->8--- >> 8 unexpected results: >> FAILED test-org-clock/clock-drawer-dwim >> FAILED test-org-clock/clocktable/lang >> FAILED test-org-clok/org-clock-timestamps-change >> FAILED test-org-colview/columns-width >> FAILED test-org/add-planning-info >> FAILED test-org/clone-with-time-shift >> FAILED test-org/deadline >> FAILED test-org/schedule >> --8<---------------cut here---------------end--------------->8--- >> >> [3. text/plain; lang.txt]... > > Update: interestingly, there is one test error when setting > "LANG=3Den_US.UTF-8" or "LANG=3DC". > > [2. text/plain; lang-en-us-utf8.txt]... > > > And, two somewhat different test errors when setting "LANG=3Dfr_FR.UTF-8". > > [4. text/plain; lang-fr-fr-utf8.txt]... Axel, does this patch fix test-org-clock/clock-drawer-dwim on your system? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-testing-lisp-test-org-clock.el.patch >From e223381ca670f99e6f6d69a7920923e2ad5ea91c Mon Sep 17 00:00:00 2001 From: Ruijie Yu Date: Sat, 22 Apr 2023 20:36:18 +0800 Subject: [PATCH] * testing/lisp/test-org-clock.el Avoid hard-coded values where locales play a significant role. --- testing/lisp/test-org-clock.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/testing/lisp/test-org-clock.el b/testing/lisp/test-org-clock.el index 7d8123e1f..3f587ce05 100644 --- a/testing/lisp/test-org-clock.el +++ b/testing/lisp/test-org-clock.el @@ -299,11 +299,12 @@ the buffer." (ert-deftest test-org-clock/clock-drawer-dwim () "Test DWIM update of days for clocks in logbook drawers." - (should (equal "* Foo + (should (equal (let ((thu (format-time-string "%a" 1000))) + (format "* Foo :LOGBOOK: -CLOCK: [2022-11-03 Thu 06:00]--[2022-11-03 Thu 06:01] => 0:01 +CLOCK: [2022-11-03 %s 06:00]--[2022-11-03 %s 06:01] => 0:01 :END: -" +" thu thu)) (org-test-with-temp-text "* Foo :LOGBOOK: -- 2.40.0 --=-=-= Content-Type: text/plain -- Best, RY [Please note that this mail might go to spam due to some misconfiguration in my mail server -- still investigating.] --=-=-=--