From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4PO9HfLD6WBEeAEAgWs5BA (envelope-from ) for ; Sat, 10 Jul 2021 17:59:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kLRCGfLD6WC3AQAAB5/wlQ (envelope-from ) for ; Sat, 10 Jul 2021 15:59:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13A15192C2 for ; Sat, 10 Jul 2021 17:59:46 +0200 (CEST) Received: from localhost ([::1]:46240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2FOL-00018U-75 for larch@yhetil.org; Sat, 10 Jul 2021 11:59:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2FD0-00080n-AA for emacs-orgmode@gnu.org; Sat, 10 Jul 2021 11:48:03 -0400 Received: from ciao.gmane.io ([116.202.254.214]:36944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2FCy-000456-Vj for emacs-orgmode@gnu.org; Sat, 10 Jul 2021 11:48:02 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1m2FCx-00047w-BX for emacs-orgmode@gnu.org; Sat, 10 Jul 2021 17:47:59 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: [BUG] org-goto slows down org-set-property Date: Sat, 10 Jul 2021 22:47:49 +0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625932786; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eXjHaF3yU5Gi7rnhQBfg1MsfVXyWrbGiWWVWlqAIEAc=; b=eVmTEhFP6A3xf8Ytp2cTz0bsfR85ohXRxknxlB6CrnI4hTnx+b+dlK4GP8IkTRdmLJmg/+ cqM0a89tXm5f/Ic5LtV65ZCszPoDXn0wxrrWYOnn/4qVv3LN8DGU+jN6vcxhkOUZpK+bnQ ++eUCPYyuRzWE2wILi8U9ycpg3ImUbrUvLPxvnNJYzi+dP/NDMCQmxOatCWThMSMpPb3Mr Kjrf4PT39s7NpTqeErSoAaYUfYmry6smu+/4FbrEHbT/keNRAO1paAdgDJ2Ql1tq2VWehL HykQ4sDEiiMyXWjWz5kWHnzHzPETtIXIVU65ixog/i2TFppjVAIHASdzvyDqsQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625932786; a=rsa-sha256; cv=none; b=a2ziVe3720ucJvMTEElgz3uJBGmOz9U+Mla1FYZ2vOoj65hEnjUH9LgmzNIPD/lHMTVmUi rCQkaZv0XLEwoHa/6qQPp44jyd19v7gWeL1hiXqjvXDteFTBlOTTA5x1lynXvbQkHfCB7Y n4D27cErHHsJmuy9BF2ZvBUnZmnz2XazuwX9enqZJSV2JXwtXsOh/wl3RuK4oFjFSsXpYi sizOZZVl1orgnRq+iTCSHl2iiklZpyTuKO8AWkxUQmKBZY18qnwS/u44dznjdaO8x+FCE/ rPzNMbFlB/kwp2gxuk9cfAeyiRQzE8N1l/pApzJODCQcTEtFolKiTxiCzVVhwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 13A15192C2 X-Spam-Score: -1.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1W6w+TLv9+wi It is rather annoying that C-c C-x p `org-set-property' may be quite slow if a file is large enough. (I do not consider it huge however.) There is noticeable delay before the prompt for property name appears in minibuffer. Accidentally I have noticed that sometimes it is fast. Problem appears after first jump using C-u C-c C-j `org-goto'. Actually a jump is not required, it is enough to get jump (refile) targets. I hope, the following numbers are convincing enough. Second attempt to get list of properties is much slower than the first one. #+begin_src elisp (require 'org-refile) (let ((org-refile-targets '((nil :maxlevel . 6))) (org-refile-use-outline-path 'file) (org-refile-use-cache t) (iters 10)) (cons (list (org-version)) (mapcar (lambda (f) (append (list f) (benchmark-run iters (funcall f)))) (list #'org-buffer-property-keys #'org-refile-get-targets #'org-buffer-property-keys)))) #+end_src git master: #+RESULTS: | 9.4.6 | | | | | org-buffer-property-keys | 0.065695 | 0 | 0.0 | | org-refile-get-targets | 1.836473 | 12 | 0.39498671199999985 | | org-buffer-property-keys | 0.563227 | 0 | 0.0 | elpa-org system package for Ubuntu-20.04 is even more slower: #+RESULTS: | 9.3.1 | | | | | org-buffer-property-keys | 0.242574778 | 0 | 0.0 | | org-refile-get-targets | 2.669112479 | 13 | 0.285175928 | | org-buffer-property-keys | 1.231223427 | 0 | 0.0 | The effect is noticeable for the doc/org-manual.org file from org sources though absolute numbers are well below delay that makes interaction incomfortable. In the configuration above effect of `org-refile-use-cache' is crucial, contribution of `org-refile-use-outline-path' is noticeable but not so important. My expectation is that neither `org-refile-use-cache' nor `org-goto' command should make adding property slower.