From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id v3W2GsxL4WBtcAAAgWs5BA (envelope-from ) for ; Sun, 04 Jul 2021 07:49:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KI/nFcxL4WCxYQAA1q6Kng (envelope-from ) for ; Sun, 04 Jul 2021 05:49:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C91EC23C1E for ; Sun, 4 Jul 2021 07:48:59 +0200 (CEST) Received: from localhost ([::1]:45964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzuzx-00036y-TX for larch@yhetil.org; Sun, 04 Jul 2021 01:48:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzuzV-00036q-LI for emacs-orgmode@gnu.org; Sun, 04 Jul 2021 01:48:29 -0400 Received: from ciao.gmane.io ([116.202.254.214]:55910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzuzU-0001m2-25 for emacs-orgmode@gnu.org; Sun, 04 Jul 2021 01:48:29 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lzuzQ-0006vj-Sf for emacs-orgmode@gnu.org; Sun, 04 Jul 2021 07:48:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] make org-notify support for macOS desktop notification Date: Sun, 4 Jul 2021 12:48:16 +0700 Message-ID: References: <5B57CD8B-AA91-4C63-A449-A07364083AEE@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <5B57CD8B-AA91-4C63-A449-A07364083AEE@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625377739; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Nkars17Mo97oKzz1glWH1qfDNavHrxy9o3+lItFhPP0=; b=e7TebC1Qj7iK8Jp7PjAm0RL2O3CVCt9WWkZXx6oE7TcZg9rgukv7DlYp/dRcwLHlJoDMH1 mvbspFf4FTgOwsYzKya5ttHlGaF7B8UxIH48ehY3RKgCFaDA7H7PK8qHlHBrvqzaoHIs+t ENcjwQ5CLf6u1evUPWljJ10ztL4zGsB8/YGmN3D1z+57Fhkk19r1ZqrLPjj2KdOK+0pkqK kcFswi0DsbBieVVxL0A4uy1aZqKkr1EdqMNY5c38KkwXebY5pWHwJ4aPJUw59EyX95tsXV ZAKsMjMonhbb9PVd/T0V2A6Nnhfk2jF/YHB+ip0AtQfM1s+PsT7PMqQ6hFPDKA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625377739; a=rsa-sha256; cv=none; b=Ot3m3uUifVRhjK2iTUc+I5GWzu90XHneQwtJp9QkbDgnt/kM/jSjMbEDsH3u2OBX92sYy0 BhDeT4HhE52ibmYyPMRTZuYnS5bgrqxuhq8ZYXPklF90shLlt0fC4mB3/Gs3ix/HwB225z dqcPOEyhpSjiPSTqP1c6Ua1vE4EOmeOlFYPqs31TCxdIzzFr7BTEQLA24ZZs29Q/c+5lCi yzUSfw/RXRIxGzYYXOld60gcGGQXWcwR177ZNWyzq3EihvEhKTnSwQWRfqgqSc9CrrTeVp 6psEdU9A5cCXmtt6jSx08GlaqcZbkb2SnOrcuWQqdMTJkh80uJNUz0opGdCZUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C91EC23C1E X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: i+/XtatVbVjw On 04/07/2021 07:23, stardiviner wrote: > I found `org-notify` does not support macOS desktop notification. So I write a small patch for this. I am surprised that there is no OS-agnostic function in Emacs that sends simple notification, suitable when no advanced feature are necessary. Only OS-dependent variants are implemented for Linux and Windows. > + (format "'display notification \"%s\" with title \"title\"'" notification "Org mode message"))) Unsafe substitution of the argument. There is no guarantee that notification has no quote characters. I do not know, which link you would prefer: - old https://xkcd.com/327/ "Robert'); DROP TABLE" - recent https://arstechnica.com/gadgets/2021/06/mass-data-wipe-in-my-book-devices-prompts-warning-from-western-digital/ Wipe data from NAS (accordingly to some sources, device can be protected by firewall, it is enough to open in a browser a page with a malicious element, e.g. in a comment of an earlier visitor) The preferred way is to pass such parameters as separate arguments of `start-process'. I am not familiar with osascript, I hope, it does not additionally interpret strings passed to "display notification" to do something fancy things. Example with sh: Current unsafe variant: > sh -c "`printf 'echo "%s: %s - %s"' 'some-command' '"; echo another action ; echo "' 'second arg' With parameters passed as separate arguments to avoid interpretation of special characters: > sh -c 'echo "$0: $1 - $2"' 'some-command' '"; echo another action ; echo "' 'second arg'