From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Danjou <julien@danjou.info>
Subject: Re: [PATCH] Always return refreshed category
Date: Thu, 23 Dec 2010 17:03:00 +0100
Message-ID: <sa3ei98fpe3.fsf@cigue.easter-eggs.fr>
References: <1293026785-12467-1-git-send-email-julien@danjou.info>
	<74C83FF2-959A-4C7D-B161-0C333EEE36DD@gmail.com>
	<87d3osa42b.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1512163413=="
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=49177 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PVndB-0006TU-FN
	for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 11:03:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien@danjou.info>) id 1PVndA-0005xM-5a
	for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 11:03:05 -0500
Received: from coquelicot-s.easter-eggs.com ([213.215.37.94]:55986)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@danjou.info>) id 1PVnd9-0005vY-Oa
	for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 11:03:04 -0500
In-Reply-To: <87d3osa42b.fsf@fastmail.fm> (Matt Lundin's message of "Thu, 23
	Dec 2010 10:42:36 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>

--===============1512163413==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 23 2010, Matt Lundin wrote:

> Another observation: org-refresh-category-properties returns t

That's the 't' you see as category.

> and thus
> short-circuits the "or" here. Is the following perhaps the intended
> behavior?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index e80d2fc..55f1bf1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -8143,8 +8143,8 @@ call CMD."
>    "Get the category applying to position POS."
>    (let ((pos (or pos (point))))
>      (or (get-text-property pos 'org-category)
> -	(org-refresh-category-properties)
> -	(get-text-property pos 'org-category))))
> +	(progn (org-refresh-category-properties)
> +	       (get-text-property pos 'org-category)))))
>=20=20
>  (defun org-refresh-category-properties ()
>    "Refresh category text properties in the buffer."

Good catch indeed, I missed a progn.

=2D-=20
Julien Danjou
=E2=9D=B1 http://julien.danjou.info

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk0TcrUACgkQpGK1HsL+5c2ukACg1v2feztLKxAKDlxBaKJgzCMP
P7kAoKwP6QBFizvvWDVn7p9hsuEZYw9u
=Epgv
-----END PGP SIGNATURE-----
--=-=-=--


--===============1512163413==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

--===============1512163413==--