From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ebOyB8GapmAcMQEAgWs5BA (envelope-from ) for ; Thu, 20 May 2021 19:22:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EHDNAsGapmC2QwAA1q6Kng (envelope-from ) for ; Thu, 20 May 2021 17:22:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9942F20913 for ; Thu, 20 May 2021 19:22:08 +0200 (CEST) Received: from localhost ([::1]:58702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljmN4-00029Q-Ns for larch@yhetil.org; Thu, 20 May 2021 13:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljm7j-0002hq-6l for emacs-orgmode@gnu.org; Thu, 20 May 2021 13:06:15 -0400 Received: from ciao.gmane.io ([116.202.254.214]:37208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljm7h-0005uY-P5 for emacs-orgmode@gnu.org; Thu, 20 May 2021 13:06:14 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ljm7f-0005Tk-Ih for emacs-orgmode@gnu.org; Thu, 20 May 2021 19:06:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: [Patch] tests for org-remove-invisible Date: Fri, 21 May 2021 00:06:01 +0700 Message-ID: References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> <87r1j6b6ku.fsf@nicolasgoaziou.fr> <87a6pt9hyd.fsf@nicolasgoaziou.fr> <874kg0ae0k.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621531328; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LB6BPBnVPSiWGtBLh6S9ZQnx6XpkuaAQkZl240pu9tE=; b=OHWJDXU3e1vcrwV/gRMa5xokpS6ulo/vYm5IH3YlhhOPBq2JChRVxWbAlvhR703+3JOmpK 4adftITadKW0glHqY+A9f9m7rdEDC9rfhWhimD5Kh4EPQOWyM5IWmMAbvrCiBuIqcTVnGi TysIbSgpNPKqYQrB3WBzDTxo9O/rzi4LJqFvGBxfrQKwUDAOXQr/0ljDJGcmS6fES/OcIh AxFQE2wu5sGPQwaW3S13B8AlurXo/wi4DGghIsZeWhBRx5UHqKWr/nOyI2M+ZOxh2EOr5O jv9GqQYVDgX+EIr9ZxvJFdIA0/vHDwFRUSJGyYQ4Jtlunxk8OkrosYpMt1maOA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621531328; a=rsa-sha256; cv=none; b=QIz2ouUk+NQ5j2Q+Y3sWl0iM8VAps9Jx7pIB+MwdVeK3HrToWfxeEtVVznDp6WBiuwZ6Lw CH70ozlwi3pQ483ecNAwhhSWFjiSyy8TTPvvqciZJbhQkiiRVQPRisNvw0DUSr1k2Vn+/L v0bt8JJIGUJeVQM1ne8RpArUrQM9KqPIrETGWbjGc1k5jrBA75/Be+joQOV287Iux8qj9G XYoDLghobRXH/87kCiIzu6kYR5010OYGjchZC5fcMHtuCUwmw7tncFlV5+cKkE8+gbm/eM KZnpQ+pXLRR5MeQUsJ1M6xzfB2CVeRAt7zMyfCtT7D4cstw5w5z1SkYjGOY3Bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9942F20913 X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: ggrvRDls9rxj The main patch that fixes org-remove-invisible to improve list sorting is landed. Let me remind that there were patches that added more test cases: https://orgmode.org/list/s5p88r$go9$1@ciao.gmane.io Is there any interest in them? In the following subthread Nicolas mentioned that some of them could fail https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8, es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any problem. This set of locales has 3 different collation rules, however I do not think it matters for tests. On 20/04/2021 19:37, Maxim Nikulin wrote: > On 20/04/2021 00:50, Nicolas Goaziou wrote: >> Maxim Nikulin writes: >> >>> On 19/04/2021 23:08, Nicolas Goaziou wrote: >>>>> + ;; Space role in sorting. >>>>> + ;; Test would fail for locales with ignored space, e.g. en_US, it works >>>>> + ;; in C and currently rare locales having significant space (es_ES, pl_PL) >>>>> + (should >>>>> + (equal "- Time stamp\n- Timer\n" >>>>> + (org-test-with-temp-text "- Timer\n- Time stamp\n" >>>>> + (org-sort-list t ?a) >>>>> + (buffer-string)))))) >>>> Since this test is bound to fail for some developers, I assume it >>>> shouldn't be included. >>> >>> Locale "C" is forced for this group of tests. >> >> Sorry, I don't understand. There is no locale change around this test, >> so it will fail, for example, for me. I wouldn't want to get a noisy >> failure each time I run tests. > > Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine). > > There is redefinition of `string-collate-lessp' to run tests with "C" locale: > https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207 > > And it works for me