From: Maxim Nikulin <manikulin@gmail.com> To: emacs-orgmode@gnu.org Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list Date: Tue, 20 Apr 2021 22:51:47 +0700 [thread overview] Message-ID: <s5mtak$u46$1@ciao.gmane.io> (raw) In-Reply-To: <87a6pt9hyd.fsf@nicolasgoaziou.fr> On 20/04/2021 20:57, Nicolas Goaziou wrote: > Maxim Nikulin writes: >> (org-sort-remove-invisible "A") >> #("A" 0 1 (:parent (#("A" 0 1 ...)))) > > This is a string. Thank you, from second attempt I have managed to strip text properties. Since the intended usage of return value is sorting key, would not it benefit from passing result through the following expression? (set-text-properties 0 (length s) nil s) An alternative is to clean up keys in `org-sort-list' function. > Ah! I forgot the link part! Hopefully done here. Surprisingly there are still cases when the old approach works better: (let ((s (org-sort-remove-invisible "A /wrapping [[https://orgmode.org/?a=b&c=d#e][link]] emphasis/"))) (set-text-properties 0 (length s) nil s) s) "A wrapping [[https://orgmode.org?a=b&c=d#e][link]] emphasis/" I expect "A wrapping link emphasis". In the meanwhile I have tried (benchmark-run 1 (org-sort-list t ?a)) in a file (1100 lines) obtained using grep '^- ' doc/org-manual.org >/tmp/list.org It seems, performance is still acceptable (single run hardly could be considered as an accurate test): (1.115571472 18 0.5986466069999999) ; new variant (0.260384514 1 0.09805475199999947) ; original code > --8<---------------cut here---------------start------------->8--- > (defun org-sort-remove-invisible (s) > "Remove emphasis markers and any invisible property from string S. > Assume S may contain only objects." > ;; org-element-interpret-data clears any text property, including > ;; invisible part. > (org-element-interpret-data > (let ((tree (org-element-parse-secondary-string > s (org-element-restriction 'paragraph)))) > (org-element-map tree '(bold code italic link strike-through underline verbatim) > (lambda (o) > (pcase (org-element-type o) > ;; Terminal object. Replace it with its value. > ((or `code `verbatim) > (let ((new (org-element-property :value o))) > (org-element-insert-before new o) > (org-element-put-property > new :post-blank (org-element-property :post-blank o)))) > ;; Non-terminal objects. Splice contents. > (type > (let ((contents > (or (org-element-contents o) > (and (eq type 'link) > (list (org-element-property :raw-link o))))) > (c nil)) > (while contents > (setq c (pop contents)) > (org-element-insert-before c o)) > (org-element-put-property > c :post-blank (org-element-property :post-blank o))))) > (org-element-extract-element o))) > ;; Return modified tree. > tree))) > --8<---------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2021-04-20 15:59 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 18:15 Juan Manuel Macías 2021-04-09 22:28 ` Nicolas Goaziou 2021-04-10 0:01 ` Juan Manuel Macías 2021-04-10 10:19 ` Nicolas Goaziou 2021-04-10 11:41 ` Juan Manuel Macías 2021-04-13 17:31 ` Maxim Nikulin 2021-04-13 19:08 ` Juan Manuel Macías 2021-04-14 15:42 ` Maxim Nikulin 2021-04-14 15:51 ` Maxim Nikulin 2021-04-14 17:07 ` Juan Manuel Macías 2021-04-14 21:36 ` Juan Manuel Macías 2021-04-15 14:58 ` Maxim Nikulin 2021-04-15 18:21 ` Juan Manuel Macías 2021-04-16 14:59 ` Maxim Nikulin 2021-04-16 15:30 ` Maxim Nikulin 2021-04-17 13:27 ` Maxim Nikulin 2021-04-18 17:52 ` Juan Manuel Macías 2021-04-18 21:20 ` Juan Manuel Macías 2021-04-19 8:33 ` Nicolas Goaziou 2021-04-19 12:34 ` Maxim Nikulin 2021-04-19 16:08 ` Nicolas Goaziou 2021-04-19 17:00 ` Greg Minshall 2021-04-19 17:17 ` Tom Gillespie 2021-04-19 18:00 ` Greg Minshall 2021-04-19 17:36 ` Maxim Nikulin 2021-04-19 17:50 ` Nicolas Goaziou 2021-04-20 12:37 ` Maxim Nikulin 2021-04-20 12:20 ` Maxim Nikulin 2021-04-20 13:57 ` Nicolas Goaziou 2021-04-20 15:51 ` Maxim Nikulin [this message] 2021-04-20 20:37 ` Nicolas Goaziou 2021-04-21 13:10 ` Maxim Nikulin 2021-04-21 15:45 ` Juan Manuel Macías 2021-04-24 14:41 ` Maxim Nikulin 2021-05-20 17:06 ` [Patch] tests for org-remove-invisible Maxim Nikulin 2021-05-20 18:06 ` Nicolas Goaziou 2021-09-27 16:53 ` Max Nikulin 2021-11-25 12:11 ` [Patch] to correctly sort the items with emphasis marks in a list Ihor Radchenko 2021-11-25 16:59 ` Max Nikulin 2021-05-15 20:43 ` Bastien 2021-05-15 22:09 ` Nicolas Goaziou 2021-05-16 6:04 ` Bastien 2021-04-28 5:46 ` Bastien 2021-04-28 6:37 ` Nicolas Goaziou 2021-04-28 6:49 ` Bastien 2021-04-28 8:04 ` Bastien 2021-05-15 13:32 ` Bastien 2021-05-15 15:10 ` Maxim Nikulin 2021-05-15 20:44 ` Bastien 2021-04-12 13:50 Juan Manuel Macías [not found] <mailman.57.1618243212.17744.emacs-orgmode@gnu.org> 2021-04-12 18:51 ` Ypo 2021-04-12 23:18 ` Juan Manuel Macías 2021-04-12 23:52 ` Samuel Wales 2021-04-13 14:16 ` Juan Manuel Macías
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='s5mtak$u46$1@ciao.gmane.io' \ --to=manikulin@gmail.com \ --cc=emacs-orgmode@gnu.org \ --subject='Re: [Patch] to correctly sort the items with emphasis marks in a list' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).