From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ucZ6FzrSaWB8awEAgWs5BA (envelope-from ) for ; Sun, 04 Apr 2021 16:50:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ALp7EDrSaWBaCwAA1q6Kng (envelope-from ) for ; Sun, 04 Apr 2021 14:50:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C51672D6BC for ; Sun, 4 Apr 2021 16:50:33 +0200 (CEST) Received: from localhost ([::1]:37664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT45A-0004mx-VA for larch@yhetil.org; Sun, 04 Apr 2021 10:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT44i-0004mc-Sb for emacs-orgmode@gnu.org; Sun, 04 Apr 2021 10:50:04 -0400 Received: from ciao.gmane.io ([116.202.254.214]:60646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT44h-0006YB-Fh for emacs-orgmode@gnu.org; Sun, 04 Apr 2021 10:50:04 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lT44g-0009qQ-4e for emacs-orgmode@gnu.org; Sun, 04 Apr 2021 16:50:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: [PATCH 3/3] test-org-protocol.el: Add expected failures for file:/// URLs Date: Sun, 4 Apr 2021 21:44:58 +0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617547833; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SVUCz9+ia06/3IlTgjTwfhLKtlSFAotpojq0DkEpUA4=; b=h/0p7WBN1Uv3B/PqskiYUoJ3/lWBiOhDCWlXAB8cAHJ7LQ78H9jumHXPFfK/N9SSlaw4Jt aR9ZRHMKW1iizDzyXKqbf4Lx7X+K3SOjryGguWFhPourx7Y3JKuYefWqeK/zfYL/ctsiQn 8bEqhwGiYQ9KBHe+OqkbRoUx2NCfJW/oGMjpW8vV7xHyX5ImSiIi1JINyZoFspZz/AJ1Hq PiraaHrXSpfn2Y0rapemfgrBZOgA57Q1uYjjzKpiBpzEBt/hoyJAsE8ZeNfkDf9A6710/7 Le62I6YcqvqfdtcgagjtWqQa0XgHZUf/krGRmrrQ4VKnDQL+E5QI62SV0g7zuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617547833; a=rsa-sha256; cv=none; b=ItuGBSPUewMx91oHjuUUPMfhgboEcrMn2+GODsfMEEn0H935ZjpLRXFO3G5W6AP7sYADs/ LTUR6UEPSq740hYbK7QBx5MnLhdbKrouHskL6ifUbdCqopP3wT16f+NdfPtzXCi6uYyw5m Kgz8eLrbdqPK9IGlnCQc29DP00sG/PXNWACFMl1eAd3FkhZQJwzHNIaYLgmWDEeai1YEx5 7H/0q9ksA61ab6Mq9oz8tQLYyLh59Mg3HjcOa0Ztp3zsA28fEViPsCr1pizz2s57wq2e5C SLimJKYHc1EI+57PjvjbovFnjPoy9DVg4zDzBuOiBz65SybWXkAYsNxXEgFfaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: C51672D6BC X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: J8YG7OnoZ4Dr * testing/lisp/test-org-protocol.el (test-org-protocol/org-protocol-store-link-file, test-org-protocol/org-protocol-capture-file): Add tests to document that existing calls to `org-protocol-sanitize-uri' could make passed URLs invalid by changing number of slashes after scheme. Till a fix of the problem the new tests are marked as expected failures. Unless a relatively recent commit 5748615c48, I would believe that `org-protocol-sanitize-uri' was added by mistake to the initial implementation. Capture URLs are anyway escaped with percent encoding. --- testing/lisp/test-org-protocol.el | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/testing/lisp/test-org-protocol.el b/testing/lisp/test-org-protocol.el index 5ab96fdc2..d33052b30 100644 --- a/testing/lisp/test-org-protocol.el +++ b/testing/lisp/test-org-protocol.el @@ -78,6 +78,16 @@ (should (null (org-protocol-check-filename-for-protocol uri (list uri) nil))) (should (equal (car org-stored-links) '("URL3" "TITLE3"))))) +(ert-deftest test-org-protocol/org-protocol-store-link-file () + "store-link: `org-protocol-sanitize-uri' could distort URL." + :expected-result :failed + (let ((uri "/org-protocol:/store-link:/file%3A%2F%2F%2Fetc%2Fmailcap/Triple%20Slash")) + (should (null (org-protocol-check-filename-for-protocol uri (list uri) nil))) + (should (equal (car org-stored-links) '("file:///etc/mailcap" "Triple Slash")))) + (let ((uri "/org-protocol:/store-link?url=file%3A%2F%2F%2Fetc%2Fmailcap&title=Triple%20Slash")) + (should (null (org-protocol-check-filename-for-protocol uri (list uri) nil))) + (should (equal (car org-stored-links) '("file:///etc/mailcap" "Triple Slash"))))) + (ert-deftest test-org-protocol/org-protocol-capture () "Test `org-protocol-capture' specifications." (let* ((org-protocol-default-template-key "t") @@ -134,6 +144,20 @@ test-urls) (delete-file temp-file-name))) +(ert-deftest test-org-protocol/org-protocol-capture-file () + "capture: `org-protocol-sanitize-uri' could distort URL." + :expected-result :failed + (let* ((org-protocol-default-template-key "t") + (temp-file-name (make-temp-file "org-protocol-test")) + (org-capture-templates + `(("t" "Test" plain (file ,temp-file-name) "%a\n%i\n" :kill-buffer t)))) + (let ((uri "/org-protocol:/capture:/t/file%3A%2F%2F%2Fetc%2Fmailcap/Triple%20Slash/Body")) + (should (null (org-protocol-check-filename-for-protocol uri (list uri) nil))) + (should (string= (buffer-string) "[[file:///etc/mailcap][Triple Slash]]\nBody"))) + (let ((uri "/org-protocol:/capture?template=t&url=file%3A%2F%2F%2Fetc%2Fmailcap&title=Triple%20Slash&body=Body")) + (should (null (org-protocol-check-filename-for-protocol uri (list uri) nil))) + (should (string= (buffer-string) "[[file:///etc/mailcap][Triple Slash]]\nBody"))))) + (ert-deftest test-org-protocol/org-protocol-open-source () "Test org-protocol://open-source links." (let* ((temp-file-name1 (make-temp-file "org-protocol-test1")) -- 2.25.1