From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cq/WNYQxW2D+MgAA0tVLHw (envelope-from ) for ; Wed, 24 Mar 2021 12:33:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EL04MYQxW2AkIwAAB5/wlQ (envelope-from ) for ; Wed, 24 Mar 2021 12:33:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A451520898 for ; Wed, 24 Mar 2021 13:33:07 +0100 (CET) Received: from localhost ([::1]:60582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP2h7-0005tl-Uc for larch@yhetil.org; Wed, 24 Mar 2021 08:33:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP2gF-0005ta-Qg for emacs-orgmode@gnu.org; Wed, 24 Mar 2021 08:32:11 -0400 Received: from ciao.gmane.io ([116.202.254.214]:42568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP2gE-0005Hh-4B for emacs-orgmode@gnu.org; Wed, 24 Mar 2021 08:32:11 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lP2gC-0004ZE-Bg for emacs-orgmode@gnu.org; Wed, 24 Mar 2021 13:32:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)] Date: Wed, 24 Mar 2021 19:31:57 +0700 Message-ID: References: <87pn03g3rr.fsf@localhost> <87sg4zu47p.fsf@kyleam.com> <87k0qbk4rq.fsf@localhost> <87h7lfk4mz.fsf@localhost> <8735wvuvi3.fsf@localhost> <87czvv5gil.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87czvv5gil.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616589188; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xguk0A3aXvrLnyNcaq7D3cPEuFZsNIw5IMZ1WoJG3pw=; b=Oa8TwkVK9cPTaZsWwmhkSTP65Jo01FzONwe6lTRds2NxWFiwvCb+JB3Qjo4j2+F/wE9Kb0 ayBWHN5kqTVBVjPq0tAH8aYnpSUuEkBaBWkokYuRzGCnlWT0eo7VAy1GHR0x1xQsugN1H6 uO+4NBHH6eQ6SYJb4FN3wn7nFj2ubyauTIDwMUTgfSDTu/C8SSrjdpbhTfrygf8l/p/eR/ VtF8plP+x/7FUcsheWAoROpG5qJ0LXRGaUFzT54/PvV5KC3s9Lgh6hbBa+rWPIcQuvm7lL kj2fLyC+lAowc1Uu3bugVyWKer18b1UNdsQ1WOriuZqTWoe5m3I8pyrVjEzxrg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616589188; a=rsa-sha256; cv=none; b=kGR45qff9U7EP9G+m5ormSmPjilBO+2SXjU3oKRZEVcxbd+B3UhODRBY668L6K4hQ2GxWs icQ7AL3t31lWVBQ5PFR3ycFcDwjwXYFUOWEFW110gcyFYt22quaEhRCzywqJN3eLqpKjDr gWxX2ldz7leuaOWHpoldv5HSnqLhPR+u+N5cVdhIVfgDbWPTCnxwf6s30edazEVSV7DVxl 9AtznV4QMGDVzdGOTE2ibr6xvtDhdXTXRbg+FV0WTAp7y+ykUD1pi9iYsH6RPoDoZpQa9N rBHP3qjsOQDO8PtUGyv5KvWM+R4hmDS1YSrSGi/GcKMpRT9chSBzYum03dv9aw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A451520898 X-Spam-Score: -2.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: lby5Z1wpw3M7 On 19/03/2021 22:07, Ihor Radchenko wrote: > Maxim Nikulin writes: > >> I could not guess how to benchmark font-lock. I have tried to open file >> (to get everything loaded), kill the buffer, > > I usually just use profiler-start/open buffer/profiler-report. However, > there is also https://github.com/Lindydancer/font-lock-profiler for more > fine-grained benchmark. Also, you may instrument org-activate-links with > elp.el (built-in). I suspect I may not notice performance penalty due to some specific usage pattern (e.g. I rarely use links in heading titles) or due to absence of some customization. I have converted bracketed links to plain ones, so I have more than 4000 links in the test file. I expect that regexp affects loading of a file. As earlier, org-activate-links entry in profiler-report have less than 1%. I have tried elp. My measurements are not accurate due to I did not fix CPU regime to performance. I have seen times varied quite widely (several times) but often the numbers are the same with and without your patch. I am puzzled a bit by number of calls. (progn (require 'elp) (setq elp-function-list (list #'org-activate-links)) (elp-instrument-list nil) (dolist (i (number-sequence 1 10)) (message "iter %d" i) (find-file "plain.org") (sit-for 3) (kill-buffer "plain.org") (sit-for 1)) (elp-results)) Example for #+STARTUP: overview: org-activate-links 560 0.028971085 5.173...e-05 For content number of calls is 410, without special settings (all) 120, let me remind that it is for 10 find-file invocations. Another example org-activate-links 410 0.1384633219 0.0003377154 I see such variations in both cases with and without the patch, but these numbers are negligible in my opinion. I decided to stop experiments since I could not reproduce decrease in performance. Thank you for the font-lock-profiler link however. So I have no reason to be against more complicated regexp. >> Are changes in white spaces below actually modified lines in your patch >> intended? > > They are generated by aggressive-indent. Since org files mix indentation > styles I keep getting those whitespace changes in my patches. Forgot to > remove this time. Should I? In my opinion, combining changes related to white spaces and meaningful modifications makes commits less clear, especially when reading email. However the following recommendation has certainly more weight: https://orgmode.org/list/87zh2hosex.fsf@bzg.fr/ From: Bastien > Also, the convention in Emacs is to avoid whitespaces-only commits, > you need to fix whitespaces within other non-whitespaces changes in > a commit.