From mboxrd@z Thu Jan 1 00:00:00 1970 From: emacs18@gmail.com (Richard Y. Kim) Subject: Re: patch for HTML links to GNU documents Date: Mon, 28 Mar 2016 22:24:41 -0700 Message-ID: References: <871t6vrn9r.fsf@nicolasgoaziou.fr> Reply-To: emacs18@gmail.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akmEH-000318-2g for emacs-orgmode@gnu.org; Tue, 29 Mar 2016 01:30:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akmEC-00032X-15 for emacs-orgmode@gnu.org; Tue, 29 Mar 2016 01:30:13 -0400 Received: from plane.gmane.org ([80.91.229.3]:37080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akmEB-00031Q-Mk for emacs-orgmode@gnu.org; Tue, 29 Mar 2016 01:30:07 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1akmE8-0001Kg-T9 for emacs-orgmode@gnu.org; Tue, 29 Mar 2016 07:30:05 +0200 Received: from us03-fw-02-hide.synopsys.com ([149.117.7.28]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2016 07:30:04 +0200 Received: from emacs18 by us03-fw-02-hide.synopsys.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2016 07:30:04 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > Richard Kim writes: > >> Attached patch affects how 'info' links in org mode are converted to HTML >> links. Today info links such as >> >> [[info:emacs#List Buffers]] >> >> are converted to this HTML link: >> >> emacs#List Buffers >> >> With the patch applied, the HTML link generated would be >> >> emacs#List >> Buffers > > Thank you. Some comments follow. > >> +(defvar org-info-emacs-documents > > I suggest to use `defconst' instead, since you're not modifying or > let-binding the variable whatsoever. > >> + '("ada-mode" "auth" "autotype" "bovine" "calc" "ccmode" "cl" "dbus" "dired-x" >> + "ebrowse" "ede" "ediff" "edt" "efaq-w32" "efaq" "eieio" "eintr" "elisp" >> + "emacs-gnutls" "emacs-mime" "emacs" "epa" "erc" "ert" "eshell" "eudc" "eww" >> + "flymake" "forms" "gnus" "htmlfontify" "idlwave" "ido" "info" "mairix-el" >> + "message" "mh-e" "newsticker" "nxml-mode" "octave-mode" "org" "pcl-cvs" >> + "pgg" "rcirc" "reftex" "remember" "sasl" "sc" "semantic" "ses" "sieve" >> + "smtpmail" "speedbar" "srecode" "todo-mode" "tramp" "url" "vip" "viper" >> + "widget" "wisent" "woman") >> + "List of emacs documents available at the official URL >> +") > > The first sentence in the docstring is expected to be on a single line, > e.g. > > "List of emacs documents available. > Taken from " > >> +(defvar org-info-other-documents > > `defconst' > > Could you also write an entry about it in ORG-NEWS? Nicolas, I made all the changes that you suggested in the attached patch. Please let me know if further changes are needed. I mailed in my signed licensing paper for emacs to FSF today, so that it FSF should get it later this week. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-info.el-generate-HTML-links-to-gnu.org.patch Content-Description: updated patch >From 20adf43716f602e0c4be1a427bf8c6afd5e44c7e Mon Sep 17 00:00:00 2001 From: Richard Kim Date: Thu, 10 Mar 2016 06:29:48 -0800 Subject: [PATCH] org-info.el: generate HTML links to gnu.org * lisp/org-info.el (org-info-export): Convert info links to HTML URL's that point to appropriate gnu.org or other pages. User's can customize the behavior using `org-info-emacs-documents' and `org-info-other-documets' new variables. TINYCHANGE --- etc/ORG-NEWS | 14 ++++++++++++++ lisp/org-info.el | 35 +++++++++++++++++++++++++++++++++-- 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 4e6c7cb..3ddc3f9 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -317,6 +317,20 @@ called with 6 parameters. *** =ITEM= special property returns headline without stars *** Rename ~org-insert-columns-dblock~ into ~org-columns-insert-dblock~ The previous name is, for the time being, kept as an obsolete alias. +*** Function ~org-info-export~ changes. +HTML links created from certain info links now point to =gnu.org= URL's rather +than just to local files. For example info links such as =info:emacs#List +Buffers= used to be converted to HTML links like this: + +: emacs#List Buffers + +where local file =emacs.html= is referenced. +For most folks this file does not exist. +Thus the new behavior is to generate this HTML link instead: + +: emacs#List Buffers + +All emacs related info links are similarly translated plus few other =gnu.org= manuals. * Version 8.3 ** Incompatible changes diff --git a/lisp/org-info.el b/lisp/org-info.el index 270c19f..07693fe 100644 --- a/lisp/org-info.el +++ b/lisp/org-info.el @@ -81,6 +81,37 @@ nodename-or-index))))) (user-error "Could not open: %s" name))) +(defconst org-info-emacs-documents + '("ada-mode" "auth" "autotype" "bovine" "calc" "ccmode" "cl" "dbus" "dired-x" + "ebrowse" "ede" "ediff" "edt" "efaq-w32" "efaq" "eieio" "eintr" "elisp" + "emacs-gnutls" "emacs-mime" "emacs" "epa" "erc" "ert" "eshell" "eudc" "eww" + "flymake" "forms" "gnus" "htmlfontify" "idlwave" "ido" "info" "mairix-el" + "message" "mh-e" "newsticker" "nxml-mode" "octave-mode" "org" "pcl-cvs" + "pgg" "rcirc" "reftex" "remember" "sasl" "sc" "semantic" "ses" "sieve" + "smtpmail" "speedbar" "srecode" "todo-mode" "tramp" "url" "vip" "viper" + "widget" "wisent" "woman") + "List of emacs documents available. +Taken from ") + +(defconst org-info-other-documents + '(("libc" . "http://www.gnu.org/software/libc/manual/html_mono/libc.html") + ("make" . "http://www.gnu.org/software/make/manual/make.html")) + "Alist of documents generated from texinfo source. + +When converting info links to html, links to any one of these manuals are +converted to use these URL's.") + +(defun org-info-map-html-url (filename) + "Given info FILENAME, either return it (plus '.html' suffix added) or convert +it to URL pointing to the official page on internet, e.g., use gnu.org for all +emacs related documents. See `org-info-official-gnu-document' and +`org-info-other-documents' for details." + (if (member filename org-info-emacs-documents) + (format "http://www.gnu.org/software/emacs/manual/html_mono/%s.html" + filename) + (let ((url (cdr (assoc filename org-info-other-documents)))) + (or url (concat filename ".html"))))) + (defun org-info-export (path desc format) "Export an info link. See `org-add-link-type' for details about PATH, DESC and FORMAT." @@ -89,8 +120,8 @@ See `org-add-link-type' for details about PATH, DESC and FORMAT." (string-match "\\(.*\\)" path)) (let ((filename (match-string 1 path)) (node (or (match-string 2 path) "Top"))) - (format "%s" - filename + (format "%s" + (org-info-map-html-url filename) (replace-regexp-in-string " " "-" node) (or desc path))))) -- 2.5.0 --=-=-=--