Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Richard Kim <emacs18@gmail.com> writes:
>
>> Attached patch affects how 'info' links in org mode are converted to HTML
>> links.  Today info links such as
>>
>>     [[info:emacs#List Buffers]]
>>
>> are converted to this HTML link:
>>
>>     <a href="emacs.html#List-Buffers">emacs#List Buffers</a>
>>
>> With the patch applied, the HTML link generated would be
>>
>>     <a href="
>> http://www.gnu.org/software/emacs/manual/html_mono/emacs.html#List-Buffers">emacs#List
>> Buffers</a>
>
> Thank you. Some comments follow.
>
>> +(defvar org-info-emacs-documents
>
> I suggest to use `defconst' instead, since you're not modifying or
> let-binding the variable whatsoever.
>
>> +  '("ada-mode" "auth" "autotype" "bovine" "calc" "ccmode" "cl" "dbus" "dired-x"
>> +    "ebrowse" "ede" "ediff" "edt" "efaq-w32" "efaq" "eieio" "eintr" "elisp"
>> +    "emacs-gnutls" "emacs-mime" "emacs" "epa" "erc" "ert" "eshell" "eudc" "eww"
>> +    "flymake" "forms" "gnus" "htmlfontify" "idlwave" "ido" "info" "mairix-el"
>> +    "message" "mh-e" "newsticker" "nxml-mode" "octave-mode" "org" "pcl-cvs"
>> +    "pgg" "rcirc" "reftex" "remember" "sasl" "sc" "semantic" "ses" "sieve"
>> +    "smtpmail" "speedbar" "srecode" "todo-mode" "tramp" "url" "vip" "viper"
>> +    "widget" "wisent" "woman")
>> +  "List of emacs documents available at the official URL
>> +<http://www.gnu.org/software/emacs/manual/html_mono/.>")
>
> The first sentence in the docstring is expected to be on a single line,
> e.g.
>
>   "List of emacs documents available.
>   Taken from <http://www.gnu.org/software/emacs/manual/html_mono/.>"
>
>> +(defvar org-info-other-documents
>
> `defconst'
>
> Could you also write an entry about it in ORG-NEWS?

Nicolas,

I made all the changes that you suggested in the attached patch.
Please let me know if further changes are needed.

I mailed in my signed licensing paper for emacs to FSF today, so that it
FSF should get it later this week.