From mboxrd@z Thu Jan 1 00:00:00 1970 From: emacs18@gmail.com (Richard Y. Kim) Subject: [PATCH] org-contribute: fix a type by changing "column" to "colon" Date: Sat, 15 Nov 2014 11:03:07 -0800 Message-ID: Reply-To: emacs18@gmail.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpict-0000Ym-Jl for emacs-orgmode@gnu.org; Sat, 15 Nov 2014 14:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpico-0001WA-SH for emacs-orgmode@gnu.org; Sat, 15 Nov 2014 14:03:15 -0500 Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:61610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpico-0001Vv-HI for emacs-orgmode@gnu.org; Sat, 15 Nov 2014 14:03:10 -0500 Received: by mail-pd0-f178.google.com with SMTP id y13so3524341pdi.23 for ; Sat, 15 Nov 2014 11:03:09 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Attached patch fixes a typo and also removes trailing white spaces. The white spaces were removed due to adding a hook to remove them as shown here: (defun kimr-before-save-hook () "Delete trailing white spaces only in a few modes." (when (eq major-mode 'org-mode) (delete-trailing-whitespace))) (add-hook 'before-save-hook 'kimr-before-save-hook) Please let me know if trailing white spaces should not be removed in general so that I will omit such changes in future patches. Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-contribute-fix-a-type-by-changing-column-to-colo.patch >From 06bb6361813dad0f1ac111c573f5dd325c47d9e7 Mon Sep 17 00:00:00 2001 From: Kim Date: Sat, 15 Nov 2014 10:58:25 -0800 Subject: [PATCH] org-contribute: fix a type by changing "column" to "colon" * worg/org-contribute.org: fixed a typo. Also removed trailing white spaces in 8 lines. TINYCHANGE --- org-contribute.org | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/org-contribute.org b/org-contribute.org index cbcee3f..c763b25 100644 --- a/org-contribute.org +++ b/org-contribute.org @@ -4,7 +4,7 @@ #+OPTIONS: H:3 num:nil toc:t \n:nil ::t |:t ^:t -:t f:t *:t tex:t d:(HIDE) tags:not-in-toc #+STARTUP: align fold nodlcheck hidestars oddeven lognotestate #+SEQ_TODO: TODO(t) INPROGRESS(i) WAITING(w@) | DONE(d) CANCELED(c@) -#+TAGS: Write(w) Update(u) Fix(f) Check(c) +#+TAGS: Write(w) Update(u) Fix(f) Check(c) #+LANGUAGE: en #+PRIORITIES: A C B #+CATEGORY: worg @@ -34,7 +34,7 @@ where your contribution will be useful: - you can submit *patches* -- You can submit patches to the mailing list. See the [[For Org contributors: preferred way of submitting patches][Preferred way of submitting patches]] section for - details. You can run =make test= to check that your patch does + details. You can run =make test= to check that your patch does not introduce new bugs. If your patch is against a file that is part of Emacs, then your @@ -42,7 +42,7 @@ where your contribution will be useful: 15 lines/ (See the [[http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/etc/CONTRIBUTE][etc/CONTRIBUTE file in GNU Emacs]].) If you contribute more, you have to assign the copyright of your contribution to the Free Software Foundation (see below). - + - you can submit Org *add-ons* -- there are many Org add-ons. - The best way is to submit your code to [[file:org-mailing-list.org][the mailing list]] to discuss it with people. @@ -271,7 +271,7 @@ A commit message should be constructed in the following way: - Line 1 of the commit message should always be a short description of the overall change. Line 1 does /not/ get a dot at the end and does not start with a star. Generally, it starts with the filename that - has been changed, followed by a column. + has been changed, followed by a colon. - Line 2 is an empty line. @@ -283,7 +283,7 @@ A commit message should be constructed in the following way: : (org-timer-set-timer): Use the number of minutes in the Effort : property as the default timer value. Three prefix arguments will : ignore the Effort value property. - + - After the changelog, another empty line should come before any additional information that the committer wishes to provide in order to explain the patch. @@ -307,18 +307,18 @@ Here is an example for such a message: #+begin_example org-capture.el: Fix the case of using a template file - + ,* lisp/org-capture.el (org-capture-set-plist): Make sure txt is a string before calling `string-match'. (org-capture-templates): Fix customization type. ,* doc/org.texi (Capture): Document using a file for a template. - + The problem here was that a wrong keyword was given in the customization type. This let to a string-match against a list value. - + Modified from a patch proposal by Johan Friis. - + TINYCHANGE #+end_example -- 1.9.1 --=-=-=--