From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Thompson Subject: Bug: (org-set-tags t t) gives an error point is not currently on a headline Date: Thu, 8 Apr 2010 11:11:44 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001636e0b92dadd7660483bd9d32 Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzwD5-0000ij-KS for emacs-orgmode@gnu.org; Thu, 08 Apr 2010 14:12:11 -0400 Received: from [140.186.70.92] (port=34663 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzwD3-0000i3-SB for emacs-orgmode@gnu.org; Thu, 08 Apr 2010 14:12:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzwD2-0006Js-1o for emacs-orgmode@gnu.org; Thu, 08 Apr 2010 14:12:09 -0400 Received: from mail-pw0-f41.google.com ([209.85.160.41]:57523) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzwD1-0006JY-MJ for emacs-orgmode@gnu.org; Thu, 08 Apr 2010 14:12:08 -0400 Received: by pwi2 with SMTP id 2so2755515pwi.0 for ; Thu, 08 Apr 2010 11:12:06 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org-Mode List --001636e0b92dadd7660483bd9d32 Content-Type: text/plain; charset=ISO-8859-1 Hi, When I run (org-set-tags t t) to realign all tags in the buffer, it doesn't work unless the point is currently on a headline, because org-set-tags calls (org-get-tags-string) early on, and org-get-tags-string raises an error if not on a headline. This can be fixed by moving the binding of `current' to `(org-get-tags-string)' into the else clause of the first if statment. I have attached a patch -Ryan -- --001636e0b92dadd7660483bd9d32 Content-Type: text/x-patch; charset=US-ASCII; name="fix-org-set-tags-with-prefix.diff" Content-Disposition: attachment; filename="fix-org-set-tags-with-prefix.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g7rvwns30 ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXggZGM0NTg3MS4uMTc0 NTExNiAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcuZWwKQEAgLTEyMTEz LDcgKzEyMTEzLDcgQEAgSWYgREFUQSBpcyBuaWwgb3IgdGhlIGVtcHR5IHN0cmluZywgYW55IHRh Z3Mgd2lsbCBiZSByZW1vdmVkLiIKIFdpdGggcHJlZml4IEFSRywgcmVhbGlnbiBhbGwgdGFncyBp biBoZWFkaW5ncyBpbiB0aGUgY3VycmVudCBidWZmZXIuIgogICAoaW50ZXJhY3RpdmUgIlAiKQog ICAobGV0KiAoKHJlIChjb25jYXQgIl4iIG91dGxpbmUtcmVnZXhwKSkKLQkgKGN1cnJlbnQgKG9y Zy1nZXQtdGFncy1zdHJpbmcpKQorCSA7KGN1cnJlbnQgKG9yZy1nZXQtdGFncy1zdHJpbmcpKQog CSAoY29sIChjdXJyZW50LWNvbHVtbikpCiAJIChvcmctc2V0dGluZy10YWdzIHQpCiAJIHRhYmxl IGN1cnJlbnQtdGFncyBpbmhlcml0ZWQtdGFncyA7IGNvbXB1dGVkIGJlbG93IHdoZW4gbmVlZGVk CkBAIC0xMjEyNiw2OCArMTIxMjYsNzEgQEAgV2l0aCBwcmVmaXggQVJHLCByZWFsaWduIGFsbCB0 YWdzIGluIGhlYWRpbmdzIGluIHRoZSBjdXJyZW50IGJ1ZmZlci4iCiAJICAgICAgKG9yZy1zZXQt dGFncyBuaWwgdCkKIAkgICAgICAoZW5kLW9mLWxpbmUgMSkpKQogCSAgKG1lc3NhZ2UgIkFsbCB0 YWdzIHJlYWxpZ25lZCB0byBjb2x1bW4gJWQiIG9yZy10YWdzLWNvbHVtbikpCi0gICAgICAoaWYg anVzdC1hbGlnbgotCSAgKHNldHEgdGFncyBjdXJyZW50KQotCTs7IEdldCBhIG5ldyBzZXQgb2Yg dGFncyBmcm9tIHRoZSB1c2VyCi0JKHNhdmUtZXhjdXJzaW9uCi0JICAoc2V0cSB0YWJsZSAoYXBw ZW5kIG9yZy10YWctcGVyc2lzdGVudC1hbGlzdAotCQkJICAgICAgKG9yIG9yZy10YWctYWxpc3Qg KG9yZy1nZXQtYnVmZmVyLXRhZ3MpKQotCQkJICAgICAgKGFuZCBvcmctY29tcGxldGUtdGFncy1h bHdheXMtb2ZmZXItYWxsLWFnZW5kYS10YWdzCi0JCQkJICAgKG9yZy1nbG9iYWwtdGFncy1jb21w bGV0aW9uLXRhYmxlIChvcmctYWdlbmRhLWZpbGVzKSkpKQotCQlvcmctbGFzdC10YWdzLWNvbXBs ZXRpb24tdGFibGUgdGFibGUKLQkJY3VycmVudC10YWdzIChvcmctc3BsaXQtc3RyaW5nIGN1cnJl bnQgIjoiKQotCQlpbmhlcml0ZWQtdGFncyAobnJldmVyc2UKLQkJCQkobnRoY2RyIChsZW5ndGgg Y3VycmVudC10YWdzKQotCQkJCQkobnJldmVyc2UgKG9yZy1nZXQtdGFncy1hdCkpKSkKLQkJdGFn cwotCQkoaWYgKG9yIChlcSB0IG9yZy11c2UtZmFzdC10YWctc2VsZWN0aW9uKQotCQkJKGFuZCBv cmctdXNlLWZhc3QtdGFnLXNlbGVjdGlvbgotCQkJICAgICAoZGVscSBuaWwgKG1hcGNhciAnY2Ry IHRhYmxlKSkpKQotCQkgICAgKG9yZy1mYXN0LXRhZy1zZWxlY3Rpb24KLQkJICAgICBjdXJyZW50 LXRhZ3MgaW5oZXJpdGVkLXRhZ3MgdGFibGUKLQkJICAgICAoaWYgb3JnLWZhc3QtdGFnLXNlbGVj dGlvbi1pbmNsdWRlLXRvZG8gb3JnLXRvZG8ta2V5LWFsaXN0KSkKLQkJICAobGV0ICgob3JnLWFk ZC1jb2xvbi1hZnRlci10YWctY29tcGxldGlvbiB0KSkKLQkJICAgIChvcmctdHJpbQotCQkgICAg IChvcmctd2l0aG91dC1wYXJ0aWFsLWNvbXBsZXRpb24KLQkJICAgICAgKG9yZy1pY29tcGxldGlu Zy1yZWFkICJUYWdzOiAiICdvcmctdGFncy1jb21wbGV0aW9uLWZ1bmN0aW9uCi0JCQkJICAgICAg IG5pbCBuaWwgY3VycmVudCAnb3JnLXRhZ3MtaGlzdG9yeSkpKSkpKSkKLQkod2hpbGUgKHN0cmlu Zy1tYXRjaCAiWy0rJl0rIiB0YWdzKQotCSAgOzsgTm8gYm9vbGVhbiBsb2dpYywganVzdCBhIGxp c3QKLQkgIChzZXRxIHRhZ3MgKHJlcGxhY2UtbWF0Y2ggIjoiIHQgdCB0YWdzKSkpKQotCi0gICAg ICAoaWYgb3JnLXRhZ3Mtc29ydC1mdW5jdGlvbgotICAgICAgCSAgKHNldHEgdGFncyAobWFwY29u Y2F0ICdpZGVudGl0eQotICAgICAgCQkJCShzb3J0IChvcmctc3BsaXQtc3RyaW5nIHRhZ3MgKG9y Zy1yZSAiW15bOmFsbnVtOl1fQF0rIikpCi0gICAgICAJCQkJICAgICAgb3JnLXRhZ3Mtc29ydC1m dW5jdGlvbikgIjoiKSkpCi0KLSAgICAgIChpZiAoc3RyaW5nLW1hdGNoICJcXGBbXHQgXSpcXCci IHRhZ3MpCi0JICAoc2V0cSB0YWdzICIiKQotCSh1bmxlc3MgKHN0cmluZy1tYXRjaCAiOiQiIHRh Z3MpIChzZXRxIHRhZ3MgKGNvbmNhdCB0YWdzICI6IikpKQotCSh1bmxlc3MgKHN0cmluZy1tYXRj aCAiXjoiIHRhZ3MpIChzZXRxIHRhZ3MgKGNvbmNhdCAiOiIgdGFncykpKSkKLQotICAgICAgOzsg SW5zZXJ0IG5ldyB0YWdzIGF0IHRoZSBjb3JyZWN0IGNvbHVtbgotICAgICAgKGJlZ2lubmluZy1v Zi1saW5lIDEpCi0gICAgICAoY29uZAotICAgICAgICgoYW5kIChlcXVhbCBjdXJyZW50ICIiKSAo ZXF1YWwgdGFncyAiIikpKQotICAgICAgICgocmUtc2VhcmNoLWZvcndhcmQKLQkgKGNvbmNhdCAi XFwoWyBcdF0qIiAocmVnZXhwLXF1b3RlIGN1cnJlbnQpICJcXClbIFx0XSokIikKLQkgKHBvaW50 LWF0LWVvbCkgdCkKLQkoaWYgKGVxdWFsIHRhZ3MgIiIpCi0JICAgIChzZXRxIHJwbCAiIikKLQkg IChnb3RvLWNoYXIgKG1hdGNoLWJlZ2lubmluZyAwKSkKLQkgIChzZXRxIGMwIChjdXJyZW50LWNv bHVtbikgcDAgKGlmIChlcXVhbCAoY2hhci1iZWZvcmUpID8qKQotCQkJCQkgICAoMSsgKHBvaW50 KSkgKHBvaW50KSkKLQkJYzEgKG1heCAoMSsgYzApIChpZiAoPiBvcmctdGFncy1jb2x1bW4gMCkK LQkJCQkgICAgb3JnLXRhZ3MtY29sdW1uCi0JCQkJICAoLSAoLSBvcmctdGFncy1jb2x1bW4pIChs ZW5ndGggdGFncykpKSkKLQkJcnBsIChjb25jYXQgKG1ha2Utc3RyaW5nIChtYXggMCAoLSBjMSBj MCkpID9cICkgdGFncykpKQotCShyZXBsYWNlLW1hdGNoIHJwbCB0IHQpCi0JKGFuZCAobm90IChm ZWF0dXJlcCAneGVtYWNzKSkgYzAgaW5kZW50LXRhYnMtbW9kZSAodGFiaWZ5IHAwIChwb2ludCkp KQotCXRhZ3MpCi0gICAgICAgKHQgKGVycm9yICJUYWdzIGFsaWdubWVudCBmYWlsZWQiKSkpCi0g ICAgICAob3JnLW1vdmUtdG8tY29sdW1uIGNvbCkKLSAgICAgICh1bmxlc3MganVzdC1hbGlnbgot CShydW4taG9va3MgJ29yZy1hZnRlci10YWdzLWNoYW5nZS1ob29rKSkpKSkKKyAgICAgIDsobGV0 ICgoY3VycmVudCAodW5sZXNzIGFyZyAob3JnLWdldC10YWdzLXN0cmluZykpKSkKKyAgICAgIChs ZXQgKChjdXJyZW50IChvcmctZ2V0LXRhZ3Mtc3RyaW5nKSkpCisgICAgICAgIChpZiBqdXN0LWFs aWduCisKKyAgICAgICAgICAgIChzZXRxIHRhZ3MgY3VycmVudCkKKyAgICAgICAgICA7OyBHZXQg YSBuZXcgc2V0IG9mIHRhZ3MgZnJvbSB0aGUgdXNlcgorICAgICAgICAgIChzYXZlLWV4Y3Vyc2lv bgorICAgICAgICAgICAgKHNldHEgdGFibGUgKGFwcGVuZCBvcmctdGFnLXBlcnNpc3RlbnQtYWxp c3QKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG9yIG9yZy10YWctYWxpc3QgKG9y Zy1nZXQtYnVmZmVyLXRhZ3MpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYW5k IG9yZy1jb21wbGV0ZS10YWdzLWFsd2F5cy1vZmZlci1hbGwtYWdlbmRhLXRhZ3MKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAob3JnLWdsb2JhbC10YWdzLWNvbXBsZXRpb24t dGFibGUgKG9yZy1hZ2VuZGEtZmlsZXMpKSkpCisgICAgICAgICAgICAgICAgICBvcmctbGFzdC10 YWdzLWNvbXBsZXRpb24tdGFibGUgdGFibGUKKyAgICAgICAgICAgICAgICAgIGN1cnJlbnQtdGFn cyAob3JnLXNwbGl0LXN0cmluZyBjdXJyZW50ICI6IikKKyAgICAgICAgICAgICAgICAgIGluaGVy aXRlZC10YWdzIChucmV2ZXJzZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChu dGhjZHIgKGxlbmd0aCBjdXJyZW50LXRhZ3MpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAobnJldmVyc2UgKG9yZy1nZXQtdGFncy1hdCkpKSkKKyAgICAgICAgICAg ICAgICAgIHRhZ3MKKyAgICAgICAgICAgICAgICAgIChpZiAob3IgKGVxIHQgb3JnLXVzZS1mYXN0 LXRhZy1zZWxlY3Rpb24pCisgICAgICAgICAgICAgICAgICAgICAgICAgIChhbmQgb3JnLXVzZS1m YXN0LXRhZy1zZWxlY3Rpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVscSBu aWwgKG1hcGNhciAnY2RyIHRhYmxlKSkpKQorICAgICAgICAgICAgICAgICAgICAgIChvcmctZmFz dC10YWctc2VsZWN0aW9uCisgICAgICAgICAgICAgICAgICAgICAgIGN1cnJlbnQtdGFncyBpbmhl cml0ZWQtdGFncyB0YWJsZQorICAgICAgICAgICAgICAgICAgICAgICAoaWYgb3JnLWZhc3QtdGFn LXNlbGVjdGlvbi1pbmNsdWRlLXRvZG8gb3JnLXRvZG8ta2V5LWFsaXN0KSkKKyAgICAgICAgICAg ICAgICAgICAgKGxldCAoKG9yZy1hZGQtY29sb24tYWZ0ZXItdGFnLWNvbXBsZXRpb24gdCkpCisg ICAgICAgICAgICAgICAgICAgICAgKG9yZy10cmltCisgICAgICAgICAgICAgICAgICAgICAgIChv cmctd2l0aG91dC1wYXJ0aWFsLWNvbXBsZXRpb24KKyAgICAgICAgICAgICAgICAgICAgICAgIChv cmctaWNvbXBsZXRpbmctcmVhZCAiVGFnczogIiAnb3JnLXRhZ3MtY29tcGxldGlvbi1mdW5jdGlv bgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCBuaWwg Y3VycmVudCAnb3JnLXRhZ3MtaGlzdG9yeSkpKSkpKSkKKyAgICAgICAgICAod2hpbGUgKHN0cmlu Zy1tYXRjaCAiWy0rJl0rIiB0YWdzKQorICAgICAgICAgICAgOzsgTm8gYm9vbGVhbiBsb2dpYywg anVzdCBhIGxpc3QKKyAgICAgICAgICAgIChzZXRxIHRhZ3MgKHJlcGxhY2UtbWF0Y2ggIjoiIHQg dCB0YWdzKSkpKQorCisgICAgICAgIChpZiBvcmctdGFncy1zb3J0LWZ1bmN0aW9uCisgICAgICAg ICAgICAoc2V0cSB0YWdzIChtYXBjb25jYXQgJ2lkZW50aXR5CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHNvcnQgKG9yZy1zcGxpdC1zdHJpbmcgdGFncyAob3JnLXJlICJbXls6 YWxudW06XV9AXSsiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBv cmctdGFncy1zb3J0LWZ1bmN0aW9uKSAiOiIpKSkKKworICAgICAgICAoaWYgKHN0cmluZy1tYXRj aCAiXFxgW1x0IF0qXFwnIiB0YWdzKQorICAgICAgICAgICAgKHNldHEgdGFncyAiIikKKyAgICAg ICAgICAodW5sZXNzIChzdHJpbmctbWF0Y2ggIjokIiB0YWdzKSAoc2V0cSB0YWdzIChjb25jYXQg dGFncyAiOiIpKSkKKyAgICAgICAgICAodW5sZXNzIChzdHJpbmctbWF0Y2ggIl46IiB0YWdzKSAo c2V0cSB0YWdzIChjb25jYXQgIjoiIHRhZ3MpKSkpCisKKyAgICAgICAgOzsgSW5zZXJ0IG5ldyB0 YWdzIGF0IHRoZSBjb3JyZWN0IGNvbHVtbgorICAgICAgICAoYmVnaW5uaW5nLW9mLWxpbmUgMSkK KyAgICAgICAgKGNvbmQKKyAgICAgICAgICgoYW5kIChlcXVhbCBjdXJyZW50ICIiKSAoZXF1YWwg dGFncyAiIikpKQorICAgICAgICAgKChyZS1zZWFyY2gtZm9yd2FyZAorICAgICAgICAgICAoY29u Y2F0ICJcXChbIFx0XSoiIChyZWdleHAtcXVvdGUgY3VycmVudCkgIlxcKVsgXHRdKiQiKQorICAg ICAgICAgICAocG9pbnQtYXQtZW9sKSB0KQorICAgICAgICAgIChpZiAoZXF1YWwgdGFncyAiIikK KyAgICAgICAgICAgICAgKHNldHEgcnBsICIiKQorICAgICAgICAgICAgKGdvdG8tY2hhciAobWF0 Y2gtYmVnaW5uaW5nIDApKQorICAgICAgICAgICAgKHNldHEgYzAgKGN1cnJlbnQtY29sdW1uKSBw MCAoaWYgKGVxdWFsIChjaGFyLWJlZm9yZSkgPyopCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoMSsgKHBvaW50KSkgKHBvaW50KSkKKyAgICAgICAgICAgICAg ICAgIGMxIChtYXggKDErIGMwKSAoaWYgKD4gb3JnLXRhZ3MtY29sdW1uIDApCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9yZy10YWdzLWNvbHVtbgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKC0gKC0gb3JnLXRhZ3MtY29sdW1uKSAobGVuZ3RoIHRh Z3MpKSkpCisgICAgICAgICAgICAgICAgICBycGwgKGNvbmNhdCAobWFrZS1zdHJpbmcgKG1heCAw ICgtIGMxIGMwKSkgP1wgKSB0YWdzKSkpCisgICAgICAgICAgKHJlcGxhY2UtbWF0Y2ggcnBsIHQg dCkKKyAgICAgICAgICAoYW5kIChub3QgKGZlYXR1cmVwICd4ZW1hY3MpKSBjMCBpbmRlbnQtdGFi cy1tb2RlICh0YWJpZnkgcDAgKHBvaW50KSkpCisgICAgICAgICAgdGFncykKKyAgICAgICAgICh0 IChlcnJvciAiVGFncyBhbGlnbm1lbnQgZmFpbGVkIikpKQorICAgICAgICAob3JnLW1vdmUtdG8t Y29sdW1uIGNvbCkKKyAgICAgICAgKHVubGVzcyBqdXN0LWFsaWduCisgICAgICAgICAgKHJ1bi1o b29rcyAnb3JnLWFmdGVyLXRhZ3MtY2hhbmdlLWhvb2spKSkpKSkKIAogKGRlZnVuIG9yZy1jaGFu Z2UtdGFnLWluLXJlZ2lvbiAoYmVnIGVuZCB0YWcgb2ZmKQogICAiQWRkIG9yIHJlbW92ZSBUQUcg Zm9yIGVhY2ggZW50cnkgaW4gdGhlIHJlZ2lvbi4K --001636e0b92dadd7660483bd9d32 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --001636e0b92dadd7660483bd9d32--