From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Hoffman <gmane4-hoffman@sneakemail.com>
Subject: Re: Bug: org-agenda-do-date-earlier does not honor
 org-shiftleft-final-hook [9.1.14 (9.1.14-1-g4931fc-elpa @
 /home/mhoffman/.emacs.d/elpa/org-9.1.14/)]
Date: Tue, 4 Dec 2018 16:43:22 -0500
Message-ID: <pu6s9o$q97$1@blaine.gmane.org>
References: <pu4am4$hk0$1@blaine.gmane.org> <87d0qhk68j.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1gUITr-00027m-Q2
	for emacs-orgmode@gnu.org; Tue, 04 Dec 2018 16:43:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1gUITo-0005Qm-Ic
	for emacs-orgmode@gnu.org; Tue, 04 Dec 2018 16:43:47 -0500
Received: from [195.159.176.226] (port=46053 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>)
	id 1gUITo-0005Mv-AH
	for emacs-orgmode@gnu.org; Tue, 04 Dec 2018 16:43:44 -0500
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1gUIRT-000793-Bg
	for emacs-orgmode@gnu.org; Tue, 04 Dec 2018 22:41:19 +0100
In-Reply-To: <87d0qhk68j.fsf@nicolasgoaziou.fr>
Content-Language: en-US
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

On 2018-12-04 4:10 a.m., Nicolas Goaziou wrote:
> Michael Hoffman <gmane4-hoffman@sneakemail.com> writes:
>> 1. What exactly did you do?
>>
>> - Execute:
>> (with-eval-after-load 'org
>>    (add-hook 'org-shiftleft-final-hook 'windmove-left))
>> (org-agenda nil "a")
>> (split-window-horizontally)
>>
>> - Type S-left
>>
>> 2. What did you expect to happen?
>>
>> (windmove-left)
>>
>> 3. What happened instead?
>>
>> Received message "Command not allowed in this line"
> 
> That means one of the commands called by `org-shiftleft' failed.

Thanks for your response.

It does not appear that `org-shiftleft' is called at all in agenda buffers now. The `org-agenda-do-date-earlier'. C-h k S-left gives me:

```
<S-left> runs the command org-agenda-do-date-earlier (found in
org-agenda-mode-map), which is an interactive compiled Lisp function
in ‘org-agenda.el’.

It is bound to <S-left>, C-c C-x <left>, <menu-bar> <Agenda>
<Deadline/Schedule> <Change Time -1 hour>.

(org-agenda-do-date-earlier ARG)

Not documented.
```

`org-agenda.el' has `(org-defkey org-agenda-mode-map [(shift left)] 'org-agenda-do-date-earlier)` rather than a call to `org-shiftleft'.

I agree that the expected behavior would be for `org-shiftleft' to be called here and to call `org-agenda-do-date-earlier' when not overridden.

Michael