Bug: org-capture inserts empty line before title

Bug: org-capture inserts empty line before title

[Luke]

I recently ran a "git pull" (after not updating for a while) and noticed 
an apparent change (bug?) when running org-capture.

org-capture seems to be inserting an extra line before the task heading. 
So the narrowed buffer for editing the task looks something like this:

-------------------- Top of window ---------------

** TODO My new task
    [2018-03-02 Fri]
    [[file:~/.notes]]
-------------------- End of buffer ---------------

I would expect the task heading to be the first line in the buffer. 
After pressing 'C-c C-c' the resulting file looks like this:

--------------------------------------------------
* Tasks

** TODO My new task
    [2018-03-02 Fri]
    [[file:~/.notes]]
--------------------------------------------------

Is this a bug? If not, how do I stop the blank line from being inserted 
before the heading. As far as I can tell, this is not related to 
org-blank-before-new-entry.



Emacs  : GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
  of 2017-09-21 on lcy01-07, modified by Debian
Package: Org mode version 9.1.7 (release_9.1.7-466-ga16590 @ 
/home/luke/elisp/org-mode/lisp/)

current state:
==============
(setq
  org-tab-first-hook '(org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
  org-speed-command-hook '(org-speed-command-activate
			  org-babel-speed-command-activate)
  org-occur-hook '(org-first-headline-recenter)
  org-metaup-hook '(org-babel-load-in-session-maybe)
  org-confirm-shell-link-function 'yes-or-no-p
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-babel-pre-tangle-hook '(save-buffer)
  org-mode-hook '(#[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-show-all append local]
		   5 "\n\n(fn)"]
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-babel-show-result-all
		    append local]
		   5 "\n\n(fn)"]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
  org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 
"\n\n(fn ENTRY)"]
  org-archive-hook '(org-attach-archive-delete-maybe)
  org-cycle-hook '(org-cycle-hide-archived-subtrees 
org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
  org-blank-before-new-entry '((heading) (plain-list-item . auto))
  org-confirm-elisp-link-function 'yes-or-no-p
  org-metadown-hook '(org-babel-pop-to-session-maybe)
  org-link-parameters '(("id" :follow org-id-open)
		       ("rmail" :follow org-rmail-open :store
			org-rmail-store-link)
		       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store org-irc-store-link
			:export org-irc-export)
		       ("info" :follow org-info-open :export org-info-export
			:store org-info-store-link)
		       ("gnus" :follow org-gnus-open :store
			org-gnus-store-link)
		       ("docview" :follow org-docview-open :export
			org-docview-export :store org-docview-store-link)
		       ("bibtex" :follow org-bibtex-open :store
			org-bibtex-store-link)
		       ("bbdb" :follow org-bbdb-open :export org-bbdb-export
			:complete org-bbdb-complete-link :store
			org-bbdb-store-link)
		       ("w3m" :store org-w3m-store-link) ("file+sys")
		       ("file+emacs") ("doi" :follow org--open-doi-link)
		       ("elisp" :follow org--open-elisp-link)
		       ("file" :complete org-file-complete-link)
		       ("ftp" :follow
			(lambda (path) (browse-url (concat "ftp:" path))))
		       ("help" :follow org--open-help-link)
		       ("http" :follow
			(lambda (path) (browse-url (concat "http:" path))))
		       ("https" :follow
			(lambda (path) (browse-url (concat "https:" path))))
		       ("mailto" :follow
			(lambda (path) (browse-url (concat "mailto:" path))))
		       ("news" :follow
			(lambda (path) (browse-url (concat "news:" path))))
		       ("shell" :follow org--open-shell-link))
  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
  )

Re: Bug: org-capture inserts empty line before title

[Nicolas Goaziou]

Hello,

Luke <mideniko1234-org@yahoo.co.uk> writes:

> org-capture seems to be inserting an extra line before the task
> heading. So the narrowed buffer for editing the task looks something
> like this:
>
> -------------------- Top of window ---------------
>
> ** TODO My new task
>    [2018-03-02 Fri]
>    [[file:~/.notes]]
> -------------------- End of buffer ---------------
>
> I would expect the task heading to be the first line in the buffer.
> After pressing 'C-c C-c' the resulting file looks like this:
>
> --------------------------------------------------
> * Tasks
>
> ** TODO My new task
>    [2018-03-02 Fri]
>    [[file:~/.notes]]
> --------------------------------------------------
>
> Is this a bug? If not, how do I stop the blank line from being
> inserted before the heading. As far as I can tell, this is not related
> to org-blank-before-new-entry.

Could you show the capture template you used? I do not notice anything
like that with my templates.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-capture inserts empty line before title

[Luke]

[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]

Hi,


On 04/03/18 06:40, Nicolas Goaziou wrote:
> Hello,
>
> Luke <mideniko1234-org@yahoo.co.uk> writes:
>
>> org-capture seems to be inserting an extra line before the task
>> heading. So the narrowed buffer for editing the task looks something
>> like this:
>>
>> -------------------- Top of window ---------------
>>
>> ** TODO My new task
>>     [2018-03-02 Fri]
>>     [[file:~/.notes]]
>> -------------------- End of buffer ---------------
>>
>> I would expect the task heading to be the first line in the buffer.
>> After pressing 'C-c C-c' the resulting file looks like this:
>>
>> --------------------------------------------------
>> * Tasks
>>
>> ** TODO My new task
>>     [2018-03-02 Fri]
>>     [[file:~/.notes]]
>> --------------------------------------------------
>>
>> Is this a bug? If not, how do I stop the blank line from being
>> inserted before the heading. As far as I can tell, this is not related
>> to org-blank-before-new-entry.
> Could you show the capture template you used? I do not notice anything
> like that with my templates.
>
> Regards,
>
I've set up a minimal-org.el file with the following contents:

     ;; Minimal setup to load latest 'org-mode'

     ;; activate debugging
     (setq debug-on-error t
           debug-on-signal nil
           debug-on-quit t)

     ;; add latest org-mode to load path
     (add-to-list 'load-path (expand-file-name "~/elisp/org-mode/lisp"))
     (add-to-list 'load-path (expand-file-name 
"~/elisp/org-mode/contrib/lisp" t))

Then I've run emacs with `emacs -Q -l minimal-org.el`. So I'm just 
running the with org-mode default capture template, which (taken from 
org-capture.el) would be:

     ("t" "Task" entry (file+headline "" "Tasks")
      "* TODO %?\n  %u\n  %a")


[-- Attachment #2: Type: text/html, Size: 2530 bytes --]

Re: Bug: org-capture inserts empty line before title

[Luke]

On 04/03/18 08:13, Luke wrote:
> Hi,
> 
> 
> On 04/03/18 06:40, Nicolas Goaziou wrote:
>> Hello,
>>
>> Luke<mideniko1234-org@yahoo.co.uk>  writes:
>>
>>> org-capture seems to be inserting an extra line before the task
>>> heading. So the narrowed buffer for editing the task looks something
>>> like this:
>>>
>>> -------------------- Top of window ---------------
>>>
>>> ** TODO My new task
>>>     [2018-03-02 Fri]
>>>     [[file:~/.notes]]
>>> -------------------- End of buffer ---------------
>>>
>>> I would expect the task heading to be the first line in the buffer.
>>> After pressing 'C-c C-c' the resulting file looks like this:
>>>
>>> --------------------------------------------------
>>> * Tasks
>>>
>>> ** TODO My new task
>>>     [2018-03-02 Fri]
>>>     [[file:~/.notes]]
>>> --------------------------------------------------
>>>
>>> Is this a bug? If not, how do I stop the blank line from being
>>> inserted before the heading. As far as I can tell, this is not related
>>> to org-blank-before-new-entry.
>> Could you show the capture template you used? I do not notice anything
>> like that with my templates.
>>
>> Regards,
>>
> I've set up a minimal-org.el file with the following contents:
> 
>      ;; Minimal setup to load latest 'org-mode'
> 
>      ;; activate debugging
>      (setq debug-on-error t
>            debug-on-signal nil
>            debug-on-quit t)
> 
>      ;; add latest org-mode to load path
>      (add-to-list 'load-path (expand-file-name "~/elisp/org-mode/lisp"))
>      (add-to-list 'load-path (expand-file-name 
> "~/elisp/org-mode/contrib/lisp" t))
> 
> Then I've run emacs with `emacs -Q -l minimal-org.el`. So I'm just 
> running the with org-mode default capture template, which (taken from 
> org-capture.el) would be:
> 
>      ("t" "Task" entry (file+headline "" "Tasks")
>       "* TODO %?\n  %u\n  %a")
> 

As a follow up, after running `git bisect` I've tracked down that the 
behavior that I describe starts to appear in commit 8ebf4b7274 ("Change 
`org-paste-subtree' behavior").

It doesn't seem to manifest in the commits previous to that. I'm not 
sure why though.

Regards,
-- 
Luke

Re: Bug: org-capture inserts empty line before title

[Nicolas Goaziou]

Hello,

Luke <mideniko1234-org@yahoo.co.uk> writes:

> I've set up a minimal-org.el file with the following contents:
>
>     ;; Minimal setup to load latest 'org-mode'
>
>     ;; activate debugging
>     (setq debug-on-error t
>           debug-on-signal nil
>           debug-on-quit t)
>
>     ;; add latest org-mode to load path
>     (add-to-list 'load-path (expand-file-name "~/elisp/org-mode/lisp"))
>     (add-to-list 'load-path (expand-file-name
> "~/elisp/org-mode/contrib/lisp" t))
>
> Then I've run emacs with `emacs -Q -l minimal-org.el`. So I'm just
> running the with org-mode default capture template, which (taken from
> org-capture.el) would be:
>
>     ("t" "Task" entry (file+headline "" "Tasks")
>      "* TODO %?\n  %u\n  %a")

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou