From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Baumann Subject: Re: Bug fix: org-mhe links don't work with mairix Date: Sat, 17 May 2008 17:15:41 +0200 Message-ID: References: <21579.1210822289@gamaville.dokosmarshall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JxO8o-0005wI-0C for emacs-orgmode@gnu.org; Sat, 17 May 2008 11:16:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JxO8m-0005vi-Sh for emacs-orgmode@gnu.org; Sat, 17 May 2008 11:16:09 -0400 Received: from [199.232.76.173] (port=46214 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxO8m-0005vf-O1 for emacs-orgmode@gnu.org; Sat, 17 May 2008 11:16:08 -0400 Received: from main.gmane.org ([80.91.229.2]:34267 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JxO8l-0005Q6-Tq for emacs-orgmode@gnu.org; Sat, 17 May 2008 11:16:08 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JxO8g-0005GQ-77 for emacs-orgmode@gnu.org; Sat, 17 May 2008 15:16:02 +0000 Received: from p54960e78.dip0.t-ipconnect.de ([84.150.14.120]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 17 May 2008 15:16:02 +0000 Received: from dtbaumann by p54960e78.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 17 May 2008 15:16:02 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: mh-e-users@lists.sourceforge.net Hi Nick, your patch actually breaks namazu, swish and grep searches. A look at mh-search-choices (mh-search.el) reveals that for namazu, swish and grep mh-search-regexp-builder is nil and therefore (funcall mh-search-regexp-builder ... raises an error. One might be tempted to solve this on the mh-e side but there's no reason to add a mh-search-regexp-builder for those search engines. There's a patch against todays git below. BTW. Namazu and pick searches work fine without angular brackets, however, it doesn't harm to have them. Greetings Thomas --- /data/cvs/org-mode/lisp/org-mhe.el 2008-05-17 12:54:07.000000000 +0200 +++ org-mhe.el 2008-05-17 16:55:22.000000000 +0200 @@ -204,8 +204,10 @@ (not (org-mhe-get-message-real-folder))) (kill-this-buffer) (mh-search "+" (list "--message-id" article)))) - (mh-search "+" (funcall mh-search-regexp-builder - (list (cons 'message-id article))))) + (if mh-search-regexp-builder + (mh-search "+" (funcall mh-search-regexp-builder + (list (cons 'message-id article)))) + (mh-search "+" article))) (if (org-mhe-get-message-real-folder) (mh-show-msg 1) (kill-this-buffer) Nick Dokos writes: > Pete Phillips had run into a problem back in November 2007 with mhe > links to emails not working (he was using mairix as the mh search > method). I just sent a patch to Bill Wohler about the mh-e part (and > copied both the mh-e list and the org list: the problem is described in > more detail there). Here is the org-mode patch. > > I've tested the patch both with the default "pick" search in mh-e and > with "mairix" search. Pete Phillips also did some testing (I believe > with mairix) - thanks Pete! > > I would feel better if there had been some swish++/namazu/etc testing as > well, but it's unlikely that I'll find the time in the foreseeable > future. In particular, I'm not sure where the angle brackets are needed: > it's clear they are needed for the pick search and I've found out that > they are *not* needed for mairix search, but if swish++ needs them, that > would complicate things. The patch assumes that they are not needed for > any search method, other than pick. If somebody on the list could try it > and report success/failure, I, for one, would appreciate it very much. > > If it looks OK to you, could you please apply it? > > Thanks very much, > Nick > > --- a/lisp/org-mhe.el > +++ b/lisp/org-mhe.el > @@ -194,16 +194,16 @@ folders." > (mh-find-path) > (if (not article) > (mh-visit-folder (mh-normalize-folder-name folder)) > - (setq article (org-add-angle-brackets article)) > (mh-search-choose) > (if (equal mh-searcher 'pick) > (progn > + (setq article (org-add-angle-brackets article)) > (mh-search folder (list "--message-id" article)) > (when (and org-mhe-search-all-folders > (not (org-mhe-get-message-real-folder))) > (kill-this-buffer) > (mh-search "+" (list "--message-id" article)))) > - (mh-search "+" article)) > + (mh-search "+" (funcall mh-search-regexp-builder (list (cons 'message-id article))))) > (if (org-mhe-get-message-real-folder) > (mh-show-msg 1) > (kill-this-buffer) > > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode