From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GA9ZAn7nZmP+zAAAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 23:45:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4JY2An7nZmMtoAAAauVa8A (envelope-from ) for ; Sat, 05 Nov 2022 23:45:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C45EA39724 for ; Sat, 5 Nov 2022 23:45:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orRti-0005Wt-8I; Sat, 05 Nov 2022 18:44:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orRth-0005Wa-5F for emacs-orgmode@gnu.org; Sat, 05 Nov 2022 18:44:17 -0400 Received: from mr85p00im-zteg06021601.me.com ([17.58.23.187]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orRtf-0001Vt-Kt for emacs-orgmode@gnu.org; Sat, 05 Nov 2022 18:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1667688254; bh=Uc6EXphEJrr2rRV3Rb3ETTHjA3f+0tmoBu9LIi6vgTc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=MLiG9sesIpHNN6bIQVH3q3yEHeHd9TPnzE0X2L518OPY/fkSAuZMaqsc49l+9Wt9D 3TKE6eVmQufuVDVU0IxGMKRylhQ1sRLSFCWmLyUTq3neZSIZJOWrv52rsFRSVcD7Aw sJUDjuwo+nr9CBGItGtj/ZvvARSh8FM60I+QHagF4HOOnTY0reb2sN5aebMRbwymkp UqTQ/RTD3z+BI4F5XIZ6HK9fCH7XHgac00KOesIukZm8KMwIOuXq1zVrIcMeSeJRSq dNKzk6CpiHh4lyDXEX8eMlzP9PlEOIjFVfiy3bw5u/b3nAAlK8feEgrz/4AJS8HP6b NhrI1uzgDhmpw== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-zteg06021601.me.com (Postfix) with ESMTPSA id 16CC640778; Sat, 5 Nov 2022 22:44:12 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: Ihor Radchenko , emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: Update Org to MathJax 3 In-Reply-To: References: <87h70ekci6.fsf@localhost> <87sfixk3u3.fsf@localhost> Date: Sat, 05 Nov 2022 23:44:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: m4JdhlY1OElPSbpHqAj6q25QgJmBKUek X-Proofpoint-ORIG-GUID: m4JdhlY1OElPSbpHqAj6q25QgJmBKUek X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.572,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2020-02-14=5F11:2020-02-14=5F02,2020-02-14=5F11,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 mlxscore=0 mlxlogscore=542 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2211050173 Received-SPF: pass client-ip=17.58.23.187; envelope-from=salutis@me.com; helo=mr85p00im-zteg06021601.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667688317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Uc6EXphEJrr2rRV3Rb3ETTHjA3f+0tmoBu9LIi6vgTc=; b=GEoHEdCMBaNy+cj+eNRFvxNpufsS7iN3sdkyEtxapdyL0JHfBPrXDUdL+3j5DlQXNzA23t 3d7G/MNJtP0KBmvx2R9S7k2+X2dELcUTYS81KobFHOB0CXaUzHAAB4jby5eIKGoiBKQEs0 jPCQe+xg/YUEmx03cnibMrwxuV5ZMY48x9HibziQvmFuCYx3RNwkdUAEj5F7EPe166+smc EK8KuaodH5O9eYP4bWD9aH5nuiVdJBy2C10yUEwHCC/MmKEavw6klP+mYJEFMYIdwWh9qu VMMx/vH1BNBkb9bTE9Vr8LHZJZf+CiAe8ctmqs5z3L+T4bvD8Qgnimjvo6BjAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667688317; a=rsa-sha256; cv=none; b=ig1EyimiFIkpMGkF6Y0WP2KlDTMlXg4n8SPpa/F+lN9nDjoaWoz5CNyHLpf0NKaoN9GKeP 0Hl3CutJ37NJ4pqTckVPBuU5n3L1E3trGcNZ3I5OraXBTgNYh+ZoRj5gwbqzY6wGqwkfay HVsB4ErB1ChjpZHyBEo24DS38O6ex2hoMKMNeQjDFx9L76t1sElL+WaDsQaelD9FOu8TPz q7zZCR0asEc2ENOw4j4FXHWOCqCZ22HFuFNODQ2nfcq8aY9iX7sR6VKzVe/jgUit2dsP3l MAI8rv3r3gtogRGtaRJxwOP4B9HYtYqaQb/n3MQisLmnGJUhsjT7lJSmqZf7mw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=MLiG9ses; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=MLiG9ses; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C45EA39724 X-Spam-Score: -2.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: b71QQf1PoBKL Rudolf Adamkovi=C4=8D writes: > Good points; I will fix everything. Please see the attached (3rd) revision of the patch. However, the tests still fail when ran via `make test'. See below. > Ihor Radchenko writes: > >> Your tests are failing on my side... > > The tests *pass* when ran in-buffer but *fail* when ran via 'make > test'. Just the tests that call (current-message) have this problem. > Interesting. I cannot figure out why these tests pass when ran from inside of Emacs but fail when ran via 'make tests'. I found in `default.mk' that Make runs `ert-run-tests-batch', but even that *passes* from within Emacs: 1. load `testing/org-test.el', 2. evaluate `ox-html/mathjax-legacy-scale-message-in-buffer` test in `testing/lisp/test-ox-html.el', and 3. run `M-: ert-run-tests-batch'. It produces the following output in the `*Messages*' buffer: Running 1 tests (2022-11-05 23:17:56+0100, selector =E2=80=98t=E2=80=99) Converting legacy MathJax scale: 20 to 0.2 passed 1/1 ox-html/mathjax-legacy-scale-message-in-buffer (0.008186 = sec) =20=20 Ran 1 tests, 1 results as expected, 0 unexpected (2022-11-05 23:17:56+010= 0, 0.010790 sec) It seems that some part of the *batch* testing swallows the messages in a way that makes `(current-message)' work incorrectly in tests. Any ideas? Asking for an Emacs veteran. :) P.S. As a workaround I also tried to set `set-message-function', dependency-injection style, but it did not work either. Rudy --=20 "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if it were so, it would be; but as it isn't, it ain't. That's logic.'" -- Lewis Carroll, Through the Looking Glass, 1871/1872 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia