From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2OM1HYmYUmPafQAAbAwnHQ (envelope-from ) for ; Fri, 21 Oct 2022 15:03:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yBU8HYmYUmNACAAA9RJhRA (envelope-from ) for ; Fri, 21 Oct 2022 15:03:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38CF68AC7 for ; Fri, 21 Oct 2022 15:03:05 +0200 (CEST) Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olrg0-0001Q3-A9 for larch@yhetil.org; Fri, 21 Oct 2022 09:03:04 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olrfN-0000t3-0l for larch@yhetil.org; Fri, 21 Oct 2022 09:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olrfG-0000qD-JK for emacs-orgmode@gnu.org; Fri, 21 Oct 2022 09:02:19 -0400 Received: from mr85p00im-hyfv06021301.me.com ([17.58.23.188]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olrfE-0007MD-DK for emacs-orgmode@gnu.org; Fri, 21 Oct 2022 09:02:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1666357334; bh=9frE98UsxUKaPFLytUYrmrfow7Cksr7zdTOgD61VxRg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=V5Bo9EpdqfZp+Uc5iALTivqS0IS1yXf0pDKkyKk1LHZ/yyjPzJuih1bIgpHvBnWsv 9C9CK2fn+l41wIJYpknzAiUV/esam3mVo6UOeGcYpIROPg4l5NS/X883I1EqCF0eMY qyPj33flZmIUbspUCLoApkC7uZhwA3T3Mvd1dMi6pz0MOYbJPMwp/NxaDLSYhq/h59 saDpP0/07/RG15CgTySxcKW5BEFvKCM69zU+aLbqy4Sxbbs2OoKZc70x9UDrmcS1Px VZ5mB3UiiuNvrAg6GeyxDO2r6U+4bLUigAAwd6fXYdZ3WKjk0qnYp/byELgeBjchNZ ZTLILBKHtLI4Q== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-hyfv06021301.me.com (Postfix) with ESMTPSA id EB86A215178F; Fri, 21 Oct 2022 13:02:13 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-java: Define the list of all supported header arguments In-Reply-To: References: <871qr17rjy.fsf@localhost> Date: Fri, 21 Oct 2022 15:02:11 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-ORIG-GUID: ZqUqkXpzQAtnr6KlYF6sC0JXeoWsEnxT X-Proofpoint-GUID: ZqUqkXpzQAtnr6KlYF6sC0JXeoWsEnxT X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-14=5F01:2022-01-14=5F01,2020-02-14=5F11,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 clxscore=1015 bulkscore=0 adultscore=0 mlxlogscore=861 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210210077 Received-SPF: pass client-ip=17.58.23.188; envelope-from=salutis@me.com; helo=mr85p00im-hyfv06021301.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666357385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9frE98UsxUKaPFLytUYrmrfow7Cksr7zdTOgD61VxRg=; b=ii+yW9bp2pPH4vkRONgkZQTWWCjawtjt2OSFWqhsgChxKEbDiRlmruc8I2+13Pg3dy/FbM zfR/kW5cx05MMl6WxAlzgvAGC81jNcT/dSuQJ1Jyi4tRzYqZqM5LlfNG6uHil6mzXqaJMr ZcESh6+LVFZC+f3cbt7uZoNqEwPEMvMrefYjtH+wFWkbxb6Q0Ir4FbaYErcG4XsEzpkDqq iltdb378yvGPoswWYGgHO+FTVecRmf8ezpndh4n+Gl9GphnBSVvIqsm4219nfA2hdW9gQZ hXqhdT4L7tSrqsKkMtu7PCPLPT7Ueo/ge+F5RZO9YJ/gZS9IP66dSDfqOfG6NA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666357385; a=rsa-sha256; cv=none; b=JUvPdfFXGbTV68YqV0MpG5tiLbpMYIm6Gzx757RQ+ec7gIDsIrNLgMlTvwOCmwvdGGxe/m CLa48M4D2sP6/bEzkLT+1vh4lnJESKiH4Ckf0w/WUVg414bT+w4VE+7Mw9ncpJz6TWQRuJ SmHl6kRDowELkJeeYzYeQjpzdk1fR0l8WP2XNNXpdU7XN+asF0w8HJfQYdRJq5qmrKKdzD HoY105JGQMv0Z1gOtU6cAIcaNeyMQlHxZS2qPjceIx6Osy3W6PheIrS7blbOwGKmWMJSaZ gmDdWdZtcUCwoVcsKI4uD84SmlD/H21NJXQkKfmE0C407eI+ERg4hTwr7d/WrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=V5Bo9Epd; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=V5Bo9Epd; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 38CF68AC7 X-Spam-Score: -2.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: iZE7BjyV3JvR --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rudolf Adamkovi=C4=8D writes: > Please see the attached patch with updated tests. Oops, I had a typo (a wrong tense) in the commit message. Please see the patch attached to this message that has it fixed. Rudy --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-test-ob-java-Test-Java-source-block-header-arguments.patch Content-Transfer-Encoding: quoted-printable >From 37bd1716a652751e6941781464d47c283be3b4b9 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Rudolf=3D20Adamkovi=3DC4=3D8D?=3D Date: Fri, 21 Oct 2022 14:48:56 +0200 Subject: [PATCH] test-ob-java: Test Java source block header arguments at a= ll levels MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * testing/lisp/test-ob-java.el (ob-java/lint-header-arguments): Rename to ob-java/lint-header-args-block. * testing/lisp/test-ob-java.el (ob-java/lint-header-args-heading): Test source block header arguments at the heading level. * testing/lisp/test-ob-java.el (ob-java/lint-header-args-buffer): Test source block header arguments at the buffer level. Reported-by: Rudolf Adamkovi=C4=8D Link: https://orgmode.org/list/m2y1ta9rqe.fsf@me.com --- testing/lisp/test-ob-java.el | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/testing/lisp/test-ob-java.el b/testing/lisp/test-ob-java.el index a62d66557..1cc7fbeb2 100644 --- a/testing/lisp/test-ob-java.el +++ b/testing/lisp/test-ob-java.el @@ -27,7 +27,36 @@ =20 ;;; No Java required =20 -(ert-deftest ob-java/lint-header-arguments () +(ert-deftest ob-java/lint-header-args-buffer () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the buffer level. + (org-test-with-temp-text " +#+property: header-args:java+ :dir /tmp +#+property: header-args:java+ :classname com.example.Example +#+property: header-args:java+ :imports com.example.OtherExample +#+property: header-args:java+ :cmpflag -classpath .:/tmp/example/ +#+property: header-args:java+ :cmdline -classpath .:/tmp/example/ +#+property: header-args:java+ :cmdarg -verbose" + (should-not (org-lint '(wrong-header-argument))))) + +(ert-deftest ob-java/lint-header-args-heading () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the heading level. + (org-test-with-temp-text " +* Test +:PROPERTIES: +:header-args:java+: :dir /tmp +:header-args:java+: :classname com.example.Example +:header-args:java+: :imports com.example.OtherExample +:header-args:java+: :cmpflag -classpath .:/tmp/example/ +:header-args:java+: :cmdline -classpath .:/tmp/example/ +:header-args:java+: :cmdarg -verbose +:END:" + (should-not (org-lint '(wrong-header-argument))))) + +(ert-deftest ob-java/lint-header-args-block () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the block level. (org-test-with-temp-text " #+header: :dir /tmp #+header: :classname com.example.Example --=20 2.38.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Genius is 1% inspiration and 99% perspiration." -- Thomas Alva Edison, 1932 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=--