From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Schmitt Subject: Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4] Date: Tue, 21 May 2013 13:32:25 +0200 Message-ID: References: <87wqqusder.fsf@pank.eu> <87ehd2sc6t.fsf@pank.eu> <87wqqsd7p8.fsf@pank.eu> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueknn-0005aa-Ml for emacs-orgmode@gnu.org; Tue, 21 May 2013 07:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ueknm-0000nJ-98 for emacs-orgmode@gnu.org; Tue, 21 May 2013 07:32:23 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:1152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueknm-0000mv-3z for emacs-orgmode@gnu.org; Tue, 21 May 2013 07:32:22 -0400 In-reply-to: <87wqqsd7p8.fsf@pank.eu> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > Alan Schmitt writes: > >>> It seems there are some semantic bugs in ox-koma-letter.el in that new >>> variables are introduces for SENDER (as opposed to AUTHOR) and a >>> separate email variable as well. This seems like a semantic bug IMO. >>> This patch fixes these issues if they in fact are issues. >> >> Can we still use an lco file to set these after this change? > > (I'll also post this on the list). > > You can't set > > #+SENDER: > > Which seems to be how it was set up before. You can use > > #+AUTHOR > > So if you decide to convert your document from something you'd export > with the normal LaTeX exporter it would be smoother this way. Author > now works the same way that it does in the LaTeX exporter (come to > think of it, we probably shouldn't need to mention anything as it > build on top of the LaTeX exporter anyway). > > Thus, unless you disable export of author it wouldn't work with a LCO > file. But then we could make export of author conditional on > :with-author as in ox-latex.el and you could use LCO files. > > The gain is that in the (for me) 99.9% of the cases where I want to > send a letter in my own name the exporter just figures it out without > be having to specify anything (like in the normal exporter). OK, sounds good, I've applied it. Thanks, Alan