From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Schmitt Subject: Re: evaluation issue with ocaml code (due to changes to org-babel-comint-with-output) Date: Fri, 18 Dec 2015 09:18:56 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9qFh-00064S-Oa for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 03:19:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9qFd-0005wd-M4 for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 03:19:01 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:35573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9qFd-0005w9-Gj for emacs-orgmode@gnu.org; Fri, 18 Dec 2015 03:18:57 -0500 In-Reply-To: (Alan Schmitt's message of "Wed, 16 Dec 2015 21:29:05 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Can I push this? Thanks, Alan On 2015-12-16 21:29, Alan Schmitt writes: > Hello, > > I finally found the issue (using the plain debugger): the call to > org-babel-comint-with-output was set to remove the echo, but the only > time there is an echo of the full body is when a single line function > has an error, and this echo is useful to show where the error is. Here > is a patch that makes sure the echo is kept. > > From 59e6912e6bf769fff2f48b6c2af95bda918d0cd9 Mon Sep 17 00:00:00 2001 > From: Alan Schmitt > Date: Wed, 16 Dec 2015 21:19:23 +0100 > Subject: [PATCH] ob-ocaml.el: Keep echo to display ocaml errors > > * ob-ocaml.el (org-babel-execute:ocaml): call > `org-babel-comint-with-output' with nil `remove-echo' argument. > --- > lisp/ob-ocaml.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/ob-ocaml.el b/lisp/ob-ocaml.el > index 48f8aba..68ac859 100644 > --- a/lisp/ob-ocaml.el > +++ b/lisp/ob-ocaml.el > @@ -66,7 +66,7 @@ > (session (org-babel-prep-session:ocaml > (cdr (assoc :session params)) params)) > (raw (org-babel-comint-with-output > - (session org-babel-ocaml-eoe-output t full-body) > + (session org-babel-ocaml-eoe-output nil full-body) > (insert > (concat > (org-babel-chomp full-body) ";;\n" > --=20 > 2.6.4 > > > For the record, the problem I wanted to fix. > > On 2015-12-14 13:04, Alan Schmitt writes: > >>> I have found that commit f0bf77e82a3d37ba7548aa40198bc982e9875f1b breaks >>> evaluation of ocaml code. With the following init file (the >>> `package-initialize' is there for tuareg to be available): >>> >>> #+begin_src emacs-lisp >>> (add-to-list 'load-path "/Users/schmitta/projets/org-mode/lisp") >>> >>> (require 'org) >>> >>> (package-initialize) >>> >>> (org-babel-do-load-languages >>> 'org-babel-load-languages >>> '((ocaml . t))) >>> #+end_src >>> >>> When I evaluate this block I get this result: >>> >>> #+BEGIN_SRC ocaml :results code verbatim :exports results >>> 1 + "toto";; >>> #+END_SRC >>> >>> #+results: >>> #+BEGIN_SRC ocaml >>> Characters 4-10: >>> 1 + "toto";;;; >>> ^^^^^^ >>> Error: This expression has type string but an expression was expected o= f type >>> int >>> #+END_SRC >>> >>> After commit f0bf77e82a3d37ba7548aa40198bc982e9875f1b I get this: >>> >>> #+results: >>> #+BEGIN_SRC ocaml >>> ;; >>> ^^^^^^ >>> Error: This expression has type string but an expression was expected o= f type >>> int >>> #+END_SRC > > Best, > > Alan =2D-=20 OpenPGP Key ID : 040D0A3B4ED2E5C7 Athmospheric CO=E2=82=82 (Updated December 13, 2015, Mauna Loa Obs.): 401.3= 1 ppm --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCgAGBQJWc8FwAAoJEAQNCjtO0uXHIhEH/A7x/MHOrQrH0/ciwgIgQmfC qGw+qy5jsjFcWMdb1CprFBz8ljaOtyN4cm1HkBJMlDidQFiEMw9njYx+xtEWbHFx fd7+c8aFVOuZEPBDWfW95ZM1QqIU9h3WY/BsvFuxhKIwf0lQX6JKqwnhatmnl0FJ ljyYEo5hKqrp++ow21fcbxqNO0JqXDh4AiE3+uETVWFtsf0gsLamcz2tZEsXgWt+ GPd1IleeL1Fpbt1wEC1PXQ6NQO5bGiaxMFL7O6MXqAZh/ypYVbPPtJ5h2mKf0eZi PokSQkfLiQJ3vIsoCyb54wAO22g/Qq92XjT9nmagLQ6iZ69dSW5Qv8vxrzBeQW0= =L7O3 -----END PGP SIGNATURE----- --=-=-=--