emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Rudolf Adamkovič" <salutis@me.com>
To: emacs-orgmode@gnu.org
Subject: Fix the confusing "result silenced" message
Date: Thu, 24 Nov 2022 22:20:30 +0100	[thread overview]
Message-ID: <m2sfi8vyld.fsf@me.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hello smart folks!

With Org Babel, the user can make the results silent, or *silence* them,
with the `:results silent' header argument.  However, Org says "result
silenced" after executing source blocks with the `:results none' header
argument.  Every time I see that message, I have a "Wait, what?" moment.
The patch attached below fixes this incredibly confusing message.

Rudy


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ob-core-Fix-the-confusing-result-silenced-message.patch --]
[-- Type: text/x-patch, Size: 1048 bytes --]

From 6ffc06e9da723cf04e2c7471e35a46294742be3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <salutis@me.com>
Date: Thu, 24 Nov 2022 22:10:29 +0100
Subject: [PATCH] ob-core: Fix the confusing "result silenced" message

* lisp/ob-core.el (org-babel-execute-src-block): Say "discarded"
instead of "silenced" after executing source blocks with `:results
none' to avoid confusion with `:results silent'.  Also, capitalize
correctly.
---
 lisp/ob-core.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 1259909a0..fb472a00a 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -850,7 +850,7 @@ guess will be made."
 		    (when file
 		      (setq result-params (remove "file" result-params))))))
 	      (if (member "none" result-params)
-		  (message "result silenced")
+		  (message "Result discarded")
 	        (org-babel-insert-result
 	         result result-params info new-hash lang
                  (time-subtract (current-time) exec-start-time))))
-- 
2.38.1


[-- Attachment #3: Type: text/plain, Size: 300 bytes --]

-- 
"Mathematics takes us still further from what is human into the region
of absolute necessity, to which not only the actual world, but every
possible world, must conform."
-- Bertrand Russell, 1902

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

             reply	other threads:[~2022-11-24 21:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 21:20 Rudolf Adamkovič [this message]
2022-11-25  2:10 ` Fix the confusing "result silenced" message Ihor Radchenko
2022-11-25 23:01   ` Rudolf Adamkovič
2022-11-26  2:16     ` Ihor Radchenko
2022-11-30  0:31       ` Rudolf Adamkovič
2022-11-30  0:36         ` Rudolf Adamkovič
2022-12-05 11:27           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sfi8vyld.fsf@me.com \
    --to=salutis@me.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).