From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Kitchin <jkitchin@andrew.cmu.edu>
Subject: Re: [PATCH] Re: links-9.0 v3
Date: Sun, 07 Aug 2016 20:12:21 -0400
Message-ID: <m2r3a0xgnu.fsf@andrew.cmu.edu>
References: <m2lh1eesm8.fsf@Johns-MacBook-Air.local>
	<87oa6afmeu.fsf@saiph.selenimh>
	<m2vb0iky97.fsf@Johns-MacBook-Air.local>
	<87k2gxg8qm.fsf@saiph.selenimh>
	<m2shvllgt4.fsf@Johns-MacBook-Air.local>
	<8737nlfqdv.fsf@saiph.selenimh>
	<m2oa69l0ec.fsf@Johns-MacBook-Air.local>
	<87y45bvm12.fsf@saiph.selenimh>
	<m2poqfn1pp.fsf@Johns-MacBook-Air.local>
	<8737n7go9k.fsf@saiph.selenimh> <m2eg6rrn0h.fsf@andrew.cmu.edu>
	<87lh0zexsy.fsf@saiph.selenimh> <m2inw2zy08.fsf@andrew.cmu.edu>
	<87r3a28zrx.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <johnrkitchin@gmail.com>) id 1bWYBB-00055M-1Q
	for emacs-orgmode@gnu.org; Sun, 07 Aug 2016 20:12:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <johnrkitchin@gmail.com>) id 1bWYB6-0006d3-Pd
	for emacs-orgmode@gnu.org; Sun, 07 Aug 2016 20:12:27 -0400
Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:35435)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <johnrkitchin@gmail.com>) id 1bWYB6-0006cv-KI
	for emacs-orgmode@gnu.org; Sun, 07 Aug 2016 20:12:24 -0400
Received: by mail-it0-x22b.google.com with SMTP id u186so62097387ita.0
	for <emacs-orgmode@gnu.org>; Sun, 07 Aug 2016 17:12:24 -0700 (PDT)
In-reply-to: <87r3a28zrx.fsf@fastmail.fm>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Matt Lundin <mdl@imapmail.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>, Nicolas Goaziou <mail@nicolasgoaziou.fr>

That looks like the correct fix for org-eww.el.

What is the protocol for fixing the contrib packages? I can take a pass
at doing it if it is ok.



Matt Lundin writes:

> Thanks, John, for improving link functionality in org-mode!
>
> I just discovered that this change breaks the contrib files that use
> org-store-link-functions and org-add-link-type.
>
> I'm not familiar enough with the details of org-link-set-parameters to
> fix all of the contrib files, but I am including a simple patch to
> update a contrib file that I use regularly: org-eww.el.
>
> Thanks,
> Matt


-- 
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu