From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Schmitt <alan.schmitt@polytechnique.org>
Subject: Re: [PATCH] Improve configurability of ox-koma-letter
Date: Mon, 22 Apr 2013 14:06:36 +0200
Message-ID: <m2haiy7os3.fsf@polytechnique.org>
References: <20130421175957.GA7821@cartman> <m2li8b6khn.fsf@polytechnique.org>
	<87ppxnkl4d.fsf@gmail.com> <m2k3nu7vz8.fsf@polytechnique.org>
	<20130422105742.GD7821@cartman>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:48128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UUFWH-0004Pn-Qk
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 08:06:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UUFWC-0006Ev-DA
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 08:06:53 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UUFWC-0006Ed-70
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 08:06:48 -0400
In-reply-to: <20130422105742.GD7821@cartman>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Viktor Rosenfeld <listuser36@gmail.com>
Cc: emacs-orgmode@gnu.org

Viktor Rosenfeld writes:

> Hi Alan,
>
> Alan Schmitt wrote:
>
>> A couple notes about the patch:
>> - Could you create it using "git format-patch"? This way we'll have
>> more metadata in the commit.
>
> I actually did that first and liked it more because then the patch was
> split into more logical blocks (nine patches in total). However, I did
> not add correct changelog entries to the commits. Should I resend the
> individual patches nevertheless? I could add/change the commit message
> manually in the email, I suppose.

Or you could do a git rebase interactive to merge all the commits
together.

>> - I think there is an issue with the handling of signatures. I tried
>> with an old letter that uses a LCO with a graphical signature in it, but
>> it gets overridden upon export. Here is the generated TeX.
>> 
>> #+BEGIN_SRC latex
>> \LoadLetterOption{InriaRennesFR}
>> \setkomavar{signature}{\usekomavar{fromname}}
>> #+END_SRC
>> 
>
> Have you tried clearing the signature?
>
> #+BEGIN_SRC emacs-lisp
> (setq org-koma-letter-signature nil)
> #+END_SRC

Yes, I changed it globally and I still get the same thing. I also
tried doing a

#+BEGIN_SRC org
#+signature: ""
#+END_SRC

and it inserts it in the LaTeX file as such, after my LCO declaration.

Alan