From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Schmitt <alan.schmitt@polytechnique.org>
Subject: Re: [patch] ox-koma-letter.el: subject changes [2/4]
Date: Mon, 20 May 2013 17:49:07 +0200
Message-ID: <m2hahxtzws.fsf@polytechnique.org>
References: <87wqqusder.fsf@pank.eu> <87obc6scty.fsf@pank.eu>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:43710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UeSKo-00026d-01
	for emacs-orgmode@gnu.org; Mon, 20 May 2013 11:49:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UeSKj-0000tM-Co
	for emacs-orgmode@gnu.org; Mon, 20 May 2013 11:49:13 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:47642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1UeSKj-0000t7-6S
	for emacs-orgmode@gnu.org; Mon, 20 May 2013 11:49:09 -0400
In-reply-to: <87obc6scty.fsf@pank.eu>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: n.goaziou@gmail.com, emacs-orgmode@gnu.org

Hello Rasmus,

Rasmus writes:

> This could be a problematic change.  It changes the way :with-subject
> works.  I've added changes to allow the subject style to be choose as
> a radio list with customize.  The reason is that LaTeX becomes unhappy
> if it is not a supported value.  If #+OPTIONS subject:t the default is
> used.  If #+OPTIONS subject:my-crazy-string it tries that and most
> likely hell will break loose.
>
> Viktor, you're usage of ox-koma-letter.el is quite different from mine
> in that you rely (heavily?) on LCO files.  If you could test this and
> see what you think of it it would be great.  On my system it doesn't
> break anything vital but I might have missed something.  

According to my very limited emacs-lisp knowledge, this looks fine. I
would suggest a couple renamings:

beavior -> behavior
fteropening -> afteropening
No-export -> noexport (so that it looks like the other ones).

Best,

Alan