From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id KP/nBC+4M2Y+RwAAqHPOHw:P1 (envelope-from ) for ; Thu, 02 May 2024 17:58:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id KP/nBC+4M2Y+RwAAqHPOHw (envelope-from ) for ; Thu, 02 May 2024 17:58:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=adamkovic.org header.s=fm1 header.b=BbkDe5ho; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="L MPROcG"; dmarc=pass (policy=none) header.from=adamkovic.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714665519; a=rsa-sha256; cv=none; b=M01SSSyvF9oAtANSXoKYDC+lc+FhWXBe/FUK4VUE4SRDP4EBvbd+3END7ex9FlG4h08t9P gdCYSONm+JZJfewZHuNkJNsUI0o0oVz4dsSmmQ87tzSr4rJEIbBspa+YG51QleQPKWpFNL kzXNbH/GI6l4jP5nYyQ3HY4ahhWqUeaneh1NEkNLEHF/CM9grgsMUN6BzKiPLB6P7pqgIY IgMZuN7SEStG8MeSWFXTdBQ6OtaZ5Z3Sk6LbDJTOz95l3jVRRAU/w+WDeTIFdzxEDm0UH6 gC6VFZjnjg4dDseHJU03xKCw8z6RH4SKLwlJtQUSd7MDaanjZjUURV2dNhfkLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=adamkovic.org header.s=fm1 header.b=BbkDe5ho; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="L MPROcG"; dmarc=pass (policy=none) header.from=adamkovic.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714665519; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0ZHKvjmfSLzM=; b=CCOQeDS1Qfv45UBVpy7kHocbRtKf6f4cqMscJK+446p3lDKJw0lYKs33RwQfJfdzLTFp4Z WYxB6AnjxOtM/I/Nuay6xB4Hr3r5ys8GsEsEnzLd6ayEHaKO119MITYgm3n9Jnq1DwkHa2 91E723F3bywpk5RIq1rnkQndJyK97+ehB6OxsNBwK3Z51O9jPsKGp/eb0U9ZqwEGIcLT8m kR+WR2MUbb0OQ7wsJiEEV4F4ehDzFgogGfnE+arIJUiTWFkQ2AA/L1HCsuObKkYCgW7L2m 31q6vppqzuHn3SLbbd0frE4OW8oruemkRPBfx9TVsvxBvuUG0YLiCaSR4ye3FA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D194B35092 for ; Thu, 2 May 2024 17:58:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Yov-0001xz-Ow; Thu, 02 May 2024 11:58:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Yot-0001wl-8d for emacs-orgmode@gnu.org; Thu, 02 May 2024 11:58:03 -0400 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Yoq-0003L3-5P for emacs-orgmode@gnu.org; Thu, 02 May 2024 11:58:02 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id D21481140146; Thu, 2 May 2024 11:57:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 02 May 2024 11:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1714665477; x=1714751877; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0 ZHKvjmfSLzM=; b=BbkDe5hoFl7vACmN61PDPmw9ulJd7QhBCZlBWgsm1sw9Hdij +Pm3gV9jF+WA0fEbL1WoFk4mdWK8wqPD54lxKQho1Z3LLYVmwgIAS6i2wdsWaCb0 xcASrGVaqmHXMFO8xJ7MldkTKwOuyl/Wie47V+4hMPHcTldtHit0RD6vwj9MdLI+ QvS2PLh4/L8BX/e+49GboHVtwn1VZkvyte3tCV+pXdK4Lt3JgE3O8wCvvGwi5fR3 hOHV9iIlbDJf3BVFIBYKGLMEJO6h+YF9oRXz6VQZRvTccEX/K2Ee9slVFzLI4ZhG 4YaFUdsyWQ8kRHgaPuH5Xcv5d/NpywPBCKh1jQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714665477; x= 1714751877; bh=+6N4DgJwLlgKJfz458LrSY01mezLjxX0ZHKvjmfSLzM=; b=L MPROcGCT9uhzCKpGMEVrfrrU4JwIrtGLkLoH5kMedgVOetvpJvaJcVCSOSWuxNLW yR+rqLbP+XXHuj4sO8x9K+Jny3piYrX9EA10AKyki3naBz6Ptegu2LmjRQBb3war v54rVaHZqpBGUNGlhwe/BdMM5UwIXCWwH2u0vhfOQ6tIvJw95AS/crNuP7xbgdy5 Ld8nPcnwR0r2CB6KiML658nBEj4DlIAsP6lh+EzfSWz/AoiQfZhNKtxmf64gU5G9 0UR7OZ4FdPNK5A+ljjsz5vDit86d0BYK/PXdpe/+pWiOS+2YpUw/tOZrnfS8oqNU VdawGMZ+cqlfOXM5Y04BA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddukedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfggtgfgsehtqh ertddttdejnecuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhitgcuoehruhguohhl fhesrggurghmkhhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnhepkeegffdttdduve dvtdeuvdeugeeugfeffedvhffhveekjeetffdtfeeigeettefgnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhuugholhhfsegruggrmhhkoh hvihgtrdhorhhg X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 May 2024 11:57:56 -0400 (EDT) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-lua: Support all types and multiple values in results In-Reply-To: <874jbjywq3.fsf@localhost> References: <20240423164458.33702-1-rudolf@adamkovic.org> <8734raewr6.fsf@localhost> <87pluctf6m.fsf@localhost> <87il01k6k1.fsf@localhost> <874jbjywq3.fsf@localhost> Date: Thu, 02 May 2024 17:57:54 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=103.168.172.156; envelope-from=rudolf@adamkovic.org; helo=fhigh5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D194B35092 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.55 X-Spam-Score: -9.55 X-TUID: Cj7lqfxt6cmG Ihor Radchenko writes: > May you please elaborate why this breaking change is going to lead to > significant improvement? How is using "," worse than using "|"? Either > way, strings containing the separator will become problematic and need > to be escaped. Moreover, using "|" may lead to interpreting the output > as Org tables, which may be surprising to users. Thank you for the review! The change of the separator was a lazy move on my part. I appologize. I changed the separator because I could not figure out how to make Org behave sanely. The problem is not specific to Lua: src_elisp{"3, 2, 1, and go!"} {{{results(=3D3\, 2\, 1\, and go!=3D)}}} Why Org is escaping commas here? In other words, should my tests expect \-escapes in front of commas, or is that a bug? I am attaching a V2 of the patch that: - does not modify the separator anymore (resulting in 3 failing tests) - adds one more test (which is just a sanity check, you can ignore it) - fixes Lua code indentation (as indented by the Lua major mode) Thank you for your guidance. Rudy --=20 "Be especially critical of any statement following the word 'obviously.'" --- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25, 84103 Bratislava, Slovakia, European Union