buffer local org-src-preserve-indentation not respected

buffer local org-src-preserve-indentation not respected

[David Dynerman]

Dear list,

I'd like to report a bug. It seems that setting
org-src-preserve-indentation to true doesn't work if it's set buffer
local.

To reproduce, save the following as an org file:

#+BEGIN_SRC python :tangle preserve-indent.py
class Foo:
    bar = 5
#+END_SRC

Here is some interstitial text!

#+BEGIN_SRC python :tangle preserve-indent.py
    def __init__(self):
        self.bar = 7
#+END_SRC

Then:

1) (setq org-src-preserve-indentation nil) and tangle the file. Open
preserve-indent.py and note that def __init__ has no leading whitespace,
which means python will not recognize it as a member of Foo

2) (setq org-src-preserve-indentation t) and tangle the file. Open
preserve-indent.py and note that now def __init__ is properly
indented. This is the expected behavior.

3) (setq org-src-perserve-indentation nil), then M-x
make-variable-buffer-local and set org-src-preserve-indentation to
t. Tangle the file and open preserve-indent.py. Note that def __init__
is back to being not-indented. The expected behavior is that the
indentation would be respected, as in #2.

David

Re: buffer local org-src-preserve-indentation not respected

[Nicolas Goaziou]

Hello,

David Dynerman <emperordali@block-party.net> writes:

> I'd like to report a bug. It seems that setting
> org-src-preserve-indentation to true doesn't work if it's set buffer
> local.
>
> To reproduce, save the following as an org file:
>
> #+BEGIN_SRC python :tangle preserve-indent.py
> class Foo:
>     bar = 5
> #+END_SRC
>
>
> Here is some interstitial text!
>
> #+BEGIN_SRC python :tangle preserve-indent.py
>     def __init__(self):
>         self.bar = 7
> #+END_SRC
>
> Then:
>
> 1) (setq org-src-preserve-indentation nil) and tangle the file. Open
> preserve-indent.py and note that def __init__ has no leading whitespace,
> which means python will not recognize it as a member of Foo
>
> 2) (setq org-src-preserve-indentation t) and tangle the file. Open
> preserve-indent.py and note that now def __init__ is properly
> indented. This is the expected behavior.
>
> 3) (setq org-src-perserve-indentation nil), then M-x
> make-variable-buffer-local and set org-src-preserve-indentation to
> t. Tangle the file and open preserve-indent.py. Note that def __init__
> is back to being not-indented. The expected behavior is that the
> indentation would be respected, as in #2.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: buffer local org-src-preserve-indentation not respected

[David Dynerman]

Dear Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Fixed. Thank you.

Thank you very much.

I just tried, and I still encounter this buf on the current git code. Reproduction is the same as before:

#+BEGIN_SRC python :tangle preserve-indent.py
class Foo:
    bar = 5
#+END_SRC

Here is some interstitial text!

#+BEGIN_SRC python :tangle preserve-indent.py
    def __init__(self):
	self.bar = 7
#+END_SRC

If I globally set org-src-preserve-indentation to t, then tangle, the output file has the correct specified indentation with the second block. If I make org-src-preserve-indentation buffer local and set it to t, then the second block is tanlged without any leading indentation.

Perhaps the tangling code doesn't see the buffer local setting of org-src-preserve-indentation from the buffer being tangled?

Thank you very much for all your hard work,
David

Re: buffer local org-src-preserve-indentation not respected

[Nicolas Goaziou]

Hello,

David Dynerman <emperordali@block-party.net> writes:

> I just tried, and I still encounter this buf on the current git code. Reproduction is the same as before:
>
> #+BEGIN_SRC python :tangle preserve-indent.py
> class Foo:
>     bar = 5
> #+END_SRC
>
>
> Here is some interstitial text!
>
> #+BEGIN_SRC python :tangle preserve-indent.py
>     def __init__(self):
> 	self.bar = 7
> #+END_SRC
>
> If I globally set org-src-preserve-indentation to t, then tangle, the
> output file has the correct specified indentation with the second
> block. If I make org-src-preserve-indentation buffer local and set it
> to t, then the second block is tanlged without any leading
> indentation.

Fixed (hopefully) this time. Thank you for the feedback.

Regards,

-- 
Nicolas Goaziou

Re: buffer local org-src-preserve-indentation not respected

[David Dynerman]

Dear Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Fixed (hopefully) this time. Thank you for the feedback.

It's working wonderfully now - thank you very much.

David