From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gBOdKciTbmIdWwAAbAwnHQ (envelope-from ) for ; Sun, 01 May 2022 16:06:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QL6lKciTbmJ3ggAA9RJhRA (envelope-from ) for ; Sun, 01 May 2022 16:06:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 10485ABFD for ; Sun, 1 May 2022 16:06:00 +0200 (CEST) Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlAD0-0007vB-Po for larch@yhetil.org; Sun, 01 May 2022 10:05:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlAC5-0007un-WE for emacs-orgmode@gnu.org; Sun, 01 May 2022 10:05:02 -0400 Received: from [39.171.215.226] (port=13023 helo=Mac-mini.local) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlAC3-0003Ii-Po for emacs-orgmode@gnu.org; Sun, 01 May 2022 10:05:01 -0400 Received: by Mac-mini.local (Postfix, from userid 501) id 6B7984CB56D0; Sun, 1 May 2022 22:04:50 +0800 (CST) References: <87ilqq6jjr.fsf@localhost> User-agent: mu4e 1.6.10; emacs 29.0.50 From: "Christopher M. Miles" To: Ihor Radchenko Subject: Re: [PATCH] Add make target to ease creating reproducers and testing them Date: Sun, 01 May 2022 22:03:18 +0800 In-reply-to: <87ilqq6jjr.fsf@localhost> Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 39.171.215.226 (deferred) Received-SPF: softfail client-ip=39.171.215.226; envelope-from=numbchild@gmail.com; helo=Mac-mini.local X-Spam_score_int: 58 X-Spam_score: 5.8 X-Spam_bar: +++++ X-Spam_report: (5.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FROM=0.001, MSGID_MULTIPLE_AT=1, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_PBL=3.335, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, SPOOFED_FREEMAIL_NO_RDNS=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: reject X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651413960; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ST59ZxNVKL9m8Oydg62uddixsyiMHH+EsHovl/PDeQU=; b=dI9dfCVwof4lmuVVDlCXjOBqdPmsecWAT0UEOkTtCPOeyENIMW3chHa2y6Ce/T6j92wzod eAqrN4eaj7iUXdp3f9W87GM79KDurIPutMVS6nX3+1FpxeatUGQ668JIMPGUKcH/tN3WBE yRy4AiLdTRZlqFbnKdxmd30IJHQ4IyWyuiBpf6crovmAaUJAcqdS78Kh+84VL8NPEBiNa8 JQx9iQtur2V8TZe/eoswf4ArZ3Rt4OlNvBPmSSe0EJCh8Isvf8mpf6gF3YW1HioG5u0pBn 98TtjiCXpg0S/r8Idt21e1VWHa7VWtVbMvTMHvxarBf1PsfVKyr4d2/D4F9xqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651413960; a=rsa-sha256; cv=none; b=bt3TmkOe54hkLkpQOJtFP4i2TjhscJyLn9wTpaQHHkNIN+5NBTRjb3UvWXLvBAtg3S9G6M NAuoCUErIp+hGnROoIgLeJ+jmfM7uZ9HIorXAPBkJnoPSW2cVzK8llYN32xgpjGFSadrAK /jFKMvsIyYbg7sEgM/2oO6ZZIoIJ2+Qd10t/K1fXc4xe3GhhlV4ebG1VpbS9ZBdJqN0sYG r+xdZC7MQQn10C1XqY7niF+YuPWvVjFr5mC2vMd2rYprk1jHsMwFlF+XcdqAvm+lWLAf0I lR4F8Ufd3UZCrFDbtbuoncR2JuU5vtmPmN7U/iEvG8sChrdVekMWNQnYHUFoeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.61 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 10485ABFD X-Spam-Score: 1.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: htRVvJAzT9Zu --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I agree this idea, this could unify the reproduce steps and help some user = save time and help org-mode maintainer get information they want. Ihor Radchenko writes: > Hi, > > In the Feedback section of the manual, we provide instructions on how to > create reproducers: https://orgmode.org/manual/Feedback.html > > The instructions are nice, but I was thinking to simplify things for the > users further. > > I propose a new make target: make repro > It will run the commands we already suggest, but without a need to > create minimal file, pass all that arguments to emacs, etc > > WDYT? > > Best, > Ihor > > From 8d5f9f023af18828656df85a0ce4069e004dbf5d Mon Sep 17 00:00:00 2001 > Message-Id: <8d5f9f023af18828656df85a0ce4069e004dbf5d.1651373896.git.yant= ar92@gmail.com> > From: Ihor Radchenko > Date: Sun, 1 May 2022 10:44:10 +0800 > Subject: [PATCH] mk: Add make target "repro" for easy bug testing > > * mk/default.mk (REPRO_DEBUG): New custom variable enabling extra > debugging facilities in Emacs instance open by make repro. > (REPRO_ARGS): Extra arguments passed to Emacs by make repro. > (REPRO_INIT): > (REPRO): Define Emacs cmd for testing. > * mk/targets.mk (.PHONY): > (repro): Add new target. > * doc/org-manual.org (Feedback): Describe the new make target. > --- > doc/org-manual.org | 8 ++++++++ > mk/default.mk | 21 +++++++++++++++++++++ > mk/targets.mk | 5 ++++- > 3 files changed, 33 insertions(+), 1 deletion(-) > > diff --git a/doc/org-manual.org b/doc/org-manual.org > index c0bd853ca..6a574977e 100644 > --- a/doc/org-manual.org > +++ b/doc/org-manual.org > @@ -269,6 +269,14 @@ ** Feedback > (add-to-list 'load-path (expand-file-name "/path/to/org-mode/lisp")) > #+end_src >=20=20 > +If you are using Org mode version from Git repository, you can start > +minimal session using make. > + > +: # Bare Emacs > +: make repro > +: # or pass extra arguments > +: make repro REPRO_ARGS=3D"-l /path/to/minimal/config.el /tmp/bug.org" > + > If an error occurs, a "backtrace" can be very useful---see below on > how to create one. Often a small example file helps, along with clear > information about: > diff --git a/mk/default.mk b/mk/default.mk > index 804089280..33e737da3 100644 > --- a/mk/default.mk > +++ b/mk/default.mk > @@ -59,6 +59,11 @@ BTEST_OB_LANGUAGES =3D awk C fortran maxima lilypond o= ctave perl python > # extra packages to require for testing > BTEST_EXTRA =3D > # ess-site # load ESS for R tests > +# Whether to activate extra debugging facilities for make repro. > +REPRO_DEBUG ?=3D yes > +# Extra arguments passed to Emacs for make repro. > +# e.g. -l config.el /tmp/bug.org > +REPRO_ARGS ?=3D > ##->8------------------------------------------------------------------- > ## YOU MAY NEED TO ADAPT THESE DEFINITIONS > ##---------------------------------------------------------------------- > @@ -93,6 +98,22 @@ BTEST =3D $(BATCH) $(BTEST_INIT) \ > # should be useful for manual testing and verification of problems. > NOBATCH =3D $(EMACSQ) $(BTEST_INIT) -l org -f org-version >=20=20 > +ifeq ($(REPRO_DEBUG), yes) > +REPRO_INIT =3D --eval "(setq \ > + debug-on-error t\ > + debug-on-signal nil\ > + debug-on-quit nil\ > + org-element--cache-self-verify 'backtrace\ > + org-element--cache-self-verify-frequency 1.0\ > + org-element--cache-map-statistics t)" > +else > +REPRO_INIT =3D > +endif > + > +# Running a plain emacs with no config, this Org mode loaded, and > +# debugging facilities activated. > +REPRO =3D $(NOBATCH) $(REPRO_INIT) $(REPRO_ARGS) > + > # start Emacs with no user and site configuration > # EMACSQ =3D -vanilla # XEmacs > EMACSQ =3D $(EMACS) -Q > diff --git a/mk/targets.mk b/mk/targets.mk > index 6de77b1e6..5cba63e21 100644 > --- a/mk/targets.mk > +++ b/mk/targets.mk > @@ -41,7 +41,7 @@ endif > cleanlisp cleandoc cleandocs cleantest \ > compile compile-dirty uncompiled \ > config config-test config-exe config-all config-eol config-version \ > - vanilla > + vanilla repro >=20=20 > CONF_BASE =3D EMACS DESTDIR ORGCM ORG_MAKE_DOC > CONF_DEST =3D lispdir infodir datadir testdir > @@ -132,6 +132,9 @@ $(INSTSUB): > autoloads: lisp > $(MAKE) -C $< $@ >=20=20 > +repro: cleanall autoloads > + -@$(REPRO) & > + > cleandirs: > $(foreach dir, $(SUBDIRS), $(MAKE) -C $(dir) cleanall;) =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmJuk34ACgkQG13xyVro msMruQf/dNc2VmbXKboRUAVl2YUx5/rDewTOSeXPWSscNN+mfc11AR5TMf4ibC3U AODvQCG7HyvJ7SqGiBmKj9a15ulUXFgwUJKdJZN9yrILEzsxRKRRgq4K2uHtsb5y f6KuQl3AGFqN4d5ZsyKAm+6RaCfZTwNfxdrFzEV3lF6+b9DApnQcDkHOE041lVgf 68URDBTxyosGPYzPdLUf6sjcKWgwHqpoEPJz3GWGnUNlIDGhylKQD2fD6WN6xlpU mqBuaFGOiXlPJBU+c4EnkCJ7kfxkf8pgWTQM1BENQ4YcW35St8Lhhs2mxHRCCsi0 jOe4iV5oh9hI0/cvN87fpCw6Fb/vlA== =BBHx -----END PGP SIGNATURE----- --=-=-=--