Re: interaction between org-latex-custom-lang-environments and name when exporting to latex

[Alan Schmitt <alan.schmitt@polytechnique.org>]

[-- Attachment #1.1: Type: text/plain, Size: 472 bytes --]

Hi,

On 2015-11-27 22:05, Rasmus <rasmus@gmx.us> writes:

>>> Also, you need to denote that the defcustom was changed.
>>>
>>>   :version "25.1"
>>>   :package-version '(Org . "9.0")
>>>
>>> When you are at it, please add the missing tags, :group and :type.
>>
>> It's not a defcustom but a defvar. (But maybe it should be a defcustom …)
>
> It should be a defcustom.  Feel free to fix it, preferably in a separate
> patch.

Here is a patch to do so.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-ox-latex-Make-org-latex-custom-lang-environments-a-d.patch --]
[-- Type: text/x-patch, Size: 1385 bytes --]

From b94b5ba0bdb619cb9047efb19432216812eaf6a2 Mon Sep 17 00:00:00 2001
From: Alan Schmitt <alan.schmitt@polytechnique.org>
Date: Mon, 30 Nov 2015 13:07:56 +0100
Subject: [PATCH] ox-latex: Make org-latex-custom-lang-environments a defcustom

* ox-latex.el (org-latex-custom-lang-environments): Change from defvar
  into a defcustom.
---
 lisp/ox-latex.el | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index eaad29f..407df6b 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -1021,7 +1021,7 @@ block-specific options, you may use the following syntax:
 	   (string :tag "Minted option name ")
 	   (string :tag "Minted option value"))))
 
-(defvar org-latex-custom-lang-environments nil
+(defcustom org-latex-custom-lang-environments nil
   "Alist mapping languages to language-specific LaTeX environments.
 
 It is used during export of src blocks by the listings and minted
@@ -1062,7 +1062,14 @@ will produce
   \\end{minted}
   \\caption{<caption>}
   \\label{<label>}
-  \\end{listing}")
+  \\end{listing}"
+  :group 'org-export-latex
+  :type '(repeat
+	  (list
+	   (symbol :tag "Language name                    ")
+	   (string :tag "Environment name or format string")))
+  :version "25.1"
+  :package-version '(Org . "9.0"))
 
 
 ;;;; Compilation
-- 
2.6.3


[-- Attachment #1.3: Type: text/plain, Size: 260 bytes --]


> The rest looks good to me.  Feel free to push (modulus someone else saying
> otherwise).

Thanks a lot, I pushed it.

Best,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated November 29, 2015, Mauna Loa Obs.): 400.37 ppm

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]