From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rainer M Krug Subject: Re: [PATCH] -for review- Tangling with variable transfer of variables Date: Mon, 23 Jun 2014 12:46:29 +0200 Message-ID: References: <87zjh8bo8s.fsf@gmail.com> <87egyhboki.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz1lp-0004TP-IO for emacs-orgmode@gnu.org; Mon, 23 Jun 2014 06:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz1li-00071f-Kr for emacs-orgmode@gnu.org; Mon, 23 Jun 2014 06:46:41 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:39188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz1li-00071M-FF for emacs-orgmode@gnu.org; Mon, 23 Jun 2014 06:46:34 -0400 Received: by mail-we0-f172.google.com with SMTP id u57so6793601wes.17 for ; Mon, 23 Jun 2014 03:46:33 -0700 (PDT) In-Reply-To: <87egyhboki.fsf@gmail.com> (Aaron Ecay's message of "Sat, 21 Jun 2014 23:39:09 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Charles C. Berry" Cc: emacs-orgmode@gnu.org, Eric Schulte --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Aaron Ecay writes: > Hi Rainer, > > 2014ko ekainak 21an, "Charles C. Berry"-ek idatzi zuen: >>=20 >> On Fri, 20 Jun 2014, Rainer M Krug wrote: >>=20 >>> Attached please find =3Dthe reworked patch. >>>=20 >>> 1) uses local() and closes connection >>> 2) does not leave a variable cal;led file behind >>>=20 >>=20 >> Seems to work on a few test cases. >>=20 >> I'd move the strings to defconsts. >>=20 >> Putting a newline before each `%S' will outdent the first line of=20 >> :var value when it is echoed in the session log so it will be easier to= =20 >> view. > > +1 to both of the above suggestions but otherwise the patch looks good > and I think it should be applied. Thanks - a second patch has been send with the additional suggestions. Rainer =2D-=20 Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology,= UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D): +49 - (0)3 21 21 25 22 44 email: Rainer@krugs.de Skype: RMkrug PGP: 0x0F52F982 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBAgAGBQJTqAWFAAoJENvXNx4PUvmCofgH/3mm6SGutlBqlVqxb8GRISlU FVr/kUZQur6WF3InwNiB62yTyv8fnA6N1pZudbIRHLCN37vLMVLWSp3gGAWJnkci JWi2VGLPpebjSgStOcvlOFqC9P2jY3XWQ8Dt/MVy7RMQRDfGkeZPrTruMNwepmIe yjh8qSxUpxIqMTdovwY/qhggZ11kbhfv9gq1sI6ctEzvX/BlCPZSCfVCaqziXaAP T+JlfP5AaHeKywjPUwT+epTKsTwJj1cydm+Ywf06H6taGesmIqXUCCS0OqcoDQW6 x0aOffjjFsf2/nl4lAL0VekmYl1x18IDSeikRCz9TPpIwnMSoBJvcqEI61/9i5k= =l3W+ -----END PGP SIGNATURE----- --=-=-=--