From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Wiegley <jwiegley@gmail.com>
Subject: Keeping an eye on byte-compilation warnings
Date: Sat, 13 Aug 2011 16:49:50 -0500
Message-ID: <m24o1lnfr5.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:33759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jwiegley@gmail.com>) id 1QsM5a-0001Po-Nb
	for emacs-orgmode@gnu.org; Sat, 13 Aug 2011 17:49:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jwiegley@gmail.com>) id 1QsM5Z-000799-Ou
	for emacs-orgmode@gnu.org; Sat, 13 Aug 2011 17:49:54 -0400
Received: from mail-yi0-f41.google.com ([209.85.218.41]:61339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jwiegley@gmail.com>) id 1QsM5Z-000794-L5
	for emacs-orgmode@gnu.org; Sat, 13 Aug 2011 17:49:53 -0400
Received: by yib2 with SMTP id 2so2911590yib.0
	for <emacs-orgmode@gnu.org>; Sat, 13 Aug 2011 14:49:52 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Maybe we're all using different versions of Emacs, but I find that
byte-compilation warnings keep increasing as time goes by.  I'd like to ask
people to compile their code before committing, to keep the build log clean.
It looks messy when there are lots of unnecessary warnings.

Here's what I'm seeing now:

--8<---------------cut here---------------start------------->8---
lisp/org.el:

  In end of data:
  org.el:20575:1:Warning: the following functions are not known to be defined:
      org-agenda-todo, org-find-invisible, org-find-visible
--8<---------------cut here---------------end--------------->8---

These represent a cyclic dependency.  Should org.el contain some autoload
forms during compilation?
  
--8<---------------cut here---------------start------------->8---
lisp/org-footnote.el:

  In org-footnote-in-valid-context-p:
  org-footnote.el:185:37:Warning: reference to free variable
      `message-cite-prefix-regexp'
  
  In end of data:
  org-footnote.el:869:1:Warning: the following functions are not known to be
      defined: message-point-in-header-p, org-icompleting-read
--8<---------------cut here---------------end--------------->8---

Is there a reason org-footnote doesn't just require org?

--8<---------------cut here---------------start------------->8---
lisp/org-list.el:

  In org-list-send-item:
  org-list.el:1456:56:Warning: Function `sort*' from cl package called at
      runtime
--8<---------------cut here---------------end--------------->8---

I've fixed this one in d24a141.  There was no reason to use sort* instead of
sort.

--8<---------------cut here---------------start------------->8---
lisp/org-table.el:

  In org-table-eval-formula:
  org-table.el:2437:23:Warning: assignment to free variable
      `duration-output-format'
  org-table.el:2557:34:Warning: reference to free variable
      `duration-output-format'
  
  In org-table-time-string-to-seconds:
  org-table.el:3252:11:Warning: assignment to free variable `minus'
  org-table.el:3257:13:Warning: reference to free variable `minus'
--8<---------------cut here---------------end--------------->8---

I think an empty defvar during compilation is in order here, and that minus is
simply missing from the `let'.

Thanks,
  John