From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Edmondson Subject: Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query Date: Tue, 26 Nov 2019 20:05:35 +0000 Message-ID: References: <87h82wrjvb.fsf@iris.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87h82wrjvb.fsf-TDhmT+1V6bdypu2/aTzxt1aTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: notmuch-bounces-gxuj+Tv9EO5zyzON3hdc1g@public.gmane.org Sender: "notmuch" To: Sean Whitton , emacs-orgmode-mXXj517/zsQ@public.gmane.org Cc: notmuch-gxuj+Tv9EO5zyzON3hdc1g@public.gmane.org List-Id: emacs-orgmode.gnu.org On Thursday, 2019-11-21 at 14:37:44 -07, Sean Whitton wrote: > The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls > `notmuch-show' with an arbitrary notmuch search query. However, the > docstring for `notmuch-show' specifies that a notmuch thread ID, rather > than an arbitrary notmuch query, should be supplied to `notmuch-show'. > > The effect of this is that the variable `notmuch-show-thread-id' may > contain an arbitrary search query rather than a thread ID. That broke > some code of mine which uses that variable. Could you explain how you were using `notmuch-show-thread-id' in a way that was broken by the presence of an arbitrary query? (Not arguing right or wrong, just trying to understand the problem.) > `org-notmuch-follow-link' needs to continue to accept an arbitrary query > (as notmuch thread IDs are not stable), but it should convert it to a > thread ID before passing it to `notmuch-show'. dme. -- I'd rather be with you than flying through space.