emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Christopher M. Miles" <numbchild@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: numbchild@gmail.com, emacs-orgmode@gnu.org
Subject: Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption
Date: Mon, 01 May 2023 19:32:21 +0800	[thread overview]
Message-ID: <m2354gp9mb.fsf@numbchild@gmail.com> (raw)
In-Reply-To: <87jzxsqyme.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]


Ihor Radchenko <yantar92@posteo.net> writes:

> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> I'm also try to improve this file to improve large Org buffer saving performance.
>
> org-encrypt already caches the encrypted text and takes basically no
> time for the repeated encryption, as long the text to be encrypted is unchanged.
>
>> I have some ideas:
>>
>> - auto encrypt buffer on buffer save hook (currently mechanism, your patch improved it)
>
> Sorry, but my patch has nothing to do with save hook. It only changes decryption.
>
>> - auto decrypt on org-cycle expand headline if current headline is encrypted. e.g. on `org-cycle-hook`
>
> I am not sure how it has anything to do with performance.
> You can already use C-c C-r (or M-x org-reveal) to decrypt entry at
> point.
> We should certainly not attempt decryption on <tab> by default - it may
> be annoying when you actually do not want to decrypt anything, just
> look inside.

You're right, I have not consider enough.

>
>> - auto encrypt ONLY current fold action on headline scope if has crypt key specified. e.g. on `org-cycle-hook`
>
> That might be possible, but I often do not want my encrypted
> sub-headings being encrypted while I re-structure and re-fold my file.
>
> May you elaborate what performance issues you are experiencing?

My performance issue is a large Org file about 2M size on saving. I will
reproduce and generate profiler report for more detailed data and update
in this thread.

-- 

[ stardiviner ]
I try to make every word tell the meaning that I want to express without misunderstanding.

Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2023-05-01 11:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 20:21 [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption Ihor Radchenko
2023-05-01  3:41 ` [SUGGESTION] " Christopher M. Miles
2023-05-01  7:50   ` Ihor Radchenko
2023-05-01 11:32     ` Christopher M. Miles [this message]
2023-05-01 11:46       ` Ihor Radchenko
2023-05-01 12:26         ` Christopher M. Miles
2023-05-01 12:38           ` Ihor Radchenko
2023-05-01 13:12             ` Christopher M. Miles
2023-05-01 13:38               ` Ihor Radchenko
2023-05-01 19:10                 ` Christopher M. Miles
2023-05-01 19:18                   ` Ihor Radchenko
     [not found]             ` <m2sfcgmbpo.fsf@numbchild>
2023-05-02  4:00               ` [EasyPG (epa)] Emacs can't save modified encrypted file Christopher M. Miles
2023-05-02 11:57                 ` Ihor Radchenko
2023-05-02 17:38                   ` Christopher M. Miles
2023-05-02 20:08                     ` Ihor Radchenko
2023-05-03 10:40                       ` Christopher M. Miles
2023-05-03 12:08                         ` Ihor Radchenko
2023-05-03 16:51                           ` Christopher M. Miles
2023-05-03 17:02                             ` Ihor Radchenko
2023-05-03 17:29                               ` [Uploaded Edebug video] " Christopher M. Miles
2023-05-03 19:08                                 ` Ihor Radchenko
2023-05-04  2:28                                   ` Christopher M. Miles
2023-05-04 17:28                                     ` Ihor Radchenko
2023-05-05  6:30                                       ` Christopher M. Miles
2023-05-05  8:36                                         ` Ihor Radchenko
2023-05-05 13:20                                           ` Christopher M. Miles
2023-05-05 15:29                                           ` Christopher M. Miles
2023-05-15 13:38 ` [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption Ihor Radchenko
2023-05-15 15:56 ` Christopher M. Miles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2354gp9mb.fsf@numbchild@gmail.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).