From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SOdoHAicUmMBWAEAbAwnHQ (envelope-from ) for ; Fri, 21 Oct 2022 15:18:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GIEnHAicUmM94AAAauVa8A (envelope-from ) for ; Fri, 21 Oct 2022 15:18:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 514511244 for ; Fri, 21 Oct 2022 15:17:59 +0200 (CEST) Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olruQ-0008Nv-G4 for larch@yhetil.org; Fri, 21 Oct 2022 09:17:58 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olrc6-0005gq-GN for larch@yhetil.org; Fri, 21 Oct 2022 08:59:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olrbt-0005cC-4o for emacs-orgmode@gnu.org; Fri, 21 Oct 2022 08:58:52 -0400 Received: from mr85p00im-ztdg06011201.me.com ([17.58.23.181]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olrbr-0006W9-7x for emacs-orgmode@gnu.org; Fri, 21 Oct 2022 08:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1666357125; bh=8JSl4aaRxT8srj02s1W/hMRJhaJMdfoUwRylMjh7/XU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=H26mT9E9KoxSQ5GwQvax6vq9IwM4al7OflhG00cvWHRR3SAvDnx2xPG3PEH1lMNzq JGwpo8XxT9yT5RcJXLHbiVTkukLHRvykFVbVUgHFo2ZDU/S75q0ZYfjMMc14581QP2 c4fnY8Sm217+JvjXnz9kw1aEdrr8DhqaHBlbrykMuSQBIWup6jdrjviU+ddOP4hIal mD8P5n10eP5/aslphODKFK9dbRIh+WKaoGqLVRh9tWxhIdCTWE1zxlgIQYrZ91hQK4 I3cHKu05/jP8vlVUlDhA6SXS1rjkgbwpBQJAPFJzXz0FiMQilEl0bgNIuwu5ROBMkq pE9I4jkq6EdWw== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06011201.me.com (Postfix) with ESMTPSA id E9447960A3C; Fri, 21 Oct 2022 12:58:44 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-java: Define the list of all supported header arguments In-Reply-To: <871qr17rjy.fsf@localhost> References: <871qr17rjy.fsf@localhost> Date: Fri, 21 Oct 2022 14:58:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-GUID: x9fL0p7K1ChNxcSm3wvf7uweGBbNmZCs X-Proofpoint-ORIG-GUID: x9fL0p7K1ChNxcSm3wvf7uweGBbNmZCs X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.816,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-18=5F01:2022-01-14=5F01,2022-01-18=5F01,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210210077 Received-SPF: pass client-ip=17.58.23.181; envelope-from=salutis@me.com; helo=mr85p00im-ztdg06011201.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666358279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8JSl4aaRxT8srj02s1W/hMRJhaJMdfoUwRylMjh7/XU=; b=doznCJ59xxT/QQ9oLe/XjpweDe7PkX5ZsLAXX9RS9vshCoWvQyVR4Podz9y8nBqMrR8fmJ pVzfqiBnqfHzgKKMEZA9hA1GgCQMdBJjgDOtpAiABV84iSdMVuNVI4SSvz6Y2DjYt/1WMu klcd/Tyuop41DqEC8SMu+/WafCcR2V+H0mihbB/NYf38j8/fqOwnvx0Db5vB/6m//k+Pay uUDMWVdbe+Jmqb1fbLge2SNn/aNQZFam2Vpw1ZrBvs5io63YyosUJWWXxwWEqLyaOgiwjO zKKQ7YH6/HfjhcWGdJFIA+yO5W8KG7OTfP3nXFgED/pmGCsRO0D/C+x9yUoQYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666358279; a=rsa-sha256; cv=none; b=MiUDBusDUHtjkdYNkm9XWd079V0YrVtvz5vpHMhyEfZ2g4ZjluI+x1CLuV+ddPZMiRDSqi rE720IkDyWKd9o3gfcTcwH/BKaSmUp9nXPLcxgPk1/r42N5KzPNBKXL/gZBFuH5PZco/B/ OHiT6OO9Soosi0MM10SIv/cB+/qDrCokM/+nr1IiiBkW2buWhxS5dFQBSvBzdDkxEqn9PD NSekiWxQG8n6VX+3DBnCD+sEC9lGUJu32TChrPvMAqfad2k+U6+ehFrL+9fdoCDnEqxbqj fYpdX0lwWfN8PSuTvTK6NnSUl9FL1FKv9NzU/qPcQDFTKG4jUZDUEp0f8EhXbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=H26mT9E9; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=H26mT9E9; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 514511244 X-Spam-Score: -2.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: UZ9VZTEqdMNw --=-=-= Content-Type: text/plain Ihor Radchenko writes: > Thanks! > Applied onto main. Fantastic! > Fixed. Thanks. Please see the attached patch with updated tests. Rudy --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-test-ob-java-Test-Java-source-block-header-arguments.patch Content-Transfer-Encoding: quoted-printable >From 5405d0419295bb1a0314cb2b3ce07713fc77e792 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Rudolf=3D20Adamkovi=3DC4=3D8D?=3D Date: Fri, 21 Oct 2022 14:48:56 +0200 Subject: [PATCH] test-ob-java: Test Java source block header arguments at a= ll levels MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * testing/lisp/test-ob-java.el (ob-java/lint-header-arguments): Renamed to ob-java/lint-header-args-block. * testing/lisp/test-ob-java.el (ob-java/lint-header-args-heading): Test source block header arguments at the heading level. * testing/lisp/test-ob-java.el (ob-java/lint-header-args-buffer): Test source block header arguments at the buffer level. Reported-by: Rudolf Adamkovi=C4=8D Link: https://orgmode.org/list/m2y1ta9rqe.fsf@me.com --- testing/lisp/test-ob-java.el | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/testing/lisp/test-ob-java.el b/testing/lisp/test-ob-java.el index a62d66557..1cc7fbeb2 100644 --- a/testing/lisp/test-ob-java.el +++ b/testing/lisp/test-ob-java.el @@ -27,7 +27,36 @@ =20 ;;; No Java required =20 -(ert-deftest ob-java/lint-header-arguments () +(ert-deftest ob-java/lint-header-args-buffer () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the buffer level. + (org-test-with-temp-text " +#+property: header-args:java+ :dir /tmp +#+property: header-args:java+ :classname com.example.Example +#+property: header-args:java+ :imports com.example.OtherExample +#+property: header-args:java+ :cmpflag -classpath .:/tmp/example/ +#+property: header-args:java+ :cmdline -classpath .:/tmp/example/ +#+property: header-args:java+ :cmdarg -verbose" + (should-not (org-lint '(wrong-header-argument))))) + +(ert-deftest ob-java/lint-header-args-heading () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the heading level. + (org-test-with-temp-text " +* Test +:PROPERTIES: +:header-args:java+: :dir /tmp +:header-args:java+: :classname com.example.Example +:header-args:java+: :imports com.example.OtherExample +:header-args:java+: :cmpflag -classpath .:/tmp/example/ +:header-args:java+: :cmdline -classpath .:/tmp/example/ +:header-args:java+: :cmdarg -verbose +:END:" + (should-not (org-lint '(wrong-header-argument))))) + +(ert-deftest ob-java/lint-header-args-block () + ;; Test that the Org linter accepts every supported Java source + ;; block header argument at the block level. (org-test-with-temp-text " #+header: :dir /tmp #+header: :classname com.example.Example --=20 2.38.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Thinking is a momentary dismissal of irrelevancies." -- Richard Buckminster Fuller, 1969 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=--