emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Derek Feichtinger <dfeich@gmail.com>
To: emacs-orgmode@gnu.org
Subject: PATCH: invoking RET on agenda clock log line ends up with point in closed clock drawer
Date: Thu, 28 Apr 2016 05:29:13 +0000 (UTC)	[thread overview]
Message-ID: <loom.20160428T071840-396@post.gmane.org> (raw)

Hello

A longer time ago, hitting RET on an agenda clock log line brought up the
respective org buffer with the cursor positioned on the clock line. At some
point this stopped to work cleanly, at least when using clock drawers. The
clock drawer would always be closed (even when it was opened in the org
buffer before jumping.) with the cursor being in the hidden drawer. So, it
became impossible to find the target clock line for e.g. modifying it.

I had fixed it for myself a longer time ago and forgot to submit my proposal
for a patch, until yesterday another user raised my attention to it.

My proposal for a patch is


;; when jumping to the agenda from a log message, the point ends up at
;; a CLOCK item in a LOGBOOK drawer, but the drawer gets closed, even
;; if the drawer was open before. I add a drawer opening function to
;; the respective agenda hook
(defun org-open-if-in-drawer ()
  (let ((element (org-element-at-point)))
    (while (and element
		(not (memq (org-element-type element)
			   '(drawer property-drawer))))
      (setq element (org-element-property :parent element)))
    (when element
      (let ((pos (point)))
	(goto-char (org-element-property :begin element))
	(org-flag-drawer nil)
	(goto-char pos)))))

(add-hook 'org-agenda-after-show-hook #'org-open-if-in-drawer)


Best regards,
Derek

             reply	other threads:[~2016-04-28  5:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  5:29 Derek Feichtinger [this message]
2016-04-30 23:34 ` PATCH: invoking RET on agenda clock log line ends up with point in closed clock drawer Nicolas Goaziou
2016-05-01 10:49   ` Derek Feichtinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20160428T071840-396@post.gmane.org \
    --to=dfeich@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).