Problem with org-timestamp-up and timezones

Problem with org-timestamp-up and timezones

[Eric Abrahamsen]

Hey, I just tried using org-shiftup on a timestamp, and got the
following traceback. I'm using the Org package, and Emacs master from
git.

Let me know if I should dig deeper!


Debugger entered--Lisp error: (error "Invalid time zone specification" (nil nil nil))
  encode-time(0 0 0 14 4 2016 (nil nil nil))
  org-timestamp-change(1 nil updown)
  org-timestamp-up(1)
  funcall-interactively(org-timestamp-up 1)
  call-interactively(org-timestamp-up)
  org-shiftup(nil)
  funcall-interactively(org-shiftup nil)
  call-interactively(org-shiftup nil nil)
  command-execute(org-shiftup)

Re: Problem with org-timestamp-up and timezones

[Jesse]

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> 
> Hey, I just tried using org-shiftup on a timestamp, and got the
> following traceback. I'm using the Org package, and Emacs master from
> git.

I too am experiencing this issue under the same conditions (Emacs master + 
MELPA org 20160411). My trace is nearly identical.

Re: Problem with org-timestamp-up and timezones

[Derek Feichtinger]

Hi

Jesse <holocronweaver <at> gmail.com> writes:

> 
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
> 
> > 
> > Hey, I just tried using org-shiftup on a timestamp, and got the
> > following traceback. I'm using the Org package, and Emacs master from
> > git.
> 
> I too am experiencing this issue under the same conditions (Emacs master + 
> MELPA org 20160411). My trace is nearly identical.
> 
> 

I ran into the same problem right now. Also with org mode from MELPA and the
current emacs master from git.
- GNU Emacs 25.1.50.5 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of
  2016-04-15
- Org-mode version 8.3.4 (8.3.4-34-gacfd41-elpaplus



Debugger entered--Lisp error: (error "Invalid time zone specification" (nil
nil nil))
  encode-time(0 0 12 15 4 2016 (nil nil nil))
  org-timestamp-change(1 nil updown)
  org-timestamp-up(1)
  funcall-interactively(org-timestamp-up 1)
  call-interactively(org-timestamp-up)
  org-shiftup(nil)
  funcall-interactively(org-shiftup nil)
  call-interactively(org-shiftup nil nil)
  command-execute(org-shiftup)

Cheers,
Derek

Re: Problem with org-timestamp-up and timezones

[Derek Feichtinger]

Hi

> 
> I ran into the same problem right now. Also with org mode from MELPA and the
> current emacs master from git.
> - GNU Emacs 25.1.50.5 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of
>   2016-04-15
> - Org-mode version 8.3.4 (8.3.4-34-gacfd41-elpaplus
> 
> Debugger entered--Lisp error: (error "Invalid time zone specification" (nil
> nil nil))
>   encode-time(0 0 12 15 4 2016 (nil nil nil))
>   org-timestamp-change(1 nil updown)
>   org-timestamp-up(1)
>   funcall-interactively(org-timestamp-up 1)
>   call-interactively(org-timestamp-up)
>   org-shiftup(nil)
>   funcall-interactively(org-shiftup nil)
>   call-interactively(org-shiftup nil nil)
>   command-execute(org-shiftup)
> 
> Cheers,
> Derek
> 
> 

Sorry, should have confirmed that before sending the last mail: I get the
same behavior using the older org version from my backup (Org-mode version
8.3.4 / 8.3.4-15-gdd9be3-elpaplus). So this must be an incompatibility
introduced in the emacs core development.

Cheers,
Derek

Re: Problem with org-timestamp-up and timezones

[Robert Eckl]

Derek Feichtinger <dfeich <at> gmail.com> writes:

> 
> Sorry, should have confirmed that before sending the last mail: I get 
the
> same behavior using the older org version from my backup (Org-mode 
version
> 8.3.4 / 8.3.4-15-gdd9be3-elpaplus). So this must be an incompatibility
> introduced in the emacs core development.
> 
The bug seems to be introduced after emacs commit c23c965bb9d0

Cu,
Robert

Re: Problem with org-timestamp-up and timezones

[Derek Feichtinger]

Hi

Robert Eckl <eckl.r <at> gmx.de> writes:

> > 8.3.4 / 8.3.4-15-gdd9be3-elpaplus). So this must be an incompatibility
> > introduced in the emacs core development.
> > 
> The bug seems to be introduced after emacs commit c23c965bb9d0
> 

Thanks for the pointer. I can see that something with the timezones was
changed, but cursorily looking just showed me some changes in the comments.
I only had time now to have a closer look. But I decided to try fix it in
org mode, since this seemed easier.

The problematic statement is in org.el, defun org-timestamp-change, where
the argument list to encode time evaluates to something like

(encode-time 0 0 0 30 11 2013 '(nil nil nil))

i.e. the 7th argument is a list, while the function would be ok with getting
the three nil values not packed into a list. So, just introducing an "apply"
in front fixes this for now.

So from the following code in org-timestamp-change

   ...
      (setq time
	    (encode-time (or (car time0) 0)
	     (+ (if (eq org-ts-what 'minute) n 0) (nth 1 time0))
	     (+ (if (eq org-ts-what 'hour) n 0)   (nth 2 time0))
	     (+ (if (eq org-ts-what 'day) n 0)    (nth 3 time0))
	     (+ (if (eq org-ts-what 'month) n 0)  (nth 4 time0))
	     (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))
	     (nthcdr 6 time0)))
   ...

I just modify to the following

   ...
      (setq time
	    (apply
	     'encode-time (or (car time0) 0)
	     (+ (if (eq org-ts-what 'minute) n 0) (nth 1 time0))
	     (+ (if (eq org-ts-what 'hour) n 0)   (nth 2 time0))
	     (+ (if (eq org-ts-what 'day) n 0)    (nth 3 time0))
	     (+ (if (eq org-ts-what 'month) n 0)  (nth 4 time0))
	     (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))
	     (nthcdr 6 time0)))
   ...


Afterwards the time shifts on the clock lines works fine, again. But I do
not know whether this fixes all cases, or what really is the deeper reason
that this error surfaced right now.

Cheers,
Derek

Re: Problem with org-timestamp-up and timezones

[Nicolas Goaziou]

Hello,

Derek Feichtinger <dfeich@gmail.com> writes:

> The problematic statement is in org.el, defun org-timestamp-change, where
> the argument list to encode time evaluates to something like
>
> (encode-time 0 0 0 30 11 2013 '(nil nil nil))
>
> i.e. the 7th argument is a list, while the function would be ok with getting
> the three nil values not packed into a list. So, just introducing an "apply"
> in front fixes this for now.
>
> So from the following code in org-timestamp-change
>
>    ...
>       (setq time
> 	    (encode-time (or (car time0) 0)
> 	     (+ (if (eq org-ts-what 'minute) n 0) (nth 1 time0))
> 	     (+ (if (eq org-ts-what 'hour) n 0)   (nth 2 time0))
> 	     (+ (if (eq org-ts-what 'day) n 0)    (nth 3 time0))
> 	     (+ (if (eq org-ts-what 'month) n 0)  (nth 4 time0))
> 	     (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))
> 	     (nthcdr 6 time0)))
>    ...
>
> I just modify to the following
>
>    ...
>       (setq time
> 	    (apply
> 	     'encode-time (or (car time0) 0)
> 	     (+ (if (eq org-ts-what 'minute) n 0) (nth 1 time0))
> 	     (+ (if (eq org-ts-what 'hour) n 0)   (nth 2 time0))
> 	     (+ (if (eq org-ts-what 'day) n 0)    (nth 3 time0))
> 	     (+ (if (eq org-ts-what 'month) n 0)  (nth 4 time0))
> 	     (+ (if (eq org-ts-what 'year) n 0)   (nth 5 time0))
> 	     (nthcdr 6 time0)))
>    ...
>
>
> Afterwards the time shifts on the clock lines works fine, again. But I do
> not know whether this fixes all cases, or what really is the deeper reason
> that this error surfaced right now.

This looks correct. Thank you for the investigation. 

This issue is now fixed.


Regards,

-- 
Nicolas Goaziou