emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: aman <aman_yang@163.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ox-publish.el: Handle includes with searches
Date: Wed, 30 Dec 2015 11:28:26 +0000 (UTC)	[thread overview]
Message-ID: <loom.20151230T121820-903@post.gmane.org> (raw)
In-Reply-To: 87oad8nvi0.fsf@nicolasgoaziou.fr

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> 
> Hello,
> 
> aman <aman_yang <at> 163.com> writes:
> 
> > Here's new patch, and hope it helps.
> >
> > org-publish: Fix get 'included-file' logic.
> >
> > * lisp/ox-publish.el (org-publish-cache-file-needs-publishing):
> >   According to the syntax of #+INCLUDE statement in *info* page,
> >   there's no space between search option and file path.
> >   Fix it.
> 
> Thank you. It looks good.
> 
> Have you signed FSF papers already? Otherwise, you need to add
> TINYCHANGE at the end of the commit message.
> 
> Regards,
> 

Oh Sorry. I didn't read contribution guide careful.
This is my first patch to GNU.

Is these words OK?

 org-publish: Fix get `included-file' logic.

 * lisp/ox-publish.el (org-publish-cache-file-needs-publishing):
   According to the syntax of #+INCLUDE statement in *info* page,
   there's no space between search option and file path.
   Make a TINYCHANGE to fix it.

Best Regards

  reply	other threads:[~2015-12-30 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 21:56 [PATCH] lisp/ox-publish.el: Handle includes with searches Nick Gunn
2015-11-23 11:11 ` Nicolas Goaziou
2015-12-29  1:35   ` aman
2015-12-29 21:17     ` Nicolas Goaziou
2015-12-30  6:44       ` aman
2015-12-30  9:20         ` Nicolas Goaziou
2015-12-30 11:28           ` aman [this message]
2015-12-30 23:35             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20151230T121820-903@post.gmane.org \
    --to=aman_yang@163.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).