From mboxrd@z Thu Jan  1 00:00:00 1970
From: Charles Berry <ccberry@ucsd.edu>
Subject: Re: [babel][PATCHES] ob-R patches for review
Date: Thu, 8 May 2014 02:26:28 +0000 (UTC)
Message-ID: <loom.20140508T041255-834@post.gmane.org>
References: <m2fvkw9uha.fsf@krugs.de> <87ppjpm5n5.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33508)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WiE2o-00031J-P1
	for emacs-orgmode@gnu.org; Wed, 07 May 2014 22:26:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WiE2i-0000Z6-HT
	for emacs-orgmode@gnu.org; Wed, 07 May 2014 22:26:46 -0400
Received: from plane.gmane.org ([80.91.229.3]:36808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WiE2i-0000Z2-A2
	for emacs-orgmode@gnu.org; Wed, 07 May 2014 22:26:40 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WiE2g-0005u9-Nu
	for emacs-orgmode@gnu.org; Thu, 08 May 2014 04:26:38 +0200
Received: from 172-7-166-26.lightspeed.sndgca.sbcglobal.net ([172.7.166.26])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 08 May 2014 04:26:38 +0200
Received: from ccberry by 172-7-166-26.lightspeed.sndgca.sbcglobal.net with
	local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 08 May 2014 04:26:38 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Eric Schulte <schulte.eric <at> gmail.com> writes:

> 
> Rainer M Krug <Rainer <at> krugs.de> writes:
> 
> > Hi
> >
> > Attached please find seven patches for review to implement the storing
> > of org variables in their own environment and to make the org-issued R
> > code look nicer in the R session.
> >
> > Thanks,
> >
> > Rainer
> 
> Hi Rainer,
> 
> Thanks for these patches.  I don't have the R experience to review or
> maintain them, but I'm happy to apply them.
> 
> I missed some previous discussion in this thread.  Are these patches
> ready to be applied as is?
>


IMO, the patches hard coded behaviors that would better be customizable
and optional. 

Rainer and I had some back and forth about this -- see the thread.

Best,

Chuck