Agenda buffer: 't' key moves current item to window's top line

Agenda buffer: 't' key moves current item to window's top line

[James Harkins]

After a recent update, I noticed that the agenda buffer now moves the
displayed text when you change an item's TODO state using 't'.

For instance: In a file I'm working on now, C-c a < t shows me:

Global list of TODO items of type: ALL
Available with `N r': (0)[ALL] (1)TODO (2)MAYBE (3)INPROG (4)MTG
(5)POSTPONED (6)DONE
  slides:     INPROG Other dynamics processors
  slides:     TODO Homework

If I put the point on the "Homework" line and press 't', the buffer
jumps so that "Homework" is now the top most visible line. That is,
all I see in the buffer is:

  slides:     MAYBE Homework

The rest of the text is still in the buffer. It just scrolled upward
to be invisible.

I'm certain, in an older revision, this did not happen. The buffer's
displayed position did not move; the only visible change after 't' is
that one item's TODO state. That's clearly more intuitive behavior.

I tried to bisect, but many, many revisions gave me the error (upon
C-u C-c C-x !): "if: Cannot open load file:
/home/dlm/share/org-mode.git/lisp/org-macro.el," so the closest I
could get was:

~~
The first bad commit could be any of:
83bebfd88086688293a06729887eea5852327442
889d671277b3cf0c942078db7aa622e5fdfff1e2
8f49547aaf0f9396f2a0bcfb25ce2c33be5e91fd
467f7ff9b5eb53e9804d71eb7cc331aac9cc36d3
6042e93fa4d8a0cb552549b5b0dc208353c4d459
95375260e5c6b3ff6fa306b6effec9098b1ef37b
ad06a946a59366c48d832dca1df94cdeba38a920
2efbd0f138180fe14773d5485ad3c59332d6ddb3
ac44a7af0629cbc201654807709f4c364fe6ed4d
2b13d090d124fe6a7a389def71696c3b477bf8f6
b6b509bfd458cace38b9cb7e17b18d3f146b0c1a
41882a99d3cf14e4c9ad45559bc3fc9e8b21b581
9a21403bd7d02c5b0d29feab475712ef162e974a
bf5a33a3c09fde5f752515285fe60f1d68f716fc
c30ba6f15690e1a5441ade39203229ff232f6be1
5f47cb2b9f51c8c74f64c0e3f09873a4f10d3302
f8b15da24c1e4a052411ef53a483aadf5752d00e
45d52bfb4c676245658d277526dab4e132028a35
c8c26c8e1968a4b341ae05046f33374ae5b08723
01748861d42af99dd6a4c9b2f98a1991011a30bc
~~

I guess these are the commit messages:

83bebfd8: Use `org-autoload' instead of `autoload'.
889d6712: Fix typo.
8f49547a: Remove top-level autoloads sexps.
467f7ff9: Fix commit b6b509.
6042e93f: org.el (org-map-entries): Fix docstring
95375260: Fix commit 83bebfd8808
ad06a946: datetree: Recognize year headline with tags as a match
2efbd0f1: org.el (org-overview): Stay on current line
ac44a7af: Move `org-at-clock-log-p' from org-clock.el to org.el
2b13d090: org.el (org-imenu-get-tree): Fix bug when matching against
empty headlines
b6b509bf: org.el (org-tsr-regexp-both): Don't activate dates in links
41882a99: Fix a longstanding issue with ellispsis on top of the window
9a21403b: org-agenda.el (org-agenda-to-appt): Fix typos
bf5a33a3: org-agenda.el (org-agenda-local-vars): Don't include
`org-agenda-show-window'
c30ba6f1: contrib/org-toc.el: add forward and back commands
5f47cb2b: Fix commit 41882a99
f8b15da2: org.el (org-set-tags-command): Fix bug.
45d52bfb: fix wrong key for org-reload uncompiled in menu
c8c26c8e: Enhance the fix implemented in 41882a99
01748861: Fix b6b509b again.

Hope that helps.
hjh

Re: Agenda buffer: 't' key moves current item to window's top line

[Bastien]

Hi James,

James Harkins <jamshark70@gmail.com> writes:

> After a recent update, I noticed that the agenda buffer now moves the
> displayed text when you change an item's TODO state using 't'.

Fixed, thanks!

-- 
 Bastien

Re: Agenda buffer: 't' key moves current item to window's top line

[Jeff Kowalski]

Bastien <bzg <at> altern.org> writes:

> 
> Hi James,
> 
> James Harkins <jamshark70 <at> gmail.com> writes:
> 
> > After a recent update, I noticed that the agenda buffer now moves the
> > displayed text when you change an item's TODO state using 't'.
> 
> Fixed, thanks!
> 

I'm still seeing the move-to-top bug, as James stated in OP.
I'm using Org-mode version 7.9.3f (release_7.9.3f-17-g7524ef @ 
/usr/share/emacs/24.3.50/lisp/org/).
Bastien, in which release was it fixed?

Re: Agenda buffer: 't' key moves current item to window's top line

[Jeff Kowalski]

Jeff Kowalski <jeff.kowalski <at> gmail.com> writes:
 
> Bastien <bzg <at> altern.org> writes:
> > Hi James,
> > James Harkins <jamshark70 <at> gmail.com> writes:
> > > After a recent update, I noticed that the agenda buffer now moves the
> > > displayed text when you change an item's TODO state using 't'.
> > Fixed, thanks!

> I'm still seeing the move-to-top bug, as James stated in OP.
> I'm using Org-mode version 7.9.3f (release_7.9.3f-17-g7524ef  <at>  
> /usr/share/emacs/24.3.50/lisp/org/).
> Bastien, in which release was it fixed?

I'll answer my own question - it appears to be fixed by Org-mode version 
8.0.2 (8.0.2-10-g3e1d83-elpa)

Jeff

Re: Agenda buffer: 't' key moves current item to window's top line

[Carsten Dominik]

On 7.5.2013, at 05:20, Jeff Kowalski <jeff.kowalski@gmail.com> wrote:

> Jeff Kowalski <jeff.kowalski <at> gmail.com> writes:
> 
>> Bastien <bzg <at> altern.org> writes:
>>> Hi James,
>>> James Harkins <jamshark70 <at> gmail.com> writes:
>>>> After a recent update, I noticed that the agenda buffer now moves the
>>>> displayed text when you change an item's TODO state using 't'.
>>> Fixed, thanks!
> 
>> I'm still seeing the move-to-top bug, as James stated in OP.
>> I'm using Org-mode version 7.9.3f (release_7.9.3f-17-g7524ef  <at>  
>> /usr/share/emacs/24.3.50/lisp/org/).
>> Bastien, in which release was it fixed?
> 
> I'll answer my own question - it appears to be fixed by Org-mode version 
> 8.0.2 (8.0.2-10-g3e1d83-elpa)

THanks for following up.

- Carsten