From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Gauland Subject: Re: [PATCH] Babel support for scheme using geiser Date: Sat, 5 Jan 2013 18:57:51 +0000 (UTC) Message-ID: References: <50E72B13.70709@no8wireless.co.nz> <87a9snlmhf.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrYwZ-0001Mm-2o for emacs-orgmode@gnu.org; Sat, 05 Jan 2013 13:58:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TrYwX-0004GY-VU for emacs-orgmode@gnu.org; Sat, 05 Jan 2013 13:58:06 -0500 Received: from plane.gmane.org ([80.91.229.3]:44906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrYwX-0004GC-Oc for emacs-orgmode@gnu.org; Sat, 05 Jan 2013 13:58:05 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TrYwk-0006wV-Qc for emacs-orgmode@gnu.org; Sat, 05 Jan 2013 19:58:18 +0100 Received: from 114-134-6-184.rurallink.co.nz ([114.134.6.184]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Jan 2013 19:58:18 +0100 Received: from mikelygee by 114-134-6-184.rurallink.co.nz with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Jan 2013 19:58:18 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien altern.org> writes: > In the meantime, please consider adding a > commit ChangeLog for your patch, Most of the file has changed dramatically--would you like the changelog to list all the functions that have been added or altered, or would a simple statement that the file underwent a major re-write be more appropriate? > ...avoid dangling parentheses, Noted. That's a bad habit I've picked up somewhere (probably too many years of C programming.) > and don't overwrite the first line... we are in 2013 Also noted. Part of my brain refuses to acknowledge the new year until I'm back at work. Regrettably, that won't be a problem after tomorrow. Kind Regards, Mike