From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Sexton <psexton.2a@gmail.com>
Subject: Re: Bug? in the latest revision of org
Date: Fri, 28 Oct 2011 01:59:59 +0000 (UTC)
Message-ID: <loom.20111028T035334-538@post.gmane.org>
References: <CACHMzOFAtAA17GkmW6sQy+5B724UMY9zesuHujmKA=AKnXTQnQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:48050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1RJbk4-0002NN-B0
	for emacs-orgmode@gnu.org; Thu, 27 Oct 2011 22:00:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1RJbk3-0002aM-Bi
	for emacs-orgmode@gnu.org; Thu, 27 Oct 2011 22:00:20 -0400
Received: from lo.gmane.org ([80.91.229.12]:37288)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1RJbk3-0002a6-2l
	for emacs-orgmode@gnu.org; Thu, 27 Oct 2011 22:00:19 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1RJbjv-0000Fy-4t
	for emacs-orgmode@gnu.org; Fri, 28 Oct 2011 04:00:16 +0200
Received: from rp.young.med.auckland.ac.nz ([130.216.140.20])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Fri, 28 Oct 2011 04:00:11 +0200
Received: from psexton.2a by rp.young.med.auckland.ac.nz with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Fri, 28 Oct 2011 04:00:11 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Marcelo de Moraes Serpa <celoserpa <at> gmail.com> writes:

> 
> Hey list,Just updated to the latest rev. of org in git. When I try to press 
<ret> just in the beginning of a headline in order to move it one line below, 
I'm getting this error message:: Wrong type argument: listp, org-level-1Any 
ideas?Marcelo.

Yes, it's a bug - I was just about to post about it myself.

The problem is in the recent change to the 'org-return' function in org.el.
(commit de8cd8ee41543bb0548af1cdc7fa7a8168321677 on 26 Oct).

The original code was:

   ((and org-return-follows-link
	 (eq (get-text-property (point) 'face) 'org-link))

The commit changed it to:

   ((and org-return-follows-link
	 (or (eq (get-text-property (point) 'face) 'org-link)
	     (memq 'org-link (get-text-property (point) 'face))))

But this breaks if there is a single face at point that is not org-link, 
because in that case the text property at point will not be a list, 
and this will cause an error when it is given as the second argument 
to memq.

The code needs to change to something like:

   ((and org-return-follows-link
         (let ((tprop (get-text-property (point) 'face)))
	   (or (eq tprop 'org-link)
	       (and (listp tprop) (memq 'org-link tprop)))))

Paul.