From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eNZEA9bwH2PBLgEAbAwnHQ (envelope-from ) for ; Tue, 13 Sep 2022 04:54:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aLVDA9bwH2OU0wAA9RJhRA (envelope-from ) for ; Tue, 13 Sep 2022 04:54:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57AA5277A1 for ; Tue, 13 Sep 2022 04:54:13 +0200 (CEST) Received: from localhost ([::1]:50308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXw3s-0002S3-Rr for larch@yhetil.org; Mon, 12 Sep 2022 22:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXw3B-0002Ru-SL for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 22:53:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXw38-0003AA-Vl for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 22:53:24 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D076D10010E; Mon, 12 Sep 2022 22:53:19 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 586181000C4; Mon, 12 Sep 2022 22:53:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663037598; bh=XAp7t2W+PFEKhD+fHPiFLWQzbEpU6LOXdQzUXf5mXBI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FO35DTC/w5p5Ugkw6aZO7MQt4kQPtNXyYeemXw9o4Em+bsMqS6vWq1g9lGZHNun1M LFC0Q4cCiWlZYDqAQq5IyMe75O2Dq1OuZVj+VSgDLCO/dsgKz5KU0qJkg3KTO5lSL5 TiUjgiPbL3gy09Ewuwv9LvaFRALLuqXaYCxRO915lx0EnWYPaCQ1VDc8+0imatvZ/i pT16e8+eN2G0m7g8RTt0deq3Enb81QCVEeHR+89CwyxXOMthakVgCTaQV81nvD5mIs b3gd7GIPXs67cz2yr4xlBRNnSTONaMNHXgXRjNafB5IGumVogYg0C1w8qj40XywzVV 3skDV9FPOUWGg== Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1996B1201C6; Mon, 12 Sep 2022 22:53:18 -0400 (EDT) From: Stefan Monnier To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful In-Reply-To: <875yhsujkq.fsf@localhost> (Ihor Radchenko's message of "Tue, 13 Sep 2022 09:52:37 +0800") Message-ID: References: <875yhsujkq.fsf@localhost> Date: Mon, 12 Sep 2022 22:53:16 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663037653; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=yCdw2EvvdV+9Oz75xz0xzzZEpheJneHOFDUsrFDUA2A=; b=DwEh1WRDaKyRTqKex4ribJSPIF9gXdTB0g/TvX235VyvTaq2nhpSfSYo47M6zGGA2fJ6Bi u3uHRbamDTMKTaOUo9KkGuXkmqC1e2b7TED6Tbcrt1VD7zzFPE9SoV5WHjVDtC06dP3M26 EZStnDjyijwaa7gYKlKbJOYrVdryzg321K3E3QAU13cw/GhI5ZEe/r0CQif4n/XZacTgLQ ElzX/6nxME6rksSpH2p9QgzkV5VTksIkvDv3DsP4Pw2KWKVfkxpEyA8GVYHwpEG47cw037 Kqi1yft7kz1vS5pnrzQht8pS2ccULkCmaLitTizidY++ER02EaoN4AI7gr2idA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663037653; a=rsa-sha256; cv=none; b=St6wUt+veFF7G+6wIusH7MX767RMlVfhkyCd+06jWSu6r/2beu4FNYurmZer0hreMVZCC8 JZwBIeTbgg7/+TGNDbkgwDH/EhAcSjrH7M60gw14HlLb6utMZA5nFVawQjwmHJtdVNX0dA agIoDorJ8CspzT1JJjftXAwY+/AK97lKOfSV9GHyfjnY6ZjdVzxubJRK8jDUkkF/g78tgM 2QrDpmL+LS2U0mmSYhUk9FWdSqZD3HKPUQHPvnwCzNbPprqlNtW9sMHrTHEA6i9AthtfOa kIguFf5vjaAxiw36u4r/+NKCX4akDIM+6gV1BsKaHc6HcVUznP2vPCkp7GT+tQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b="FO35DTC/"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b="FO35DTC/"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 57AA5277A1 X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: QOUP3HmKAwJx Ihor Radchenko [2022-09-13 09:52:37] wrote: > Stefan Monnier writes: >> I can see the reason for this macro, and I don't really have a better >> solution to offer, but as someone who has a Git clone of Org that is >> regularly updated&compiled using (basically) the normal compilation >> system used in Emacs (i.e. not systematically recompiling all the files, >> but only those whose `.el` is more recent than their `.elc`), it means >> that whenever Org's version changes, I have to manually erase all the >> `.elc` files otherwise this macro will (incorrectly) >> complain everywhere :-( > Does it help if you run make autoloads after git fetch? Not that I can tell, no. But note that I'm not using Org's makefile to compile the files, I'm using the elpa.git scripts instead, which don't take into account dependencies between files. So the situation is simply something like: - git pull =3D> switches to 9.5.5, but several .el files are left unchang= ed. - make autoloads =3D> this refreshes the autoloads, but the .elc files of those .el files which didn't change still won't be recompiled. I'm not really reporting a bug; I'm not sure how to solve the problem without throwing away the benefits of `org-assert-version`. But I just wanted to mention that it has unintended side effects :-) Stefan PS: BTW, I notice that when Org is installed as a normal `package.el` package, in Emacs=E2=89=A528 it will be activated before the `.emacs` f= ile is loaded, which should prevent occurrence of the problems that `org-assert-version` aims to catch (unless you use, say, an org-babel file for the `early-init.el` :-) PPS: Maybe instead of calling `org-assert-version` everywhere, the `org-autoloads.el` (i.e. the file that sets up the `load-path` and the autoloads) could look for traces of Org files in the `load-history` and signal an error if such files are found coming from a different directory.