From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YOQLKIIcImNOxAAAbAwnHQ (envelope-from ) for ; Wed, 14 Sep 2022 20:25:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4Bf5J4IcImOtBgEA9RJhRA (envelope-from ) for ; Wed, 14 Sep 2022 20:25:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3917B83C for ; Wed, 14 Sep 2022 20:25:05 +0200 (CEST) Received: from localhost ([::1]:58094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYX4L-0003nN-3X for larch@yhetil.org; Wed, 14 Sep 2022 14:25:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYX3V-0003mW-Ty for emacs-orgmode@gnu.org; Wed, 14 Sep 2022 14:24:14 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYX3T-0003sJ-4p for emacs-orgmode@gnu.org; Wed, 14 Sep 2022 14:24:12 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8A366100129; Wed, 14 Sep 2022 14:24:08 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 928361000FF; Wed, 14 Sep 2022 14:24:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663179845; bh=hqhPX4Syiy2Z8+ljuKH+G42KLfTX6g1nnQIKI5Rzfn8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NtCCQDGQzMvSyDrzxkRxEh0aG3R5gIX6XNIFCb92twt+h0OLPRc4Hn9Shnvof/8FB b7LqqCbs5CRdn2zzawKMxFjQ/KH/TxMqKWktA5xyYROEk9jYHZqbgmtZ3TGKqrcy1h 3cOr9oPMyuPteNTIp+T+RkKmTqEc05N2jwHE5mYhkI737KDmc/wj9li3cW/eaECJYK +ZweX9BiQ9pCm+nmi5o8Yv08MLdTm2JbnMfe2/XzBMf0KauwCMA4xaCoqYLPLq+xdU k3r3Dv9M/nnTBN46SQ3gkFpgGpia9+WWZ/A+Q/xWZtmkDeBeTPC3umMkIXvM0cg0PG Jr0LxBJbazQGQ== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 76308120962; Wed, 14 Sep 2022 14:24:05 -0400 (EDT) From: Stefan Monnier To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: Use lexical-scoping in tests In-Reply-To: <87illqxhje.fsf@localhost> (Ihor Radchenko's message of "Wed, 14 Sep 2022 20:32:53 +0800") Message-ID: References: <87illqxhje.fsf@localhost> Date: Wed, 14 Sep 2022 14:23:59 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663179906; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O4uIxhM3S8Jz9aWrawh2gfkdWtbEQom1g6Ph8Cyoub0=; b=DznjohHKakmAj7MICCwHCiI9msS9koLiNI6NQWQCYYGXnMVjUHzsUlJy0UJTONLqzhNwXG HOQxkCVAgFizSSqLjWRI4584zY64ncKPwM3bsNP6XWHzz/Ta8l7nQ7KxQOPBG75FGbptNQ iO+4favg6cRXSLpTvIMHaTL9j9fyup9ZI56cAgJcfVv8zAtLTqZrFVjpvplsDHAWMQ3ePX NrDpv+Ihc2W1roXF8Y9YoNKSfA4HS7HPpEdB6UV1n5rsh+5BbwTc1tqZXTmmKXjSrwirOJ wHghTi8mBHkGkxVlQByvTGlWfdic/nIo7m1U9CiBB/iG9IJRFTThLyKc1cHsCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663179906; a=rsa-sha256; cv=none; b=sLhHLzdeE5pKbzDfnrePWRog5Fu3HbIG66sDVH2UUKuU5qf98G4J3kqj9RQm9wT90HOEii WeHGUEX6bsSGYe4I9ah0co7Jht+NmSg5p0M7uLe38Ar80+V9ZLb41t0SAGlsuRFomW2dmX 8982QQxd2jFOg+y5Lk2priFwJAoIN2bIwayr8OWTvHJG73tY8u6ID3dAuZpndsW0ttUtEu yrIsCLxdHbKuHB2+MyaA+qJ6wK2QyP6ISYDlZqBXXHLytaMde2l5E5R976kXpRb0Kcq8HW 0hpdmbStB45vUxI2FZFLyRbE1yKC18buuGjTTsxV22dKsZ4hbRXQAUCbUJEi4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=NtCCQDGQ; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.82 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=NtCCQDGQ; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E3917B83C X-Spam-Score: -6.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: MEbhc8FvW06M Ihor Radchenko [2022-09-14 20:32:53] wrote: > Stefan Monnier writes: >> The patch below simply enables `lexical-binding` in all the test files. >> As far as I can tell, it's all that's needed (beside a missing >> `require`). > Thanks, but the patch causes 23 tests to fail (running make test). Oh, lord! The fix is in preparation, but obviously I had tested my patch incorrectly (i.e. I probably compiled and tested another code than the one I had patched). [ At least it explains why I was seeing this weird "it's all that's needed", which I always hope for but is so rarely true. ] > Also, is there any reason why it was a plain diff? Lack of inspiration, mostly. Stefan