From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Monnier Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Tue, 02 Apr 2019 07:08:16 -0400 Message-ID: References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:33308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBHHB-0000wb-9U for emacs-orgmode@gnu.org; Tue, 02 Apr 2019 07:08:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBHHA-0004u8-G4 for emacs-orgmode@gnu.org; Tue, 02 Apr 2019 07:08:21 -0400 In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "Basil L. Contovounesios" Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org > Now that add-function sets indent-line-function to a custom closure, > however, (advice--cd*r indent-line-function) no longer returns > indent-relative and the workaround breaks. I think this qualifies as a problem in nadvice: the ad-hoc closure introduced to "redirect to the default-value" should be handled by advice--cd*r (or rather by some new function which can then be used instead of advice--cd*r). Stefan