From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id fTRPEk5uiWB7uwAAgWs5BA (envelope-from ) for ; Wed, 28 Apr 2021 16:16:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OMXcDE5uiWA6cgAAB5/wlQ (envelope-from ) for ; Wed, 28 Apr 2021 14:16:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2723D2686B for ; Wed, 28 Apr 2021 16:16:45 +0200 (CEST) Received: from localhost ([::1]:33990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbkza-0005BK-9F for larch@yhetil.org; Wed, 28 Apr 2021 10:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbkyx-00055p-4w for emacs-orgmode@gnu.org; Wed, 28 Apr 2021 10:16:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbkyu-0002eU-HD for emacs-orgmode@gnu.org; Wed, 28 Apr 2021 10:16:02 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9D87C44102F; Wed, 28 Apr 2021 10:15:59 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5AF5744101D; Wed, 28 Apr 2021 10:15:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619619358; bh=y3S9nyi/7EnsDfBeeamkxyiig3BGXrU3iU31JhYrudk=; h=From:To:Subject:References:Date:In-Reply-To:From; b=bWV3r3cBGEyTrIjYPD8hpm1tNpup6eycu53w+nA8ZxP335veCkNCWE3WQXBU/kZix ytlQOKcfWusgAfGYJl0qmcpN9jgMcv3SacHNXb2GG6NeL51Q5t1vWCKQocCReSNo5D jvvZsaoKbKTUdeWLsPAKn4HeJQkcopDdPB9/w7/GtvVKxJgYQoADmIQNzSwEFlJWNI wNKnDUaB43JQduKBTXVUSPh1nLl50HpAFbYh9vDjWTiAILsFiRW1uE/ff9H8NJ2rFs x8KlCi5izmd0i+x6/OqFCEqx3OD9OUeahVrXRXSej0NF+4hxMs5kZupiC7XIgILJW/ wAqxY+xrKjDuw== Received: from alfajor (unknown [157.52.10.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 376DF12020A; Wed, 28 Apr 2021 10:15:58 -0400 (EDT) From: Stefan Monnier To: emacs-orgmode@gnu.org Subject: Re: More use of lexical-binding in ox.el Message-ID: References: <87wnsnig8h.fsf@nicolasgoaziou.fr> <87lf92x0f9.fsf@nicolasgoaziou.fr> Date: Wed, 28 Apr 2021 10:15:57 -0400 In-Reply-To: <87lf92x0f9.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 28 Apr 2021 10:45:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619619405; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ovd2y3EsSulESnokz0fEX3g5ByYus+4y1PSRY20ucCA=; b=FMAAwa2tRBDzsr1Hu6fWOX44Jk6DFGAJfAc/N+izCAB/Ul7dRrPF4KBOOxMZrRd9QgGUVR FI1Z1lWv15tA/04CK5ZiiaMnGOR7LNBjjc2eW/khmLhfeNe9vq03I21xOXGXnAoIL2ClJq cL7PlQ0Sy272FpSrPWOStgJ4IlHHbE0xXFY+6ScAzvJmd6/rg194MlHK1RC4Vc7SrQQC3d tZ6J/c3zulGN8oUIdkWeve2R9XuXo7MpRayTwjVPtrm5Svyo68K9hc5kgzLEZ67fZTQ5EG lQ+042/g54WDZK0WaKKxIBclYFTZnUHeUXvRj3rDdLmLbrbLQ90mN68pNbeWNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619619405; a=rsa-sha256; cv=none; b=Uao0+SfMyc8VCaG42g7VfIfc4KbVmb7F3p60Rka5BuAgjRrcmnBzRVUxXHmTpq5YlssMnU QaQ7iGECvjHoMuqGaOHJ01ah9UdqLthg2dZlu0KeTyWPtNGx3UqOafgndTSBSeiNuOjW9Y ord0FwhWcPUgH5bR0T/yA0jZjK8rxXV+uX/oa5m6yTByGZ8L07ivKk9VLSTFfp1HZMezG7 t068sB/4Tgf4rNzkpKNXcrCMF2fcTyVHtbCN5OefpYru9JqqTrKkGLVurUaYOly0Ndwi5T a6GS+QOVZ2B/QnS898PeecnW/qPOOcvclWiOnYbOY+R08ZnqvQds3TNXfZuh+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=bWV3r3cB; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=bWV3r3cB; dmarc=pass (policy=none) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 2723D2686B X-Spam-Score: -2.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: kBq9InlZ2Huk >> Yes: >> >> (push (cons var val) varvals)))) >> varvals))) >> >> should be >> >> (push (cons var val) varvals))))) >> varvals)) >> >> so that the final `varvals` is outside the `dolist` (it's the thing we >> want to return to store it in the outer `varvals` variable). > > Indeed. I couldn't spot this. Yes, I tried to make it discrete. Sadly, your test suite wasn't fooled, Stefan