From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WKz8DVPXNWCwYgAA0tVLHw (envelope-from ) for ; Wed, 24 Feb 2021 04:34:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0HOyCVPXNWD5LQAAbx9fmQ (envelope-from ) for ; Wed, 24 Feb 2021 04:34:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 661AB2937B for ; Wed, 24 Feb 2021 05:34:26 +0100 (CET) Received: from localhost ([::1]:40882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lElsX-0007qq-8t for larch@yhetil.org; Tue, 23 Feb 2021 23:34:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEls4-0007qc-5k for emacs-orgmode@gnu.org; Tue, 23 Feb 2021 23:33:57 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEls0-0003Y2-Az for emacs-orgmode@gnu.org; Tue, 23 Feb 2021 23:33:55 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A32BD441668; Tue, 23 Feb 2021 23:33:49 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 614F1441665; Tue, 23 Feb 2021 23:33:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614141228; bh=3r4dCHOy8Jl4hP+o2Tcxp6944T2q7ffRe/DWdYp3cik=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Z9sKtHUQ8qNphMZPpd1WlU2JkNFOow4L+gmJ+rG7l+UTJ4XqxZDzsC8A/cX4RVVRR nFyiKR95ZxntV36wDSOQkrbBa1+BgG2CeDvF8O6gG9G7wwnqJOjl0D3Mm6a74Z8iZu 2cimlGSHCwkujSKSmDzYR9UvcCnnSbXaLs26SYtaMKJsXI+ToBNTb4wWVGAH1CLdEr Qx9xnYU2fOkfduIDak+KXIOidh00wp9DmBk+pwOkmgtjmG/iEJtRSSq6WzSAvFrIrt As3xSLnidPBR607gmzflVXE8yhF3BX4iGxiw+MxgP+nGM0seXRc0prGxqWPEYk17xn ngpItlyNjxcbw== Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8720112027A; Tue, 23 Feb 2021 23:33:48 -0500 (EST) From: Stefan Monnier To: Kyle Meyer Subject: Re: Using lexical-binding Message-ID: References: <87k0qywbtb.fsf@kyleam.com> Date: Tue, 23 Feb 2021 23:33:47 -0500 In-Reply-To: <87k0qywbtb.fsf@kyleam.com> (Kyle Meyer's message of "Tue, 23 Feb 2021 19:26:24 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=Z9sKtHUQ; dmarc=pass (policy=none) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 661AB2937B X-Spam-Score: -3.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5hHC0xb67r66 > With a quick test of a few main commands, burps in one of four. Excellent, and thanks for the subsequent patch (I don't think I'd have come up with the move of `extra` on my own). >> - I believe I have quashed all the compiler warnings (some had nothing >> to do with lexical scoping), > > Hmm, I wonder why I'm not seeing the ones unrelated to the lexical > scoping change. I don't think there were many of them. As for why there were some: 1- the change away from `org-let` and friends causes some code to become visible to the compiler (it was hidden behind the "eval wall" until then). 2- I have some extra warnings in my local Emacs. >> except for a reference to the function `add-to-diary-list` which I >> can't find anywhere (is it some old function that has disappeared, >> maybe?). > > It looks like add-to-diary-list became an obsolete alias for > diary-add-to-list in Emacs 23.1 and was removed in Emacs 25.1, > specifically 3f65970414 (Remove calendar code obsolete since at least > version 23.1, 2014-10-05). Ah, thanks for tracking it down, so I guess we can drop this altogether. And we can also drop the `condition-case` in `org-diary-default-entry` because that change in calling convention is even older than the change of name from `add-to-diary-list` to `diary-add-to-list`. Stefan