From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Re: Completing with anything
Date: Wed, 04 May 2011 12:07:23 -0300
Message-ID: <jwv8vumv7bm.fsf-monnier+emacs@gnu.org>
References: <87r5bhysp6.fsf@keller.adm.naquadah.org>
	<m1wrl8c5ix.fsf@94.197.191.21.threembb.co.uk>
	<878vxovsym.fsf@keller.adm.naquadah.org>
	<87k4h7ua23.fsf@member.fsf.org>
	<87vd0romky.fsf@keller.adm.naquadah.org>
	<jwv4o8bvjn1.fsf-monnier+emacs@gnu.org>
	<87mxm2na63.fsf@member.fsf.org>
	<jwv8vxmr5vp.fsf-monnier+emacs@gnu.org>
	<87vd0qfhu3.fsf@member.fsf.org>
	<jwvlj1mp41j.fsf-monnier+emacs@gnu.org>
	<sa3ipvg8oe5.fsf_-_@cigue.easter-eggs.fr>
	<jwv62rgguvg.fsf-monnier+emacs@gnu.org>
	<sa362rcg1k2.fsf@cigue.easter-eggs.fr>
	<jwvaago1q4p.fsf-monnier+emacs@gnu.org>
	<sa3y648bh9p.fsf@cigue.easter-eggs.fr>
	<87y63jpii5.fsf@keller.adm.naquadah.org>
	<jwv39lq69dv.fsf-monnier+emacs@gnu.org>
	<sa3aafx2lf9.fsf@cigue.easter-eggs.fr>
	<jwvwrj0ywdc.fsf-monnier+emacs@gnu.org>
	<sa3wrizpzpi.fsf@cigue.easter-eggs.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
In-Reply-To: <sa3wrizpzpi.fsf@cigue.easter-eggs.fr> (Julien Danjou's message
	of "Tue, 12 Apr 2011 11:48:41 +0200")
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org
List-Id: emacs-orgmode.gnu.org

>> Hmm... good point, doing it in completion-choices is not reliable, tho
>> using as completion table something like:
>> 
>> (lambda (string pred action)
>> (let ((res (complete-with-action action completion-choices string pred)))
>> (if (and (eq action nil)
>> (assq (if (eq res t) string res) <expansion-alist>))
>> (cdr (assq (if (eq res t) string res) <expansion-alist>))
>> res)))
>> 
>> should work OK for prefix completion, but that means using the expansion
>> "by hand" rather than via expand-abbrev, which may not be an option.

> Yeah. That does not looks like a simple/good option.
> As it stands, I guess the bbdb solution to return a function doing the
> replacement rather than trying to return a list and conform with the
> (current) way of doing completion is really simpler, unfortunately. :(

While taking a look at adding the necessary functionality to
minibuffer.el, I bumped into a problem:

If you complete "ni" to "nic" which is a valid alias and you also have
a "nicolas" alias, running expand-abbrev after the completion may not be
right since it will prevent you from getting to "nicolas".

Now, this is a minor problem.  But the more general case is when the
user has set completion-cycle-threshold so that completion happened via
cycling: the string after completion is a valid abbrev (presumably) but
calling expand-abbrev on it will interfere with the cycling in a big way
(the details of what will happen depend on the way cycling is
implemented and what kind of abbrevs we're talking about).

So at least cycling-completion seems fundamentally incompatible with
this idea of abbrev-expansion-after-completion, at least if you want to
allow arbitrarily complex abbrevs like skeletons.

Could you give me an idea of what kind of abbrevs the code should try
to accommodate?


        Stefan