From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Egli Subject: Re: Sorting by todo-keyword Date: Thu, 14 Aug 2008 16:38:00 +0200 Message-ID: References: <87r6939ucf.wl%jan.seeger@thenybble.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTdxt-0000Wi-4h for emacs-orgmode@gnu.org; Thu, 14 Aug 2008 10:38:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTdxs-0000WV-B7 for emacs-orgmode@gnu.org; Thu, 14 Aug 2008 10:38:12 -0400 Received: from [199.232.76.173] (port=46592 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTdxs-0000WS-67 for emacs-orgmode@gnu.org; Thu, 14 Aug 2008 10:38:12 -0400 Received: from main.gmane.org ([80.91.229.2]:57829 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTdxr-00033k-K4 for emacs-orgmode@gnu.org; Thu, 14 Aug 2008 10:38:12 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KTdxq-0004tF-1Y for emacs-orgmode@gnu.org; Thu, 14 Aug 2008 14:38:10 +0000 Received: from d05.sbszh.ch ([217.192.14.190]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 14 Aug 2008 14:38:10 +0000 Received: from christian.egli by d05.sbszh.ch with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 14 Aug 2008 14:38:10 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Manish writes: > I tried applying the patch to 5.18a but it failed again. How can I > help get more debug information? > > ,---- > | lappy:~/elisp/org-mode.git $ git checkout -b release_5.18a release_5.18a > | Checking out files: 100% (112/112), done. > | Switched to a new branch "release_5.18a" > | lappy:~/elisp/org-mode.git $ git branch > | master > | * release_5.18a > | zms > | lappy:~/elisp/org-mode.git $ git-apply.exe 5066-001.bin > | error: patch failed: org.el:2679 > | error: org.el: patch does not apply > `---- Yes, I know, I tried myself. The problem is most likely that Carsten rearranged the source code substantially. My patch was for org.el but the changes should now probably be applied to lisp/org-agenda.el. I don't know git well enough to judge if there is an automated way to bring this patch back to life. The only way I see ATM is to manually port it to the current version of org. Basically the patch is (was) fairly simple: * add a function org-cmp-todo-state along the lines of org-cmp-* which compares todo states. * add this function to org-entries-lessp * adapt the various functions that are invoked by org-finalize-agenda-entries (org-agenda-get-todos, org-agenda-get-scheduled, etc) to include the todo state in the properties of the text for the agenda line. You can probably get some inspiration from my old patch. HTH Christian