Re: Sorting by todo-keyword

[Christian Egli <christian.egli@sbszh.ch>]

Manish <mailtomanish.sharma@gmail.com> writes:

> I tried applying the patch to 5.18a but it failed again.  How can I
> help get more debug information?
>
> ,----
> | lappy:~/elisp/org-mode.git $ git checkout -b release_5.18a release_5.18a
> | Checking out files: 100% (112/112), done.
> | Switched to a new branch "release_5.18a"
> | lappy:~/elisp/org-mode.git $ git branch
> |   master
> | * release_5.18a
> |   zms
> | lappy:~/elisp/org-mode.git $ git-apply.exe 5066-001.bin
> | error: patch failed: org.el:2679
> | error: org.el: patch does not apply
> `----

Yes, I know, I tried myself. The problem is most likely that Carsten
rearranged the source code substantially. My patch was for org.el but
the changes should now probably be applied to lisp/org-agenda.el.

I don't know git well enough to judge if there is an automated way to
bring this patch back to life. The only way I see ATM is to manually
port it to the current version of org.

Basically the patch is (was) fairly simple:

* add a function org-cmp-todo-state along the lines of org-cmp-* which
  compares todo states.

* add this function to org-entries-lessp

* adapt the various functions that are invoked by
  org-finalize-agenda-entries (org-agenda-get-todos,
  org-agenda-get-scheduled, etc) to include the todo state in the
  properties of the text for the agenda line. You can probably get
  some inspiration from my old patch. 

HTH
Christian