From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christos Chryssochoidis Subject: Possible bug? Date: Fri, 30 Apr 2010 15:21:03 +0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7pDn-0002jn-TN for emacs-orgmode@gnu.org; Fri, 30 Apr 2010 08:21:31 -0400 Received: from [140.186.70.92] (port=58714 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7pDj-0002jV-Pk for emacs-orgmode@gnu.org; Fri, 30 Apr 2010 08:21:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7pDh-00018g-59 for emacs-orgmode@gnu.org; Fri, 30 Apr 2010 08:21:27 -0400 Received: from mail-pz0-f198.google.com ([209.85.222.198]:57294) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7pDh-000188-01 for emacs-orgmode@gnu.org; Fri, 30 Apr 2010 08:21:25 -0400 Received: by pzk36 with SMTP id 36so103517pzk.24 for ; Fri, 30 Apr 2010 05:21:23 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, I wanted to ask about a behavior that doesn't seem right to me, if it's indeed a bug or rather some misunderstanding of mine. Trying to update the effort time of a task with C-c C-x C-e, and using the syntax +HH:MM, I've found that instead of augmenting the effort time by that amount of time, org-mode just set the effort time to that amount; not relatively to the old effort time, but absolutely as if the sign (+/-) didn't exist. I modified just one line in org-clock.el and now it seems to work as I expected. My modification follows below. Thanks to all developers of org-mode! diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 07c1083..535dcab 100755 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -500,7 +500,7 @@ the mode line." ;; A string. See if it is a delta (setq sign (string-to-char value)) (if (member sign '(?- ?+)) - (setq current (org-hh:mm-string-to-minutes (substring current 1))) + (setq current (org-hh:mm-string-to-minutes current)) (setq current 0)) (setq value (org-hh:mm-string-to-minutes value)) (if (equal ?- sign)