2nd org-done when invoked from Agenda bug

2nd org-done when invoked from Agenda bug

[max]

$ cat ~/org-bug.el

(add-to-list 'load-path "~/org-5.04")
(require 'org)
(add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode))
(setq org-agenda-files '("~/test.org"))
(setq org-log-done t)

$ cat ~/test.org

* Not used								:bleah:
** TODO one
** TODO two

$ emacs --no-init-file
M-x load-file ~/org-bug.el RET  ;; set up the test case
M-x org-agenda RET              ;; run agenda command
t                               ;; press t key to display list of todos
                                ;; the following buffer is displayemwd
-----------------------------------------------------
Global list of TODO items of type: ALL
Available with `N r': (0)ALL (1)TODO (2)DONE
  test:       TODO one
  test:       TODO two
-----------------------------------------------------
press <down> twice ;; cursor is on first TODO
press t            ;; TODO changes to DONE
press <down>       ;; cursor is on the 2nd TODO
press t            ;; Agenda buffer changes to this
-----------------------------------------------------
Global list of TODO items of type: ALL
Available with `N r': (0)ALL (1)TODO (2)DONE
  test:       DONE one
  test:       one
-----------------------------------------------------

And the 2nd TODO is not marked as DONE but remains unchanged
in the ~/test.org buffer.

Does not happen if org-log-done is not set.

Regards,
  Max

Re: 2nd org-done when invoked from Agenda bug

[Carsten Dominik]

I cannot reproduce this bug.  Anyone?

- Carsten

On Aug 3, 2007, at 23:17, max@openchat.com wrote:

> $ cat ~/org-bug.el
>
> (add-to-list 'load-path "~/org-5.04")
> (require 'org)
> (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode))
> (setq org-agenda-files '("~/test.org"))
> (setq org-log-done t)
>
> $ cat ~/test.org
>
> * Not used								:bleah:
> ** TODO one
> ** TODO two
>
> $ emacs --no-init-file
> M-x load-file ~/org-bug.el RET  ;; set up the test case
> M-x org-agenda RET              ;; run agenda command
> t                               ;; press t key to display list of todos
>                                 ;; the following buffer is displayemwd
> -----------------------------------------------------
> Global list of TODO items of type: ALL
> Available with `N r': (0)ALL (1)TODO (2)DONE
>   test:       TODO one
>   test:       TODO two
> -----------------------------------------------------
> press <down> twice ;; cursor is on first TODO
> press t            ;; TODO changes to DONE
> press <down>       ;; cursor is on the 2nd TODO
> press t            ;; Agenda buffer changes to this
> -----------------------------------------------------
> Global list of TODO items of type: ALL
> Available with `N r': (0)ALL (1)TODO (2)DONE
>   test:       DONE one
>   test:       one
> -----------------------------------------------------
>
> And the 2nd TODO is not marked as DONE but remains unchanged
> in the ~/test.org buffer.
>
> Does not happen if org-log-done is not set.
>
> Regards,
>   Max
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

Re: 2nd org-done when invoked from Agenda bug

[Max Mikhanosha]

At Thu, 9 Aug 2007 07:05:55 +0200, Carsten
Dominik wrote:
> 
> I cannot reproduce this bug.  Anyone?
> 
Its easy to reproduce, are you sure you doing it with org-log-done set
to 't?

Here is my understanding of the bug after debugging it a bit, please
correct me if I'm wrong: when agenda buffer is constructed, for each
item in the agenda buffer it remembers a position back into the
original org buffer. These positions are used for example in follow
mode triggered by pressing F key.

When org buffer contains 2 TODOs like so:

** TODO one
** TODO two

If one uses F follow mode in agenda, then as you move cursor in agenda
buffer, the correct TODO line in the org buffer is highlighted.

Now press T to mark 1st TODO DONE. It inserts a line into original org
buffer like so:

** TODO one
  CLOSED: <whatever>
** TODO two

Now the F follow mode highlights the CLOSED line instead of the "TODO
two" line when cursor is on the 2nd TODO in the agenda
buffer. Basically it highlights the same line where the 2nd TODO
_used_ to be, if the CLOSED line was not inserted.

I can 100% reproduce this with either my own multi-tty emacs compile,
or with the stock emacs that comes with suse 10.2, with only org.el
loaded and with --no-init-file

Regards,
  Max

> - Carsten
> 
> On Aug 3, 2007, at 23:17, max@openchat.com wrote:
> 
> > $ cat ~/org-bug.el
> >
> > (add-to-list 'load-path "~/org-5.04")
> > (require 'org)
> > (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode))
> > (setq org-agenda-files '("~/test.org"))
> > (setq org-log-done t)
> >
> > $ cat ~/test.org
> >
> > * Not used								:bleah:
> > ** TODO one
> > ** TODO two
> >
> > $ emacs --no-init-file
> > M-x load-file ~/org-bug.el RET  ;; set up the test case
> > M-x org-agenda RET              ;; run agenda command
> > t                               ;; press t key to display list of todos
> >                                 ;; the following buffer is displayemwd
> > -----------------------------------------------------
> > Global list of TODO items of type: ALL
> > Available with `N r': (0)ALL (1)TODO (2)DONE
> >   test:       TODO one
> >   test:       TODO two
> > -----------------------------------------------------
> > press <down> twice ;; cursor is on first TODO
> > press t            ;; TODO changes to DONE
> > press <down>       ;; cursor is on the 2nd TODO
> > press t            ;; Agenda buffer changes to this
> > -----------------------------------------------------
> > Global list of TODO items of type: ALL
> > Available with `N r': (0)ALL (1)TODO (2)DONE
> >   test:       DONE one
> >   test:       one
> > -----------------------------------------------------
> >
> > And the 2nd TODO is not marked as DONE but remains unchanged
> > in the ~/test.org buffer.
> >
> > Does not happen if org-log-done is not set.
> >
> > Regards,
> >   Max
> >
> >
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> >
> >
> 
> --
> Carsten Dominik
> Sterrenkundig Instituut "Anton Pannekoek"
> Universiteit van Amsterdam
> Kruislaan 403
> NL-1098SJ Amsterdam
> phone: +31 20 525 7477
> 

Re: 2nd org-done when invoked from Agenda bug

[Carsten Dominik]

On Aug 12, 2007, at 6:57, Max Mikhanosha wrote:

> At Thu, 9 Aug 2007 07:05:55 +0200, Carsten
> Dominik wrote:
>>
>> I cannot reproduce this bug.  Anyone?
>>
> Its easy to reproduce, are you sure you doing it with org-log-done set
> to 't?

Yes, I forgot this.  Now I can reproduce it.  THe bug is fixed for the
next version, thanks.

- Carsten

>
> Here is my understanding of the bug after debugging it a bit, please
> correct me if I'm wrong: when agenda buffer is constructed, for each
> item in the agenda buffer it remembers a position back into the
> original org buffer. These positions are used for example in follow
> mode triggered by pressing F key.
>
> When org buffer contains 2 TODOs like so:
>
> ** TODO one
> ** TODO two
>
> If one uses F follow mode in agenda, then as you move cursor in agenda
> buffer, the correct TODO line in the org buffer is highlighted.
>
> Now press T to mark 1st TODO DONE. It inserts a line into original org
> buffer like so:
>
> ** TODO one
>   CLOSED: <whatever>
> ** TODO two
>
> Now the F follow mode highlights the CLOSED line instead of the "TODO
> two" line when cursor is on the 2nd TODO in the agenda
> buffer. Basically it highlights the same line where the 2nd TODO
> _used_ to be, if the CLOSED line was not inserted.
>
> I can 100% reproduce this with either my own multi-tty emacs compile,
> or with the stock emacs that comes with suse 10.2, with only org.el
> loaded and with --no-init-file
>
> Regards,
>   Max
>
>> - Carsten
>>
>> On Aug 3, 2007, at 23:17, max@openchat.com wrote:
>>
>>> $ cat ~/org-bug.el
>>>
>>> (add-to-list 'load-path "~/org-5.04")
>>> (require 'org)
>>> (add-to-list 'auto-mode-alist (cons "\\.org$" 'org-mode))
>>> (setq org-agenda-files '("~/test.org"))
>>> (setq org-log-done t)
>>>
>>> $ cat ~/test.org
>>>
>>> * Not used								:bleah:
>>> ** TODO one
>>> ** TODO two
>>>
>>> $ emacs --no-init-file
>>> M-x load-file ~/org-bug.el RET  ;; set up the test case
>>> M-x org-agenda RET              ;; run agenda command
>>> t                               ;; press t key to display list of 
>>> todos
>>>                                 ;; the following buffer is 
>>> displayemwd
>>> -----------------------------------------------------
>>> Global list of TODO items of type: ALL
>>> Available with `N r': (0)ALL (1)TODO (2)DONE
>>>   test:       TODO one
>>>   test:       TODO two
>>> -----------------------------------------------------
>>> press <down> twice ;; cursor is on first TODO
>>> press t            ;; TODO changes to DONE
>>> press <down>       ;; cursor is on the 2nd TODO
>>> press t            ;; Agenda buffer changes to this
>>> -----------------------------------------------------
>>> Global list of TODO items of type: ALL
>>> Available with `N r': (0)ALL (1)TODO (2)DONE
>>>   test:       DONE one
>>>   test:       one
>>> -----------------------------------------------------
>>>
>>> And the 2nd TODO is not marked as DONE but remains unchanged
>>> in the ~/test.org buffer.
>>>
>>> Does not happen if org-log-done is not set.
>>>
>>> Regards,
>>>   Max
>>>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>
>>>
>>
>> --
>> Carsten Dominik
>> Sterrenkundig Instituut "Anton Pannekoek"
>> Universiteit van Amsterdam
>> Kruislaan 403
>> NL-1098SJ Amsterdam
>> phone: +31 20 525 7477
>>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477